[No QA] Replace deprecated functions: `runOnUI`, `runOnJS`, `runOnRuntime`, `executeOnUIRuntimeSync` by GCyganek · Pull Request #74486 · Expensify/App

GCyganek · 2025-11-06T14:49:31Z

Explanation of Change

after bumping Reanimated to v4 runOnUI, runOnJS, runOnRuntime and executeOnUIRuntimeSync from react-native-reanimated got deprecated and should be replaced with scheduleOnUI,scheduleOnRN, scheduleOnRuntime and runOnUISync from react-native-worklets

source: https://docs.swmansion.com/react-native-reanimated/docs/guides/migration-from-3.x/

Fixed Issues

Follow-up to #69469
$ N/A
PROPOSAL: N/A

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

codecov · 2025-11-06T15:02:19Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/components/AnimatedCollapsible/index.tsx	`69.56% <ø> (ø)`
.../components/CustomStatusBarAndBackground/index.tsx	`94.11% <ø> (ø)`
...mponents/Modal/ReanimatedModal/Container/index.tsx	`100.00% <ø> (ø)`
src/components/MultiGestureCanvas/usePanGesture.ts	`12.50% <ø> (ø)`
...c/components/MultiGestureCanvas/usePinchGesture.ts	`5.55% <ø> (ø)`
...rc/components/MultiGestureCanvas/useTapGestures.ts	`7.14% <ø> (ø)`
src/components/RNMarkdownTextInput.tsx	`86.66% <ø> (ø)`
src/components/SplashScreenHider/index.native.tsx	`100.00% <100.00%> (ø)`
...eoPlayer/VideoPlayerControls/ProgressBar/index.tsx	`7.69% <ø> (ø)`
...oPlayer/VideoPlayerControls/VolumeButton/index.tsx	`11.11% <ø> (ø)`
... and 16 more
... and 146 files with indirect coverage changes

GCyganek · 2025-11-06T15:09:33Z

src/hooks/useWorkletStateMachine/runOnUISync/index.ts

@@ -0,0 +1,7 @@
+// runOnUISync crashes on web not because browsers lack a UI thread concept,


https://github.com/software-mansion/react-native-reanimated/blob/4efcaca45927a4a74f0b1a4c1a2bef8b08145b2f/packages/react-native-worklets/src/threads.ts#L25

This suggests that runOnUISync (as execcuteOnUIRuntimeSync) is not supported on the web

The code comment starts by saying what doesn’t happen and only afterward explains the real reason. It would be clearer to state directly that runOnUISync fails because web doesn’t support it, instead of leading with a negation.

For example:

// runOnUISync isn't supported in web by react-native-worklets, so we use the async alternative on web.

github-actions · 2025-11-07T10:45:31Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

blazejkustra

Very elegant, minor comments @GCyganek 👏

blazejkustra · 2025-11-07T12:15:45Z

patches/react-native-worklets/details.md

+### [react-native-worklets+0.6.0.patch](react-native-worklets+0.6.0.patch)
+
+- Reason: [File with mocks](https://github.com/software-mansion/react-native-reanimated/blob/main/packages/react-native-worklets/src/mock.ts) hasn't been released yet for `react-native-worklets`, but it was needed to fix test failures after migration to `react-native-reainmated` v4.
+- Upstream PR/issue: N/A 


There is no issue in worklets repo? Let's create it 👍

blazejkustra · 2025-11-07T12:30:22Z

src/hooks/useWorkletStateMachine/runOnUISync/index.ts

@@ -0,0 +1,7 @@
+// runOnUISync crashes on web not because browsers lack a UI thread concept,


The code comment starts by saying what doesn’t happen and only afterward explains the real reason. It would be clearer to state directly that runOnUISync fails because web doesn’t support it, instead of leading with a negation.

For example:

// runOnUISync isn't supported in web by react-native-worklets, so we use the async alternative on web.

tomekzaw · 2025-11-09T22:56:55Z

src/libs/runOnLiveMarkdownRuntime/index.native.tsx

-import {runOnRuntime} from 'react-native-reanimated';
+import {scheduleOnRuntime} from 'react-native-worklets';

 function runOnLiveMarkdownRuntime<Args extends unknown[], ReturnType>(worklet: (...args: Args) => ReturnType) {


I think we should convert runOnLiveMarkdownRuntime to scheduleOnLiveMarkdownRuntime for the consistency with scheduleOnRN from react-native-worklets.

Thanks, good point

tomekzaw · 2025-11-09T22:58:09Z

src/components/withKeyboardState.tsx

                'worklet';

-                runOnJS(setIsKeyboardAnimating)(false);
+                scheduleOnRN(setIsKeyboardAnimating, true);


Previously this line was runOnJS(setIsKeyboardAnimating)(false); so it should be false instead of true.

Suggested change

scheduleOnRN(setIsKeyboardAnimating, true);

scheduleOnRN(setIsKeyboardAnimating, false);

tomekzaw · 2025-11-09T23:02:56Z

tests/ui/ReportActionComposeTest.tsx

+        beforeEach(() => {
+            jest.useFakeTimers();
+        });
+
+        afterEach(() => {
+            jest.useRealTimers();
+        });


Why do we need this now?

scheduleOnUI mock uses setTimeout (contrary to the mock that we had for react-native-animated counterpart), so without using

act(() => { jest.advanceTimersByTime(1); });

the test will fail

tomekzaw · 2025-11-10T19:10:47Z

src/components/RNMarkdownTextInput.tsx

+        scheduleOnLiveMarkdownRuntime(() => {
            'worklet';

            mentionsSharedVal.set(availableLoginsList);


Ideally we'd like scheduleOnLiveMarkdownRuntime to have the same signature as scheduleOnUI does, i.e. without the need to call the returned function, like this:

-scheduleOnLiveMarkdownRuntime(fn)(...args); // currently you need to add `();` at the end +scheduleOnLiveMarkdownRuntime(fn, ...args);

GCyganek · 2025-11-12T10:28:23Z

FYI ReportActionComposeTest fails because it gets stuck after changes in #67720 were introduced. There is already a revert PR for it as there are some other issues with it

GCyganek · 2025-11-12T14:01:58Z

Ready

GCyganek · 2025-11-14T08:27:58Z

@tomekzaw could you please take a look again so I can mark it as ready to review? 👉 👈

melvin-bot · 2025-11-14T08:43:22Z

@deetergp Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

joekaufmanexpensify · 2025-11-14T16:42:44Z

No product considerations, removing my review

deetergp · 2025-11-14T19:19:15Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-11-14T20:52:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-18T12:07:18Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.2.60-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-18T16:29:30Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.2.60-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-18T16:50:16Z

🚀 Deployed to staging by https://github.com/deetergp in version: 9.2.60-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-19T16:07:37Z

🚀 Deployed to production by https://github.com/grgia in version: 9.2.60-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Replace deprecated functions: runOnUI and runOnJS

2c3d5e9

melvin-bot bot assigned GCyganek Nov 6, 2025

GCyganek changed the title ~~[No QA] Replace deprecated functions: runOnUI and runOnJS~~ [No QA] Replace deprecated functions: runOnUI, runOnJS, runOnRuntime Nov 6, 2025

executeOnUIRuntimeSync, runOnRuntime

64ef14f

GCyganek changed the title ~~[No QA] Replace deprecated functions: runOnUI, runOnJS, runOnRuntime~~ [No QA] Replace deprecated functions: runOnUI, runOnJS, runOnRuntime, executeOnUIRuntimeSync Nov 6, 2025

GCyganek commented Nov 6, 2025

View reviewed changes

GCyganek added 2 commits November 6, 2025 16:12

Fix lint errors

ca16ab0

Add mocks for react-native-worklets

15ee81e

GCyganek added 5 commits November 7, 2025 11:47

Merge branch 'main' into @GCyganek/replace-runOnJS-runOnUI

65eafd2

Add patch reason

79cc157

Fix timers

b904f98

Fix spelling issue

601e9a3

Merge branch 'main' into @GCyganek/replace-runOnJS-runOnUI

f4a2d09

blazejkustra approved these changes Nov 7, 2025

View reviewed changes

GCyganek added 7 commits November 7, 2025 14:16

Move react-native-worklets mocks to our setup

60f615f

runOnUISync/index.ts comment

4c0dd9c

Spelling issues fix

e3eeefc

Rerun Jest tests

201967c

jest.unmock('react-native-worklets')

bab4700

Rerun Jest tests

3a8237d

Rerun Jest tests

ddb82d0

tomekzaw reviewed Nov 9, 2025

View reviewed changes

GCyganek added 3 commits November 10, 2025 15:13

Fix onEnd param

3cd0e0e

runOnLiveMarkdownRuntime => scheduleOnLiveMarkdownRuntime

f67e6b6

Merge branch 'main' into @GCyganek/replace-runOnJS-runOnUI

fb279d0

tomekzaw reviewed Nov 10, 2025

View reviewed changes

scheduleOnLiveMarkdownRuntime signature adjustments

7ca7b63

GCyganek requested a review from tomekzaw November 12, 2025 08:24

GCyganek added 2 commits November 12, 2025 09:37

Merge branch 'main' into @GCyganek/replace-runOnJS-runOnUI

0fc5d1c

Rerun Jest tests

b9861fa

Merge branch 'main' into @GCyganek/replace-runOnJS-runOnUI

a003c61

tomekzaw approved these changes Nov 14, 2025

View reviewed changes

GCyganek marked this pull request as ready for review November 14, 2025 08:42

GCyganek requested review from a team as code owners November 14, 2025 08:42

melvin-bot bot requested review from deetergp and joekaufmanexpensify and removed request for a team November 14, 2025 08:42

joekaufmanexpensify removed their request for review November 14, 2025 16:42

deetergp approved these changes Nov 14, 2025

View reviewed changes

deetergp merged commit c6988d5 into Expensify:main Nov 14, 2025
28 of 29 checks passed

OSBotify mentioned this pull request Nov 18, 2025

Deploy Checklist: New Expensify 2025-11-18 #75383

Closed

58 tasks

		@@ -0,0 +1,7 @@
		// runOnUISync crashes on web not because browsers lack a UI thread concept,

	scheduleOnRN(setIsKeyboardAnimating, true);
	scheduleOnRN(setIsKeyboardAnimating, false);

Conversation

GCyganek commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 6, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tomekzaw Nov 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

GCyganek commented Nov 12, 2025

Uh oh!

GCyganek commented Nov 12, 2025

Uh oh!

GCyganek commented Nov 14, 2025

Uh oh!

melvin-bot bot commented Nov 14, 2025

Uh oh!

joekaufmanexpensify commented Nov 14, 2025

Uh oh!

deetergp commented Nov 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 14, 2025

Uh oh!

OSBotify commented Nov 18, 2025

Uh oh!

OSBotify commented Nov 18, 2025

Uh oh!

OSBotify commented Nov 18, 2025

Uh oh!

OSBotify commented Nov 19, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

GCyganek commented Nov 6, 2025 •

edited

Loading

codecov bot commented Nov 6, 2025 •

edited by github-actions bot

Loading

tomekzaw Nov 10, 2025 •

edited

Loading

deetergp commented Nov 14, 2025 •

edited

Loading