Skip to content

[CP Staging] Revert "Fix suggestion list cursor bug"#74921

Merged
cristipaval merged 2 commits intomainfrom
revert-67720-suggestion-list-fix
Nov 12, 2025
Merged

[CP Staging] Revert "Fix suggestion list cursor bug"#74921
cristipaval merged 2 commits intomainfrom
revert-67720-suggestion-list-fix

Conversation

@cristipaval
Copy link
Contributor

@cristipaval cristipaval commented Nov 12, 2025

Reverts #67720
Reverts #74817

This reverts the offending PR that introduced 2 deploy blockers and a follow-up PR that tried to patch one of them. We decided to revert because it was risky to patch code around the composer component, which is a core part of the product. you can see more context here.

The offending PR also made perf tests fail for other PRs. We discussed the performance tests here.

$ #74844
$ #74803

@github-actions
Copy link
Contributor

🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here.

@codecov
Copy link

codecov bot commented Nov 12, 2025

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
...omposerWithSuggestions/ComposerWithSuggestions.tsx 59.45% <53.84%> (+1.24%) ⬆️
... and 6 files with indirect coverage changes

@github-actions
Copy link
Contributor

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #74921.

Android 🤖 iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/74921/index.html https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/74921/index.html
Android iOS
Desktop 💻 Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/74921/NewExpensify.dmg https://74921.pr-testing.expensify.com
Desktop Web

👀 View the workflow run that generated this build 👀

@cristipaval cristipaval force-pushed the revert-67720-suggestion-list-fix branch from 095ba9d to 93d677b Compare November 12, 2025 11:50
@cristipaval cristipaval marked this pull request as ready for review November 12, 2025 12:21
@cristipaval cristipaval requested review from a team as code owners November 12, 2025 12:21
@melvin-bot melvin-bot bot requested review from trjExpensify and removed request for a team November 12, 2025 12:21
@cristipaval cristipaval changed the title Revert "Fix suggestion list cursor bug" [CP Staging] Revert "Fix suggestion list cursor bug" Nov 12, 2025
@melvin-bot melvin-bot bot requested review from justinpersaud and removed request for a team November 12, 2025 12:22
@melvin-bot
Copy link

melvin-bot bot commented Nov 12, 2025

@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cristipaval
Copy link
Contributor Author

See this for info about the perf tests

@cristipaval cristipaval merged commit ba587a7 into main Nov 12, 2025
28 of 32 checks passed
@cristipaval cristipaval deleted the revert-67720-suggestion-list-fix branch November 12, 2025 12:25
@melvin-bot melvin-bot bot added the Emergency label Nov 12, 2025
@melvin-bot
Copy link

melvin-bot bot commented Nov 12, 2025

@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@cristipaval
Copy link
Contributor Author

Straight revert

OSBotify pushed a commit that referenced this pull request Nov 12, 2025
…-fix

[CP Staging] Revert "Fix suggestion list cursor bug"

(cherry picked from commit ba587a7)

(cherry-picked to staging by cristipaval)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 12, 2025
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.54-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.55-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.57-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants