[CP Staging] Revert "Fix suggestion list cursor bug"#74921
Conversation
|
🚧 @cristipaval has triggered a test Expensify/App build. You can view the workflow run here. |
Codecov Report✅ Changes either increased or maintained existing code coverage, great job!
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
095ba9d to
93d677b
Compare
|
@justinpersaud Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
See this for info about the perf tests |
|
@cristipaval looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
Straight revert |
…-fix [CP Staging] Revert "Fix suggestion list cursor bug" (cherry picked from commit ba587a7) (cherry-picked to staging by cristipaval)
|
🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.54-1 🚀
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.54-1 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.55-3 🚀
|
|
🚀 Cherry-picked to staging by https://github.com/cristipaval in version: 9.2.57-0 🚀
|
|
🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.57-4 🚀
|
Reverts #67720
Reverts #74817
This reverts the offending PR that introduced 2 deploy blockers and a follow-up PR that tried to patch one of them. We decided to revert because it was risky to patch code around the composer component, which is a core part of the product. you can see more context here.
The offending PR also made perf tests fail for other PRs. We discussed the performance tests here.
$ #74844
$ #74803