Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION in src/libs/TransactionUtils/index.ts #69760

DylanDylann · 2025-09-03T10:28:51Z

Explanation of Change

Fixed Issues

$ #66463
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create 2 same expenses
Review duplicate transaction
Keep one of them
Verify that there is only one transaction and that the information displays correctly

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Screen.Recording.2025-09-04.at.14.11.21.mov

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-03T10:28:57Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-09-03T10:45:12Z

~~It seems we have a crash main, I will add test steps after it is resolved~~

Done

trjExpensify · 2025-09-03T16:59:42Z

Refactor PR, doesn’t have any new product considerations. Removing the tag and unsubscribing myself.

DylanDylann · 2025-09-04T07:10:54Z

Reassure Performance Tests failed by main

github-actions · 2025-09-08T14:26:54Z

⚠️ This PR is possibly changing native code and/or updating libraries, it may cause problems with HybridApp. Please check if any patch updates are required in the HybridApp repo and run an AdHoc build to verify that HybridApp will not break. Ask Contributor Plus for help if you are not sure how to handle this. ⚠️

src/libs/TransactionUtils/index.ts

shubham1206agra · 2025-09-11T12:37:41Z

src/components/ProcessMoneyReportHoldMenu.tsx

    // We need to use isSmallScreenWidth instead of shouldUseNarrowLayout to apply the correct modal type
    // eslint-disable-next-line rulesdir/prefer-shouldUseNarrowLayout-instead-of-isSmallScreenWidth
    const {isSmallScreenWidth} = useResponsiveLayout();
+    const linkedTransactionID = getLinkedTransactionID(Navigation.getTopmostReportActionId(), moneyRequestReport?.reportID);


@DylanDylann Is it possible to pull reportAction directly from Onyx here?

@shubham1206agra What do you mean? which reportAction?

ReportActin that you are using to get transactionID

@shubham1206agra This logic isn’t newly introduced in this PR, I only moved it from the original isLinkedTransactionHeld function. I think we should keep it as is for now and avoid expanding the scope of this PR. It can be addressed later when we remove the subscription to ONYXKEYS.COLLECTION.REPORT_ACTIONS.

@DylanDylann Let's hold this PR on #71197 as I removed the logic and tested the flow if it is working fine or not.

src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx

DylanDylann · 2025-09-12T05:25:16Z

@shubham1206agra Back to you

DylanDylann · 2025-09-16T15:32:49Z

@shubham1206agra Kindly bump

src/components/ProcessMoneyReportHoldMenu.tsx

DylanDylann · 2025-10-09T03:01:35Z

Should be on hold: #72086

codecov · 2025-10-27T05:37:47Z

Codecov Report

❌ Patch coverage is 37.50000% with 20 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/MoneyReportHeader.tsx	0.00%	4 Missing ⚠️
src/components/MoneyRequestHeader.tsx	0.00%	3 Missing ⚠️
...c/components/ReportActionItem/MoneyRequestView.tsx	0.00%	3 Missing ⚠️
src/hooks/useDeleteTransactions.ts	0.00%	2 Missing ⚠️
src/pages/TransactionDuplicate/Confirmation.tsx	0.00%	2 Missing ⚠️
src/pages/iou/SplitExpenseEditPage.tsx	0.00%	2 Missing ⚠️
src/pages/iou/SplitExpensePage.tsx	0.00%	2 Missing ⚠️
...ents/ReportActionItem/TransactionPreview/index.tsx	66.66%	1 Missing ⚠️
src/libs/TransactionUtils/index.ts	50.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
...m/TransactionPreview/TransactionPreviewContent.tsx	`75.55% <100.00%> (+0.27%)`	⬆️
src/libs/ReportSecondaryActionUtils.ts	`90.93% <100.00%> (ø)`
src/libs/TransactionPreviewUtils.ts	`72.88% <100.00%> (ø)`
src/libs/actions/IOU.ts	`64.43% <100.00%> (+0.02%)`	⬆️
...ents/ReportActionItem/TransactionPreview/index.tsx	`84.37% <66.66%> (-2.30%)`	⬇️
src/libs/TransactionUtils/index.ts	`68.26% <50.00%> (-0.65%)`	⬇️
src/hooks/useDeleteTransactions.ts	`15.38% <0.00%> (-0.25%)`	⬇️
src/pages/TransactionDuplicate/Confirmation.tsx	`0.00% <0.00%> (ø)`
src/pages/iou/SplitExpenseEditPage.tsx	`0.00% <0.00%> (ø)`
src/pages/iou/SplitExpensePage.tsx	`0.00% <0.00%> (ø)`
... and 3 more

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DylanDylann · 2025-10-29T09:15:31Z

@shubham1206agra Kindly bump

DylanDylann · 2025-11-03T09:59:45Z

@shubham1206agra Any chance you could review this PR?

shubham1206agra · 2025-11-12T13:57:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-11-12.at.7.26.04.PM.mov

OSBotify · 2025-11-19T13:36:38Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-19T16:35:51Z

🚀 Deployed to staging by https://github.com/danieldoglas in version: 9.2.61-0 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-21T12:04:40Z

🚀 Deployed to production by https://github.com/grgia in version: 9.2.61-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

remove connect method

0405eba

DylanDylann requested review from a team as code owners September 3, 2025 10:28

melvin-bot bot assigned DylanDylann Sep 3, 2025

melvin-bot bot requested review from shubham1206agra and removed request for a team September 3, 2025 10:28

DylanDylann added 3 commits September 3, 2025 17:38

fix UTs

deb7bdb

Merge branch 'main' into refactor-304

2f6e419

fix type

2a21a9a

trjExpensify removed the request for review from a team September 3, 2025 16:59

Merge branch 'main' into refactor-304

73f4756

Merge branch 'main' into refactor-304

05e7a10

shubham1206agra reviewed Sep 11, 2025

View reviewed changes

src/libs/TransactionUtils/index.ts Show resolved Hide resolved

shubham1206agra reviewed Sep 11, 2025

View reviewed changes

src/components/ReportActionItem/TransactionPreview/TransactionPreviewContent.tsx Outdated Show resolved Hide resolved

DylanDylann added 2 commits September 12, 2025 12:10

Merge branch 'main' into refactor-304

41ec508

fix comment

2afb75b

Merge branch 'main' into refactor-304

6c30c51

shubham1206agra reviewed Sep 18, 2025

View reviewed changes

src/components/ProcessMoneyReportHoldMenu.tsx Outdated Show resolved Hide resolved

DylanDylann closed this Oct 8, 2025

DylanDylann force-pushed the refactor-304 branch from 26bfcef to c3f1cc2 Compare October 8, 2025 04:26

Merge branch 'main' into refactor-304

abd0bce

DylanDylann reopened this Oct 8, 2025

DylanDylann added 2 commits October 8, 2025 15:16

resolve conflict

b02c97a

resolve conflict

60cf1a4

DylanDylann added 5 commits October 24, 2025 14:56

Merge branch 'main' into refactor-304

4d0cb86

chore: prettier

7ac516f

Merge branch 'main' into refactor-304

551fe56

Update UTs

59184d9

chore: remove dup definition

56bfc37

Merge branch 'main' into refactor-304

9f8c52d

shubham1206agra approved these changes Nov 12, 2025

View reviewed changes

melvin-bot bot requested a review from danieldoglas November 12, 2025 13:57

Merge branch 'main' into refactor-304

9cf7154

danieldoglas approved these changes Nov 18, 2025

View reviewed changes

danieldoglas merged commit 9d3daec into Expensify:main Nov 18, 2025
26 checks passed

github-actions bot mentioned this pull request Nov 18, 2025

Investigate workflow job failing on main: typecheck / typecheck #75464

Closed

OSBotify mentioned this pull request Nov 19, 2025

Deploy Checklist: New Expensify 2025-11-19 #75561

Closed

57 tasks

melvin-bot bot mentioned this pull request Nov 21, 2025

[Due for payment 2025-11-28] Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION in src/libs/TransactionUtils/index.ts #66463

Closed

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION in src/libs/TransactionUtils/index.ts #69760

Remove Onyx.connect() for the key: ONYXKEYS.COLLECTION.TRANSACTION in src/libs/TransactionUtils/index.ts #69760

Uh oh!

Conversation

DylanDylann commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 3, 2025

Uh oh!

DylanDylann commented Sep 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trjExpensify commented Sep 3, 2025

Uh oh!

DylanDylann commented Sep 4, 2025

Uh oh!

github-actions bot commented Sep 8, 2025

Uh oh!

Uh oh!

shubham1206agra Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

DylanDylann Sep 12, 2025

Choose a reason for hiding this comment

Uh oh!

shubham1206agra Sep 24, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DylanDylann commented Sep 12, 2025

Uh oh!

DylanDylann commented Sep 16, 2025

Uh oh!

Uh oh!

DylanDylann commented Oct 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DylanDylann commented Oct 29, 2025

Uh oh!

DylanDylann commented Nov 3, 2025

Uh oh!

shubham1206agra commented Nov 12, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 19, 2025

Uh oh!

OSBotify commented Nov 19, 2025

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

DylanDylann commented Sep 3, 2025 •

edited

Loading

DylanDylann commented Sep 3, 2025 •

edited

Loading

DylanDylann commented Oct 9, 2025 •

edited

Loading

codecov bot commented Oct 27, 2025 •

edited

Loading