[NO QA] feat: setup Sentry as a observability solution#70298
[NO QA] feat: setup Sentry as a observability solution#70298rlinoz merged 34 commits intoExpensify:mainfrom
Conversation
|
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
| export default function () { | ||
| Timing.start(CONST.TIMING.SPLASH_SCREEN); | ||
| const navigationIntegration = Sentry.reactNavigationIntegration({ | ||
| enableTimeToInitialDisplay: true, |
There was a problem hiding this comment.
can be overwritten using https://docs.sentry.io/platforms/react-native/tracing/instrumentation/time-to-display/#time-to-initial-display-overwrite if we want to await some more UI being loaded (and the default turns out to be falsy)
|
Note to self: setting up https://docs.sentry.io/platforms/react-native/tracing/instrumentation/automatic-instrumentation/#react-profiler might make sense for the most heavy parts of the UI. |
This comment has been minimized.
This comment has been minimized.
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Codecov Report❌ Patch coverage is
... and 77 files with indirect coverage changes 🚀 New features to boost your workflow:
|
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
src/setup/telemetry/index.ts
Outdated
| enableAutoPerformanceTracing: true, | ||
| enableUserInteractionTracing: true, | ||
| integrations: [navigationIntegration], | ||
| environment: `${CONFIG.ENVIRONMENT}}`, |
There was a problem hiding this comment.
you have double } at the end
There was a problem hiding this comment.
it's a string already so it's just do environment: CONFIG.ENVIRONMENT
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
|
🚧 @rlinoz has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppiOS: mWeb SafariMacOS: Chrome / SafariMacOS: Desktop |
|
All good on our end with @rinej for merging 👍🏻 |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.40-0 🚀
|
|
🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.40-0 🚀
|
|
@adhorodyski how can I troubleshoot this error?
Because of this, I cannot test android at all, stuck on splash screen. |
|
@situchan this is on the development environment, correct? |
yes, I didn't touch anything related to env. |
|
Oki, we're working on a hotfix so we can avoid reverting 🫡 |
|
Fixing it here #73745 |
|
Should be fixed no, @situchan thank you for reporting Can you please confirm if this is working fine for you now? |
|
It works now. Thanks for the quick fix. |
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.40-1 🚀
|

@rlinoz @mountiny
Explanation of Change
Fixed Issues
$ #71498
PROPOSAL:
Tests
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop