Fix/reopen 66724 #71037

linhvovan29546 · 2025-09-23T02:16:57Z

Explanation of Change

Fixed Issues

$ #66724
PROPOSAL: #66724 (comment)

Tests

Connect a card feed
Make sure "allow deleting transactions" is disabled
Assign a card with expenses
Unreport the expenses(You can move this card expense to another workspace, and then remove it. This action will automatically move the expense to your personal workspace.)
Go to your personal space
Tap one of the expenses.
Long press the item and verify that the Delete option does not appear in the popover.
Open the expense
Verify that the Delete option is not present under the More button.

Verify that no errors appear in the JS console
This also fix the issue Report can't be deleted if it has added moved expense first #71018

Offline tests

Same as above

QA Steps

Same as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-09-02.at.17.10.19.mov

Android: mWeb Chrome

Screen.Recording.2025-09-02.at.17.13.18.mov

iOS: Native

Screen.Recording.2025-09-02.at.16.59.29.mov

iOS: mWeb Safari

Screen.Recording.2025-09-02.at.16.31.32.mov

MacOS: Chrome / Safari

Screen.Recording.2025-09-02.at.16.24.33.mov

Issue 71018
https://github.com/user-attachments/assets/448551fb-c181-428f-b36e-38fea3c4b125

MacOS: Desktop

Screen.Recording.2025-09-02.at.16.28.02.mov

melvin-bot · 2025-09-23T07:56:07Z

@mananjadhav Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-09-23T16:59:07Z

Reviewed, will test this by tomorrow.

codecov · 2025-09-26T05:13:41Z

Codecov Report

❌ Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/libs/ReportUtils.ts	40.00%	3 Missing ⚠️

📢 Thoughts on this report? Let us know!

linhvovan29546 · 2025-09-26T08:23:38Z

Codecov Report

❌ Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/libs/ReportUtils.ts 60.00% 2 Missing ⚠️
📢 Thoughts on this report? Let us know!

We already have a unit test for:

if (isSingleTransaction && !canCardTransactionBeDeleted) {
    return false;
}

so the coverage should be sufficient.

mananjadhav · 2025-09-30T14:10:15Z

@linhvovan29546 Can you please resolve the conflicts? I'll resolve the checklist by start of day tomorrow.

linhvovan29546 · 2025-10-01T02:46:48Z

@mananjadhav I've force-pushed the commit because the previous one included Mobile-Expensify when I merged main.

linhvovan29546 · 2025-10-01T03:01:05Z

Mobile-Expensify is still included in the commit. I'm looking for a way to exclude it.

…eting disabled

linhvovan29546 · 2025-10-01T03:15:03Z

The simplest solution I found was to reset the main branch to clean up the commits.

mananjadhav · 2025-10-02T12:27:29Z

@linhvovan29546 Is it resolved? I don't see Mobile-Expensify commits though.

linhvovan29546 · 2025-10-02T12:31:00Z

Yeah, that's resolved

mananjadhav · 2025-10-02T14:51:55Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-delete-card-expense.mov

Android: mWeb Chrome

mweb-chrome-delete-card-expense.mov

iOS: HybridApp

iOS: mWeb Safari

mweb-safari-delete-card-expense.mov

MacOS: Chrome / Safari

web-delete-card-expense.mov

MacOS: Desktop

desktop-delete-card-expense.mov

mananjadhav

Having issues with iOS simulator. Tested on other platforms.

src/libs/ReportUtils.ts

OSBotify · 2025-10-08T05:10:32Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-08T21:35:04Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

melvin-bot bot assigned linhvovan29546 Sep 23, 2025

linhvovan29546 marked this pull request as ready for review September 23, 2025 07:56

linhvovan29546 requested a review from a team as a code owner September 23, 2025 07:56

melvin-bot bot requested a review from mananjadhav September 23, 2025 07:56

melvin-bot bot removed the request for review from a team September 23, 2025 07:56

Pujan92 mentioned this pull request Sep 23, 2025

filtered personal chats out of list when submitting expense with coprate card #69815

Closed

51 tasks

linhvovan29546 force-pushed the fix/reopen-66724 branch from c1dc96d to 058a544 Compare October 1, 2025 02:44

linhvovan29546 force-pushed the fix/reopen-66724 branch from 058a544 to fb8d282 Compare October 1, 2025 02:58

fix: hide delete button for unreported card expense imported with del…

26d5253

…eting disabled

linhvovan29546 force-pushed the fix/reopen-66724 branch from fb8d282 to 26d5253 Compare October 1, 2025 03:13

mananjadhav approved these changes Oct 2, 2025

View reviewed changes

melvin-bot bot requested a review from grgia October 2, 2025 14:52

grgia reviewed Oct 2, 2025

View reviewed changes

src/libs/ReportUtils.ts Outdated Show resolved Hide resolved

chore: rename

cd476b9

grgia approved these changes Oct 7, 2025

View reviewed changes

grgia merged commit d36cd0c into Expensify:main Oct 7, 2025
21 checks passed

github-actions bot mentioned this pull request Oct 7, 2025

Investigate workflow job failing on main: typecheck / typecheck #72019

Closed

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72057

Closed

62 tasks

jponikarchuk mentioned this pull request Oct 8, 2025

[$250] Expense - Card expense moved to IOU shows unexpected error. #72069

Closed

8 tasks

melvin-bot bot mentioned this pull request Oct 8, 2025

[Due for payment 2025-10-15] [Due for payment 2025-09-30] [$250] We show delete button for unreported card expenses imported with deleting disabled #66724

Closed

16 tasks

Fix/reopen 66724 #71037

Fix/reopen 66724 #71037

Uh oh!

Conversation

linhvovan29546 commented Sep 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 23, 2025

Uh oh!

mananjadhav commented Sep 23, 2025

Uh oh!

codecov bot commented Sep 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

linhvovan29546 commented Sep 26, 2025

Codecov Report

Uh oh!

mananjadhav commented Sep 30, 2025

Uh oh!

linhvovan29546 commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

linhvovan29546 commented Oct 1, 2025

Uh oh!

linhvovan29546 commented Oct 1, 2025

Uh oh!

mananjadhav commented Oct 2, 2025

Uh oh!

linhvovan29546 commented Oct 2, 2025

Uh oh!

mananjadhav commented Oct 2, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

mananjadhav left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

linhvovan29546 commented Sep 23, 2025 •

edited

Loading

codecov bot commented Sep 26, 2025 •

edited

Loading

linhvovan29546 commented Oct 1, 2025 •

edited

Loading