-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Bump Onyx to 3.0.1 #71369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Onyx to 3.0.1 #71369
Conversation
|
|
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
cc @roryabraham |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm basically removing a couple of completely duplicated tests that were inside two test suites, and unified everything in just one.
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-app-2025-10-02_11.45.00.mp4Android: mWeb Chromeandroid-chrome-2025-10-02_11.54.21.mp4iOS: HybridAppios-app-2025-10-02_12.07.34.mp4iOS: mWeb Safariios-safari-2025-10-02_12.09.24.mp4MacOS: Chrome / Safaridesktop-chrome-2025-10-02_11.55.24.mp4MacOS: Desktopdesktop-app-2025-10-02_11.59.32.mp4 |
jjcoffee
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well and LGTM!
|
Ah I think you might need to grab the latest version of the author checklist @fabioh8010. |
|
@fabioh8010 You have conflicts. |
|
@tgolen your review was requested as a codeowner of philosophies. The only changes there were removing some outdated examples, so I'm going to optimistically merge this to avoid further conflicts. I'm sure if you have comments @fabioh8010 would be happy to follow up. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.23-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.23-3 🚀
|
Explanation of Change
This PR bumps Onyx from 2.0.138 to 3.0.1, which includes the following changes:
Onyx.updatereact-native-onyx#681 (no impact because PR was reverted)Onyx.update" react-native-onyx#683 (no impact because PR was reverted)This PR also removes some remaining
withOnyxreferences, and remove duplicate tests fromtests/ui/TransactionItemRowRBRTest.tsx.Fixed Issues
$ #64225
PROPOSAL:
Tests
Testing around Workspace creation, that will cover these changes (Expensify/react-native-onyx#677):
Offline tests
N/A
QA Steps
Same as Tests.
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-09-28.at.11.33.04-compressed.mov
Android: mWeb Chrome
Screen.Recording.2025-09-28.at.11.35.14-compressed.mov
iOS: Native
Screen.Recording.2025-09-28.at.11.44.55-compressed.mov
iOS: mWeb Safari
Screen.Recording.2025-09-28.at.11.46.43-compressed.mov
MacOS: Chrome / Safari
Screen.Recording.2025-09-28.at.11.48.12-compressed.mov
Screen.Recording.2025-09-28.at.11.49.36-compressed.mov
MacOS: Desktop
Screen.Recording.2025-09-28.at.11.55.33-compressed.mov