feat: Add components for interactive keyboard dismissal #71438

chrispader · 2025-09-28T10:42:42Z

@roryabraham @trjExpensify @parasharrajat

Explanation of Change

Adds new list components needed for interactive keyboard dismissal and refactors current FlatList and InvertedFlatList components to integrate this new logic.

Specifically, adds the following list components:

KeyboardDismissableFlatList: A list component that implements interactive keyboard dismissal logic and shares scroll values and measurements via a context
AnimatedFlatListWithCellRendererComponent: A copy of Reanimated.FlatList which additionally implements a custom CellRendererComponent

Fixed Issues

$ #54270
PROPOSAL:

Tests

Verify that no errors appear in the JS console

This PR does not intend to change any current behaviour, as it just refactors and adds new components, that still have to be used and enabled with a flag. Therefore:

Test every screen/flow that contains a list and check for regression.
Test for expected previous behavior everywhere.

Offline tests

QA Steps

Verify that no errors appear in the JS console

This PR does not intend to change any current behaviour, as it just refactors and adds new components, that still have to be used and enabled with a flag. Therefore:

Test every screen/flow that contains a list and check for regression.
Test for expected previous behavior everywhere.

PR Author Checklist

Screenshots/Videos

Same UI as before.

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

melvin-bot · 2025-09-28T18:57:06Z

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-09-29T18:33:25Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

src/components/InvertedFlatList/shouldRemoveClippedSubviews/index.native.ts

…/remove-react-native-modal" This reverts commit 17b4214, reversing changes made to 5f82c64.

chrispader · 2025-12-01T10:11:06Z

On it! :)

chrispader · 2025-12-02T09:04:04Z

Ok so the reason for this "bug" was that i adapted the ActionSheetAwareScrollView component to also be used on Android. Previously we only applied that spacing on iOS.

@parasharrajat i fixed the bug by disabling this extra spacing on Android

In #66240, we are working on removing that extra spacing behavior alltogether, but for consistency sakes, should this be enabled on Android as well, or why did we only add this for iOS in the first place? cc @mountiny

parasharrajat · 2025-12-02T18:15:53Z

Although this bug is now resolved on Android, but earlier behaviour was making both Android and iOS behave the same.

This same bug still happens on ios #71438 (comment) which is also present on prod.

parasharrajat

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

parasharrajat · 2025-12-02T18:18:50Z

I approved it as it is passed from my side. But we should discuss this #71438 (comment) first.

parasharrajat · 2025-12-02T18:19:04Z

@chrispader There are check failures.

mountiny · 2025-12-03T17:52:30Z

@chrispader can you take a look at the jest failures?

I am not sure what was the reason for it but if there are no regressions when enabled on android, I think we can keep it

mountiny · 2025-12-03T18:04:17Z

Testing is completed so we need to test jest

chrispader · 2025-12-03T21:32:21Z

I am not sure what was the reason for it but if there are no regressions when enabled on android, I think we can keep it

@mountiny hmm so i wouldn't see it as a regression, but it would introduce new behavior on Android, since this hasn't been enabled before. So this is more of a product/UX question. I'd enable it in a follow-up PR anyway, to not hold this PR on it. @mountiny Lmk whether we you think we should enable this on Android too

chrispader · 2025-12-03T21:32:31Z

Jest tests fixed!

parasharrajat · 2025-12-04T05:45:32Z

Let's keep the same behaviour as PROD and merge this PR. We can create a new PR if we need to enable that.

parasharrajat · 2025-12-04T05:45:42Z

Conflicts again @chrispader

chrispader · 2025-12-04T12:07:47Z

Conflicts again @chrispader

@parasharrajat resolved!

Let's keep the same behaviour as PROD and merge this PR. We can create a new PR if we need to enable that.

Yes, aggree. Let's do it like that

roryabraham · 2025-12-04T22:35:39Z

src/components/ActionSheetAwareScrollView/__mocks__/index.android.tsx

@@ -0,0 +1,11 @@
+import {Actions, ActionSheetAwareScrollViewContext, ActionSheetAwareScrollViewProvider} from './ActionSheetAwareScrollViewContext';


/components/ActionSheetAwareScrollView/__mocks__/index.android.tsx, /components/ActionSheetAwareScrollView/__mocks__/index.ios.tsx, and /components/ActionSheetAwareScrollView/__mocks__/index.tsx are the same. Combine them into a single /components/ActionSheetAwareScrollView/__mocks__/index.tsx

OSBotify · 2025-12-04T23:13:55Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-05T18:28:39Z

🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.73-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-09T09:57:42Z

🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.73-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

feat: add components for interactive keyboard dismissal

32e4600

melvin-bot bot assigned chrispader Sep 28, 2025

chrispader added 4 commits September 28, 2025 11:59

remove

c681686

fix: rename addtionalOnScrollHandler prop

677b37a

fix: simplify list structure and scroll event handling

51d7a7d

fix: make consistent naming

96675d3

chrispader changed the title ~~feat: Add components for interactive keyboard dismissal~~ [WIP] feat: Add components for interactive keyboard dismissal Sep 28, 2025

refactor: remove files from other PR

8d667dd

chrispader mentioned this pull request Sep 28, 2025

feat: Migrate lists to interactive keyboard dismissal #71440

Open

51 tasks

chrispader added 3 commits September 28, 2025 19:32

fix: typo

1f8334b

remove files from other PR

8270dbf

fix: mock path

cc24960

chrispader changed the title ~~[WIP] feat: Add components for interactive keyboard dismissal~~ feat: Add components for interactive keyboard dismissal Sep 28, 2025

chrispader marked this pull request as ready for review September 28, 2025 18:57

chrispader requested a review from a team as a code owner September 28, 2025 18:57

melvin-bot bot requested a review from parasharrajat September 28, 2025 18:57

melvin-bot bot removed the request for review from a team September 28, 2025 18:57

chrispader mentioned this pull request Sep 28, 2025

feat: interactive keyboard dismissal #65517

Closed

49 tasks

mountiny self-requested a review September 29, 2025 18:32

This comment has been minimized.

Sign in to view

parasharrajat reviewed Sep 29, 2025

View reviewed changes

src/components/InvertedFlatList/shouldRemoveClippedSubviews/index.native.ts Show resolved Hide resolved

CortneyOfstad mentioned this pull request Sep 30, 2025

Improve the composer swipe down closing logic #54270

Open

chrispader added 6 commits October 2, 2025 16:25

Merge branch 'main' into pr/71438

36dea4c

Revert "Merge pull request Expensify#70289 from software-mansion-labs…

5bd84d7

…/remove-react-native-modal" This reverts commit 17b4214, reversing changes made to 5f82c64.

fix: useKeyboardDismissableFlatListValues mock

2efbe9b

refactor: restructure usePreventScrollOnKeyboardInteraction

c8104d7

rename ref

7623249

refactor: rename custom FlatList displayName

32c3c8d

chrispader added 2 commits December 2, 2025 09:52

Merge branch 'main' into pr/71438

127e1cc

fix: disable ActionSheetAwareScrollView behavior on Android

3ab7b7f

fix: prettier and eslint

d878a29

parasharrajat approved these changes Dec 2, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham December 2, 2025 18:18

chrispader added 2 commits December 3, 2025 21:26

Merge branch 'main' into pr/71438

034f1c9

fix: remove redundant mock

c761bd1

fix: add back mock

611c39f

Merge branch 'main' into pr/71438

04948a6

roryabraham approved these changes Dec 4, 2025

View reviewed changes

roryabraham merged commit c731845 into Expensify:main Dec 4, 2025
30 checks passed

OSBotify mentioned this pull request Dec 5, 2025

Deploy Checklist: New Expensify 2025-12-05 #76837

Closed

73 tasks

jponikarchuk mentioned this pull request Dec 8, 2025

[Due for payment 2026-01-20] [$250] Expense report - Rejected expense is displayed duplicated in the report #76982

Closed

8 tasks

chrispader mentioned this pull request Dec 16, 2025

[WIP] Refactor FlatList component hierarchy #70378

Draft

51 tasks

chrispader mentioned this pull request Jan 14, 2026

Migrate the main chat list to FlashList #33725

Open

		@@ -0,0 +1,11 @@
		import {Actions, ActionSheetAwareScrollViewContext, ActionSheetAwareScrollViewProvider} from './ActionSheetAwareScrollViewContext';

feat: Add components for interactive keyboard dismissal #71438

feat: Add components for interactive keyboard dismissal #71438

Uh oh!

Conversation

chrispader commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Sep 28, 2025

Uh oh!

github-actions bot commented Sep 29, 2025

Uh oh!

This comment has been minimized.

Uh oh!

chrispader commented Dec 1, 2025

Uh oh!

chrispader commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat commented Dec 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

parasharrajat left a comment

Choose a reason for hiding this comment

Reviewer Checklist

Uh oh!

parasharrajat commented Dec 2, 2025

Uh oh!

parasharrajat commented Dec 2, 2025

Uh oh!

mountiny commented Dec 3, 2025

Uh oh!

mountiny commented Dec 3, 2025

Uh oh!

chrispader commented Dec 3, 2025

Uh oh!

chrispader commented Dec 3, 2025

Uh oh!

parasharrajat commented Dec 4, 2025

Uh oh!

parasharrajat commented Dec 4, 2025

Uh oh!

chrispader commented Dec 4, 2025

Uh oh!

roryabraham Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 4, 2025

Uh oh!

OSBotify commented Dec 5, 2025

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

chrispader commented Sep 28, 2025 •

edited

Loading

chrispader commented Dec 2, 2025 •

edited

Loading

parasharrajat commented Dec 2, 2025 •

edited

Loading