Skip to content

Bulk move expenses to a new report#71778

Merged
cristipaval merged 12 commits intoExpensify:mainfrom
callstack-internal:feat/68995-bulk-move-expenses-v2
Oct 3, 2025
Merged

Bulk move expenses to a new report#71778
cristipaval merged 12 commits intoExpensify:mainfrom
callstack-internal:feat/68995-bulk-move-expenses-v2

Conversation

@koko57
Copy link
Contributor

@koko57 koko57 commented Oct 2, 2025

Explanation of Change

Fixed Issues

$ #68995
PROPOSAL:

Tests

If the user has no group workspace at all --> Don't show the Move Expenses option

Prerequisites: user has no workspace, has selfDM

  1. Create a few tracked expenses in the selfDM
  2. Go to reports page
  3. Select the unreported expenses
  4. Click "X selected" button
  5. Verify that you do not see Move Expenses option in the popover menu

If the user has a default group workspace --> Show the option and create the report in the active policy

Prerequisites: user has a default workspace, has selfDM

  1. Create a few tracked expenses in the selfDM
  2. Go to reports page
  3. Select the unreported expenses (you might have to clear the filters and/or select Status: Unreported)
  4. Click "X selected" button
  5. Verify that you do see Move Expenses option in the popover menu
  6. Click Move Expenses
  7. Verify that you see Create Report button with the active workspace name as the secondary text
  8. Click Create Report
  9. Verify that the new report is created, you're redirected to the new report and the expenses are moved there

NOTE: Create Report button should also appear when moving reported expenses and should work the same way as for unreported expenses

-> Repeat each step from the test steps above but this time select reported expenses

If the user doesn't have an active workspace but has only one group workspace --> Show the option and create the report in that workspace

Prerequisites: user has only one workspace (is the owner or invitee), has selfDM

  1. Create a few tracked expenses in the selfDM
  2. Go to reports page
  3. Select the unreported expenses (you might have to clear the filters and/or select Status: Unreported)
  4. Click "X selected" button
  5. Verify that you do see Move Expenses option in the popover menu
  6. Click Move Expenses
  7. Verify that you see Create Report button with the workspace name as the secondary text
  8. Click Create Report
  9. Verify that the new report is created, you're redirected to the new report and the expenses are moved there

NOTE: Create Report button should also appear when moving reported expenses and should work the same way as for unreported expenses

-> Repeat each step from the test steps above but this time select reported expenses

If the user has no active workspace but has multiple group policies --> Show the option and ask the user to pick the workspace where the new report should be created

Prerequisites: user has several workspaces - NONE OF THEM DEFAULT (delete or leave the default policy), has selfDM

  1. Create a few tracked expenses in the selfDM
  2. Go to reports page
  3. Select the unreported expenses (you might have to clear the filters and/or select Status: Unreported)
  4. Click "X selected" button
  5. Verify that you do see Move Expenses option in the popover menu
  6. Click Move Expenses
  7. Verify that you see Create Report button with NO secondary text
  8. Click Create Report
  9. Verify that you're redirected to the workspace selector page
  10. Select a workspace
  11. Verify that the new report is created in the selected workspace, you're redirected to the new report and the expenses are moved there

NOTE: Create Report button should also appear when moving reported expenses and should work the same way as for unreported expenses

-> Repeat each step from the test steps above but this time select reported expenses

  • Verify that no errors appear in the JS console

Offline tests

n/a

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as tests

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-10-02.at.16.16.28.mp4
Screen.Recording.2025-10-02.at.16.15.08.mp4
Screen.Recording.2025-10-02.at.16.13.18.mp4
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-10-02.at.15.51.51.mp4
Screen.Recording.2025-10-02.at.15.50.21.mp4
Screen.Recording.2025-10-02.at.15.44.40.mp4
MacOS: Desktop

@koko57 koko57 requested a review from a team as a code owner October 2, 2025 14:18
@melvin-bot melvin-bot bot requested a review from parasharrajat October 2, 2025 14:18
@melvin-bot melvin-bot bot removed the request for review from a team October 2, 2025 14:18
@melvin-bot
Copy link

melvin-bot bot commented Oct 2, 2025

@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@cristipaval cristipaval changed the title Bulk move expenses + create report Bulk move expenses to a new report Oct 2, 2025
});

const session = useSession();
const userPolicies = Object.values(allPolicies ?? {}).filter((policy) => isPolicyMemberWithoutPendingDelete(session?.email, policy) && policy?.type !== CONST.POLICY.TYPE.PERSONAL);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const userPolicies = Object.values(allPolicies ?? {}).filter((policy) => isPolicyMemberWithoutPendingDelete(session?.email, policy) && policy?.type !== CONST.POLICY.TYPE.PERSONAL);
const userPolicies = Object.values(allPolicies ?? {}).filter((policy) => isPolicyMemberWithoutPendingDelete(session?.email, policy) && isPaidGroupPolicy(policy));

Even though it is same but this one is more declarative.

return {policyForMovingExpensesID: undefined, policyForMovingExpenses: undefined, shouldSelectPolicy: true};
}

return {policyForMovingExpensesID: undefined, policyForMovingExpenses: undefined, shouldSelectPolicy: false};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return {policyForMovingExpensesID: undefined, policyForMovingExpenses: undefined, shouldSelectPolicy: false};
return {policyForMovingExpenses: undefined, shouldSelectPolicy: false};

Seems unnecessary when we are exporting policyForMovingExpenses

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in some cases we will need the id only so why not export it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can get it from policyForMovingExpenses variable, so I would keep one source

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the optional chaining everywhere when we really don't need to use the whole object

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it won't be used extensively, I will remove it

Comment on lines +4296 to +4297
// temporary check for Search Page only
isSearchPageOption?: boolean,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add more explanation about this temporary check? Will we remove it in future? if so, please add todo for cleanup.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure yet if we will remove it - if we will have the upgrade path from the Search Page it will no longer be necessary. But it of course will depend on the Expensify team decision

Comment on lines +4382 to +4384
const isUserWorkspaceMember = Object.values(allPolicies ?? {}).find(
(policyItem) => policyItem?.employeeList?.[currentUserEmail ?? ''] && policyItem?.type !== CONST.POLICY.TYPE.PERSONAL,
);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should use something similar to getActivePolicies here but you can check other methods in policyutils or create more suitable one.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it will probably be changed later, so I don't want to create an util now that won't be used later

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we need to check for non-pending deletion policy here too, so we should use either getActivePolicies or add code here.


const [policies, fetchStatus] = useOnyx(ONYXKEYS.COLLECTION.POLICY, {canBeMissing: true});
const currentUserPersonalDetails = useCurrentUserPersonalDetails();
const isASAPSubmitBetaEnabled = Permissions.isBetaEnabled(CONST.BETAS.ASAP_SUBMIT, allBetas);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use usePermissions hook.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes of this file is not used in this PR/change, so we should not add them here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how they are not used? without this changes you wouldn't see the create report button when moving expenses from Search page

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my bad, I didn't see that it is used in.

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

@parasharrajat comments addressed

@koko57 koko57 requested a review from parasharrajat October 3, 2025 09:15
@parasharrajat
Copy link
Member

Thanks. Checking...

// Unreported transaction from OldDot can have the reportID as an empty string
const isUnreportedExpense = !transaction?.reportID || transaction?.reportID === CONST.REPORT.UNREPORTED_REPORT_ID;

const isUserWorkspaceMember = getActivePolicies(allPolicies ?? {}, currentUserEmail).length;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not check for paid policies so we need to check for that too.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@parasharrajat addressed!

@parasharrajat
Copy link
Member

I see that this PR is enabling create report option for expense reports as well. is this expected/ @koko57

03.10.2025_15.38.40_REC.mp4

@parasharrajat
Copy link
Member

parasharrajat commented Oct 3, 2025

BUG: In test 2 and 3, user does not move to created report after expense are moved. it stays on reports page.

on staging, user remain on reports page for both expenses reports. There is no create report button there.

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

I see that this PR is enabling create report option for expense reports as well. is this expected/ @koko57

03.10.2025_15.38.40_REC.mp4

I will check it

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

I think it would be hard to differentiate - I would need to check if all the selected transactions and this is what I have
Screenshot 2025-10-03 at 12 19 02

So I guess I would need much coplex logix to check if only unreported transactions are selected

@cristipaval can we ship with this button on the Search Page only? We're eventually adding the support for reported expenses in the next PR

@cristipaval
Copy link
Contributor

I see that this PR is enabling create report option for expense reports as well. is this expected/ @koko57

Thanks for double-checking the expected behavior, @parasharrajat!

Yes, as long as it behaves correctly, let it be enabled for reported expenses as well. So we always want the Create Report as an option for the Move expenses action.

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

@parasharrajat are you sure that for test 2 and 3? it only navigates to the report when selecting the workspace from the selector, I will block that

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

user should now stay on Reports Page after all the actions

@parasharrajat
Copy link
Member

parasharrajat commented Oct 3, 2025

So I guess I would need much coplex logix to check if only unreported transactions are selected

I think we can check for reports sub tab as reports sub tab does not show unreported expenses.. If that is selected do you show create Report in Move expense. @koko57

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

So I guess I would need much coplex logix to check if only unreported transactions are selected

I think we can check for reports sub tab as reports sub tab does not show unreported expenses.. If that is selected do you show create Report in Move expense. @koko57

@parasharrajat not sure, but anyway @cristipaval said that it is expected - we want the button for both reported and unreported

@parasharrajat
Copy link
Member

parasharrajat commented Oct 3, 2025

Sure, I will check that too. Can you please add that flow in your test steps as well?

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

@parasharrajat done! ready for the review

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

@parasharrajat such a note will do?

NOTE: Create Report button should also appear when moving reported expenses and should work the same way as for unreported expenses

-> Repeat each step from the test steps above but this time select reported expenses

I don't want to repeat all the steps 😅

@parasharrajat
Copy link
Member

parasharrajat commented Oct 3, 2025

May be just add notes under all cases that should work with reported one. You can say to repeat steps in the note.

@parasharrajat
Copy link
Member

Bug: The Report expenses does not show create report button on Move expenses.

  1. Open any report which have 2 or more expenses.
  2. Select expenses > more > move expeneses.

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

Bug: The Report expenses does not show create report button on Move expenses.

  1. Open any report which have 2 or more expenses.
  2. Select expenses > more > move expeneses.

@parasharrajat thanks for pointing this out - I guess this is because we're enabling moving expenses from the search page - the option you mention will come in the second PR

if you start from the expense report you're redirected to a different page

@parasharrajat
Copy link
Member

parasharrajat commented Oct 3, 2025

When I open a report from reports page too, I don't this option.

the option you mention will come in the second PR

Ok, thanks for confirming. Should we add a note on the test steps so that QA does not report it as a bug?

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

When I open a report from reports page too, I don't this option.

the option you mention will come in the second PR

Ok, thanks for confirming.

can you show me a recording? with a visible url? or give me exact test steps?

@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

Screenshot 2025-10-03 at 17 46 43

if you have such url we don't show the button yet, only for /search/move-transactions

@parasharrajat
Copy link
Member

Here is the vid.

Steps;

  1. Go to reports page,
  2. Select reports sub tab.
  3. click on a report to open it.
  4. Select and move expenses.
03.10.2025_21.46.32_REC.mp4

@parasharrajat
Copy link
Member

parasharrajat commented Oct 3, 2025

Screenshots

🔲 iOS / native

03.10.2025_21.32.10_REC.mp4

🔲 iOS / Safari

03.10.2025_21.51.19_REC.mp4

🔲 MacOS / Desktop

03.10.2025_21.42.15_REC.mp4

🔲 MacOS / Chrome

03.10.2025_20.59.58_REC.mp4

🔲 Android / Chrome

03.10.2025_21.22.18_REC.mp4

🔲 Android / native

03.10.2025_21.20.06_REC.mp4
03.10.2025_21.15.41_REC.mp4

Copy link
Member

@parasharrajat parasharrajat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified tests pass on all platforms & I tested again on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g. myBool && <MyComponent />.
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the Waiting for Copy label for a copy review on the original GH to get the correct copy.
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

🎀 👀 🎀 C+ reviewed

@melvin-bot melvin-bot bot requested a review from cristipaval October 3, 2025 16:19
@koko57
Copy link
Contributor Author

koko57 commented Oct 3, 2025

Here is the vid.

Steps;

  1. Go to reports page,
  2. Select reports sub tab.
  3. click on a report to open it.
  4. Select and move expenses.

03.10.2025_21.46.32_REC.mp4

yeah, exactly - the url is edit/submit/report later - it's handled in the second PR
thanks for checking!

but actually funny that it navigates there not to the search/move-expenses

@cristipaval cristipaval merged commit 21d01a5 into Expensify:main Oct 3, 2025
22 checks passed
@OSBotify
Copy link
Contributor

OSBotify commented Oct 3, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 6, 2025

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.24-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 7, 2025

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.26-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 8, 2025

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.26-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants