Create report from reported expense#71808
Conversation
koko57
force-pushed
the
feat/71776-create-report-from-reported-expense
branch
from
3250006 to
6f5af51
Compare
melvin-bot
bot
requested review from
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
|
@koko57 Please merge main. |
|
@parasharrajat I merged main |
| const reportNextStep = allReportNextSteps?.[`${ONYXKEYS.COLLECTION.NEXT_STEP}${optimisticReportID}`]; | ||
| changeTransactionsReport( | ||
| selectedTransactionsKeys, | ||
| selectedTransactionsKeys.length ? selectedTransactionsKeys : selectedTransactionIDs, |
There was a problem hiding this comment.
we either use the keys or IDs. We either save the whole selectedTransactions objects or IDs only in the search context
|
@koko57 Where will we handle this bug #71778 (comment)? I am asking because you mentioned the second PR. Let's keep track of it too. |
@parasharrajat it still doesn't work? |
|
yes, it does not work. |
|
|
||
| const createReportOption = useMemo(() => { | ||
| if (!createReport || isUnreported === false) { | ||
| if (!createReport || isUnreported) { |
There was a problem hiding this comment.
| if (!createReport || isUnreported) { | |
| if (!createReport || !isUnreported) { |
Shouldn't this be like that?
There was a problem hiding this comment.
we're hoding it for now for unreported
This comment was marked as outdated.
This comment was marked as outdated.
|
@parasharrajat the unreported expenses are handled in a separate PR - the one I mentioned on Slack |
|
BUG: After create report and going back, I can still see ther report page. 06.10.2025_18.19.09_REC.mp4 |
what is expected? or you mean that the RHP shouldn't be there? |
|
BUG: After create report and going back, I can still see ther report page. 06.10.2025_18.19.09_REC.mp4
yes. RHP should not be shown. It should be the reports page, I think.But let's confirm on slack group. |
|
BUG: After create report , user is taken to search view. Steps:
Expected: user should remain in LHN/report view. |
after creating the report, right? the workspace selector is not shown? |
|
In both above mentioned cases @koko57 |
|
@parasharrajat should be fixed now |
|
Checking... |
|
@koko57 Found one issue with move expenses.
Expected: Move expenses button should be shown for expense which are Only expense in the expense report. |
|
@parasharrajat can you repro this on staging? If not I don't think it's in the scope of this PR. As we discussed earlier, it happens sometimes - I haven't changed anything in the logic for showing the Move Expense button |
|
OK, sure. I can reproduce this on staging. |
|
Bug: After login in, create report does not take you workspace selection if user has multiple workspaces instead create report on a workspace. |
| const userPolicies = Object.values(allPolicies ?? {}).filter( | ||
| (policy) => | ||
| checkForPendingDelete(login, policy) && | ||
| (isUserPolicyAdmin(policy, login) || isPolicyUser(policy, login)) && |
There was a problem hiding this comment.
This is not correct. User can have more roles. what if check for any role
There was a problem hiding this comment.
what other roles to check? We're not including the auditor role
Screenshots🔲 iOS / native08.10.2025_15.24.57_REC.mp4🔲 iOS / Safari08.10.2025_15.45.17_REC.mp4🔲 MacOS / Desktop08.10.2025_15.58.57_REC.mp4🔲 MacOS / Chrome08.10.2025_14.35.27_REC.mp4🔲 Android / Chrome08.10.2025_17.39.35_REC.mp4🔲 Android / native |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
Appreciate the patience here @koko57. It has been a long review. |
|
@parasharrajat the auditor role added |
| } | ||
|
|
||
| function isPolicyMemberByRole(login: string, policy: OnyxEntry<Policy>) { | ||
| return isPolicyAdmin(policy, login) || isPolicyUser(policy, login) || getPolicyRole(policy, login) === CONST.POLICY.ROLE.AUDITOR; |
There was a problem hiding this comment.
We already have isPolicyAuditor in PolicyUtils
There was a problem hiding this comment.
We should also update isPolicyAuditor method to use getPolicyRole as is using similiar logic inside.
There was a problem hiding this comment.
@parasharrajat yeaah, but it uses employees list 😅 so another one I cannot use. I don't want to change the util either, because getPolicyRole returns policy?.role when it exists and I guess this util is used to check other members for being auditor
There was a problem hiding this comment.
Here is reads policy first
(policy?.role ?? (currentUserLogin && policy?.employeeList?.[currentUserLogin]?.role)) === CONST.POLICY.ROLE.AUDITOR;
but it is fine.
Likewise! Thank you for your patience and a ton of work! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.28-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀
|
4 participants
Explanation of Change
Fixed Issues
$ #71776
PROPOSAL:
Tests
Prerequisites: Have a user with 3 workspaces: A, B C. A is the default workspace
Default Workspace
Several workspaces, no default workspace
Only one workspace, not a default one
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-10-03.at.12.12.18.mp4
Screen.Recording.2025-10-03.at.12.11.41.mp4
Screen.Recording.2025-10-03.at.12.08.01.mp4
MacOS: Desktop