[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" #72106

lakchote · 2025-10-08T14:59:24Z

Reverts #71896

melvin-bot · 2025-10-08T14:59:30Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

github-actions · 2025-10-08T15:01:07Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

codecov · 2025-10-08T15:12:14Z

Codecov Report

❌ Patch coverage is 37.87879% with 41 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/ContextMenuItem.tsx	0.00%	12 Missing ⚠️
src/components/DatePicker/index.tsx	0.00%	7 Missing ⚠️
src/components/MagicCodeInput.tsx	46.15%	7 Missing ⚠️
src/components/PercentageForm.tsx	0.00%	3 Missing ⚠️
...rc/components/ActionSheetAwareScrollView/index.tsx	0.00%	2 Missing ⚠️
src/components/AddressSearch/index.tsx	85.71%	0 Missing and 1 partial ⚠️
src/components/AmountPicker/index.tsx	0.00%	1 Missing ⚠️
src/components/AmountWithoutCurrencyInput.tsx	0.00%	1 Missing ⚠️
src/components/CurrencySelector.tsx	75.00%	0 Missing and 1 partial ⚠️
src/components/FormScrollView.tsx	0.00%	1 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

mountiny

Tested on the adhoc and it works

…rs-related-to-forwardRef-batch7

github-actions · 2025-10-08T16:23:59Z

🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here.

MonilBhavsar

Tested and it resolves issue

github-actions · 2025-10-08T16:40:26Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72106.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72106/index.html
The build for Android was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Desktop was skipped	The build for Web was skipped

👀 View the workflow run that generated this build 👀

mountiny · 2025-10-08T16:45:46Z

src/components/AmountWithoutCurrencyInput.tsx

 AmountWithoutCurrencyInput.displayName = 'AmountWithoutCurrencyInput';

-export default AmountWithoutCurrencyInput;
+export default React.forwardRef(AmountWithoutCurrencyInput);


I think we need to go back to this:

function AmountWithoutCurrencyInput( {value: amount, shouldAllowNegative = false, inputID, name, defaultValue, accessibilityLabel, role, label, onInputChange, ...rest}: AmountFormProps, ref: ForwardedRef<BaseTextInputRef>, ) {

But add the new props that has been added

mountiny

The latest conflict resolution looks good

github-actions · 2025-10-08T16:59:22Z

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-08T17:45:08Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72106.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72106/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72106/index.html

Desktop 💻	Web 🕸️
❌ FAILED ❌	https://72106.pr-testing.expensify.com
The QR code can't be generated, because the Desktop build failed

👀 View the workflow run that generated this build 👀

mountiny · 2025-10-08T17:51:26Z

Works!

melvin-bot · 2025-10-08T17:56:59Z

@lakchote looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

lakchote · 2025-10-08T17:57:14Z

Not emergency, straight revert

melvin-bot · 2025-10-08T17:57:21Z

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

OSBotify · 2025-10-08T18:09:00Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

…Fix-console-errors-related-to-forwardRef-batch7 [CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" (cherry picked from commit d005353) (cherry-picked to staging by mountiny)

…353794631-1 🍒 Cherry pick PR #72106 to staging 🍒

OSBotify · 2025-10-08T19:04:36Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.27-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…353794631-1 🍒 Cherry pick PR #72106 to staging 🍒 (cherry picked from commit eea7275)

OSBotify · 2025-10-08T21:37:01Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-08T21:58:09Z

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-10T10:52:19Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Revert "Jakubkalinski0/fix console errors related to forward ref batch7"

25c2f34

melvin-bot bot assigned lakchote Oct 8, 2025

This comment has been minimized.

Sign in to view

mountiny previously approved these changes Oct 8, 2025

View reviewed changes

Merge branch 'main' into revert-71896-jakubkalinski0/Fix-console-erro…

6e97dbf

…rs-related-to-forwardRef-batch7

lakchote dismissed mountiny’s stale review via 6e97dbf October 8, 2025 16:17

remove unused props

bb54d90

MonilBhavsar previously approved these changes Oct 8, 2025

View reviewed changes

mountiny reviewed Oct 8, 2025

View reviewed changes

fix

11c36fd

lakchote dismissed MonilBhavsar’s stale review via 11c36fd October 8, 2025 16:55

mountiny previously approved these changes Oct 8, 2025

View reviewed changes

fix prettier

a84811e

lakchote dismissed mountiny’s stale review via a84811e October 8, 2025 16:58

mountiny approved these changes Oct 8, 2025

View reviewed changes

mountiny changed the title ~~Revert "Jakubkalinski0/fix console errors related to forward ref batch7"~~ [CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" Oct 8, 2025

lakchote marked this pull request as ready for review October 8, 2025 17:56

lakchote requested a review from a team as a code owner October 8, 2025 17:56

lakchote merged commit d005353 into main Oct 8, 2025
22 of 26 checks passed

lakchote deleted the revert-71896-jakubkalinski0/Fix-console-errors-related-to-forwardRef-batch7 branch October 8, 2025 17:56

melvin-bot bot added the Emergency label Oct 8, 2025

lakchote removed the Emergency label Oct 8, 2025

melvin-bot bot requested review from Beamanator and removed request for a team October 8, 2025 17:57

os-botify bot mentioned this pull request Oct 8, 2025

🍒 Cherry pick PR #72106 to staging 🍒 #72124

Merged

52 tasks

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 8, 2025

lakchote added a commit that referenced this pull request Oct 8, 2025

Merge pull request #72124 from Expensify/cherry-pick-staging-72106-18…

eea7275

…353794631-1 🍒 Cherry pick PR #72106 to staging 🍒

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72057

Closed

62 tasks

lakchote added a commit that referenced this pull request Oct 8, 2025

Merge pull request #72124 from Expensify/cherry-pick-staging-72106-18…

823e9d6

…353794631-1 🍒 Cherry pick PR #72106 to staging 🍒 (cherry picked from commit eea7275)

jakubkalinski0 mentioned this pull request Nov 6, 2025

Jakubkalinski0/fix console errors related to forward ref batch7 - PR after second revert #73422

Merged

54 tasks

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" #72106

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" #72106

Uh oh!

Conversation

lakchote commented Oct 8, 2025

Uh oh!

melvin-bot bot commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

codecov bot commented Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment has been minimized.

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

MonilBhavsar left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

mountiny Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

github-actions bot commented Oct 8, 2025

Uh oh!

mountiny commented Oct 8, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Oct 8, 2025

Uh oh!

lakchote commented Oct 8, 2025

Uh oh!

melvin-bot bot commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Oct 8, 2025 •

edited

Loading