Jakubkalinski0/fix console errors related to forward ref batch7 #71896

jakubkalinski0 · 2025-10-06T13:34:09Z

@mountiny
Raised once again after it was reverted.
Original PR -> #70878
Revert -> #71669

Explanation of Change

The whole issue comes from forwardRef being deprecated in the near future of react thus we will no longer be able to access the passed ref by element.ref as forwardRef is needed for passing ref as a separate attribute. Now in order to pass there reference it has to be passed as one of the props so we can access it directly or like that -> element.props.ref.

In order to adjust the codebase to new react recommendations in every file that was using forwardRef the ref had to be moved to the props instead of being a separate attribute and forwardRef had to be completely removed.

Some files had to be changed due to the changes made in other components. In response to the number of files that needed adjusting the changes are made in batches with this one being the seventh one.

This batch is pretty scattered all over the place just as the previous one due to there being no more clear flows that can provide us with meaningful number of files that require the change, thus all PR's going forward will probably be this scattered.

Modified files are grouped below by the components they are related to. In order to make testing easier there are also screenshots of places in app where you can find those components.

ActionSheetAwareScrollView

This one we test indirectly as it is used by other components

src/components/ActionSheetAwareScrollView/index.ios.tsx
src/components/ActionSheetAwareScrollView/index.tsx
src/components/ActionSheetAwareScrollView/types.ts

AddressSearch

This one has as different display name

src/components/AddressSearch/index.tsx
src/components/AddressSearch/types.ts

AmountPicker

src/components/AmountPicker/index.tsx
src/components/AmountPicker/types.ts

AmountWithoutCurrencyInput

src/components/AmountWithoutCurrencyInput.tsx

AttachmentCarousel/Pager

This one is only on native:

src/components/Attachments/AttachmentCarousel/Pager/index.tsx

CheckboxWithLabel

src/components/CheckboxWithLabel.tsx

ContextMenuItem

src/components/ContextMenuItem.tsx

CountrySelector

src/components/CountrySelector.tsx

CurrencySelector

src/components/CurrencySelector.tsx

DatePicker

src/components/DatePicker/index.tsx
src/components/DatePicker/types.ts

FormScrollView

src/components/FormScrollView.tsx

HighlightableMenuItem

src/components/HighlightableMenuItem.tsx

InteractiveStep

src/components/InteractiveStepSubHeader.tsx

src/components/InteractiveStepWrapper.tsx

MagicCodeInput

src/components/MagicCodeInput.tsx

PercentageForm

src/components/PercentageForm.tsx

RadioButtons

src/components/RadioButtons.tsx

ShareTabParticipantsSelector

This one is only on native:

src/components/Share/ShareTabParticipantsSelector.tsx

SingleChoiceQuestion

src/components/SingleChoiceQuestion.tsx

StateSelector

src/components/StateSelector.tsx

TextLink

src/components/TextLink.tsx

TimeModalPicker

src/components/TimeModalPicker.tsx

withToggleVisibilityView

This one has a display name a little different than it's called, so don't get surprised

src/components/withToggleVisibilityView.tsx

withViewportOffsetTop

src/components/withViewportOffsetTop.tsx

Fixed Issues

$ #67033
PROPOSAL: N/A

Tests

Open Expensify without being logged in (now we will be testing MagicCodeInput and withToggleVisibilityView components)
Input your email to the BaseLoginForm - with that we test withToggleVisibilityView which is used by the BaseLoginForm
Verify that it works properly by pressing Continue
Input the magic code
Verify that MagicCodeInput works properly by pressing Sign in after inputing the code
Now go to Account -> Profile
Press Address in Private section (now we will be testing AddressSearch, CountrySelector and StateSelector components)
Verify if AddressSearch works properly (i.e. you can look up any address)
Change the country using CountrySelector
Verify that changing the country works properly
Now change the country to United States
Change the state using StateSelector
Verify that changing the state works properly
Verify that adding the chosen address works properly, by pressing Save
Now press Date of birth in Private section (now we will be testing DatePicker component)
Choose any date from the calendar (you can play around with years and months)
Verify if DatePicker works by checking if the picked date shows up in the Date input on top
Verify if adding the chosen date works by pressing Save
Now go to Subscription
Press Add payment card (now we will be testing CurrencySelector component)
Verify that the CurrencySelector works correctly by pressing it and changing the currency
Now go to Security
Press Merge accounts (now we will be testing CheckboxWithLabel)
Verify that CheckboxWithLabel works correctly by pressing it (you can do it multiple times)
Now go to Wallet
Press Enable wallet (now we will be testing InteractiveStepSubHeader, InteractiveStepWrapper, RadioButtons and SingleChoiceQuestion components)
Fill out the forms using this info -> https://swmansion.slack.com/archives/C01GTK53T8Q/p1711049879962529 (this data is required as it has to be real in order for the validation to let you through to the targeted forms)
Verify that InteractiveStepWrapper works properly by filling out the bank info
Verify that InteractiveStepSubHeader works properly by checking if the step header 'checks' the first step and moves on to focus the second one after filling out the bank info
Now fill out the PersonalInfo section using information from the above slack discussion but it is for some reason crucial that you input the last name as Bobbeth otherwise you won't see IdologyQuestions which we need to test
Verify that RadioButtons and SingleChoiceQuestion components work properly by answering the questions (you can do that correctly or not or both ways to test it - testing it with only one of those is fine and completely enough)
Now go to Workspaces and choose any workspace that you are an owner of
Press More -> Share (now we will be testing if ContextMenuItem component works properly)
Verify that ContextMenuItem works properly by pressing the Copy URL and pasting it in the search bar of the web browser
Verify that HighlightableMenuItem works properly by going to any feature of the workspace - if you can navigate between the features of the workspace (for example Overview to More features) then it works
Go to More features and turn on Taxes, Rules and Per diem
Press Taxes (now we will be testing AmountPicker component)
Press +Add rate -> Value
Verify that AmountPicker works properly by pressing it and adding the value
Press Rules (now we will be testing PercentageForm component)
Turn on Auto-approve compliant reports
Verify that PercentageForm works properly by changing the value of Random report audit
Press Per diem (now we will be testing TextLink component)
Verify that TextLink works properly by pressing it and checking if the ExpensifyHelp site opens
Download one of the Per Diem Rate Templates
Import the downloaded spreadsheet
Press the + floating button in the left bottom corner (now we will be testing TimeModalPicker component)
Press Create expense -> Per diem and choose any per diem rate
Verify that TimeModalPicker works properly by changing Start time or End time of the per diem expense
Now go to Reports -> Filters
Press Amount (now we will be testing AmountWithoutCurrencyInput component)
Choose any one of Equal to, Greater than, Less than
Verify that AmountWithoutCurrencyInput works properly by changing the value of one of the above and checking if it filtered the results properly
Now go to any 1:1 chat (now we will be testing withViewportOffsetTop which is used to open some of the popovers properly -> in this case the EmojiPicker)
Verify that withViewportOffsetTop works properly by pressing the EmojiPicker and choosing some emoji - check if it's properly added to the message composer

This one needs to be done on staging
56. Go to URL https://staging.new.expensify.com/
57. Login with any account
58. Verify that FormScrollView works properly by opening the enable payments page http://staging.new.expensify.com/enable-payments - if it loads correctly and you are able to go further with the flow then it works

This ones need to be done on native
59. Go to the Photos/Gallery on the phone and share some image with Expensify
60. Verify that ShareTabParticipantsSelector works properly by sharing the image with other user/workspace
61. Now go to any 1:1 chat and add a few images in the chat
62. Press on the image so that the AttachmentCarousel opens up
63. Verify that the Pager works correctly by traversing through the attachments
64. Go to any 1:1 chat and add a few messages
65. Verify that ActionSheetAwareScrollView works properly by editing one of the messages

Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Steps from 59 to 65:

59to65.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Steps from 1 to 18:

1to18.mp4

Steps from 19 to 24:

19to24.mp4

Steps from 25 to 31:

25to31.mp4

Steps from 32 to 49:

32to49.mp4

Steps from 50 to 55:

50to55.mp4

This one has to be done on staging
Steps from 56 to 58:

56to58.mp4

MacOS: Desktop

melvin-bot · 2025-10-06T13:34:18Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

melvin-bot · 2025-10-06T13:39:36Z

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-10-06T13:44:57Z

Codecov Report

❌ Patch coverage is 37.87879% with 41 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/ContextMenuItem.tsx	0.00%	12 Missing ⚠️
src/components/DatePicker/index.tsx	0.00%	7 Missing ⚠️
src/components/MagicCodeInput.tsx	46.15%	7 Missing ⚠️
src/components/PercentageForm.tsx	0.00%	3 Missing ⚠️
src/components/AmountWithoutCurrencyInput.tsx	0.00%	2 Missing ⚠️
...rc/components/ActionSheetAwareScrollView/index.tsx	0.00%	1 Missing ⚠️
src/components/AddressSearch/index.tsx	85.71%	0 Missing and 1 partial ⚠️
src/components/AmountPicker/index.tsx	0.00%	1 Missing ⚠️
src/components/CurrencySelector.tsx	75.00%	0 Missing and 1 partial ⚠️
src/components/FormScrollView.tsx	0.00%	1 Missing ⚠️
... and 5 more

📢 Thoughts on this report? Let us know!

mountiny · 2025-10-06T20:16:57Z

@jakubkalinski0 seems like we already have conflicts. Can you please update the author checklist too to make that action pass? thanks!

mountiny · 2025-10-06T20:17:18Z

@c3024 could you give it a test as well (confirm the diff from the previous PR)

c3024 · 2025-10-07T07:31:03Z

src/components/ActionSheetAwareScrollView/index.ios.tsx

 import useActionSheetKeyboardSpacing from './useActionSheetKeyboardSpacing';

-const ActionSheetAwareScrollView = forwardRef<ScrollView, ActionSheetAwareScrollViewProps>(({style, children, ...props}, ref) => {
+function ActionSheetAwareScrollView({style, children, isInvertedScrollView, ref, ...props}: ActionSheetAwareScrollViewProps) {


isInvertedScrollView prop isn't used anywhere in the component. 🤔 Is it not required for iOS?

Good catch! Something must have slipped when i was resolving merge conflicts with newest main yesterday. I will look into it

Now everything is clear, those changes regarding isInvertedScrollView were reverted between the first PR of the batch 7 and this PR thus when I cherry-picked those commits I did it with those reverted changes in my code.

You can see the PR that was reverted here: #70250

I will remove those and if there is nothing more we are good to go

Thanks for the quick changes!

c3024 · 2025-10-07T07:35:51Z

src/components/ActionSheetAwareScrollView/types.ts

-type ActionSheetAwareScrollViewProps = PropsWithChildren<ScrollViewProps>;
+type ActionSheetAwareScrollViewAnimationProps = {
+    /** Whether the child ScrollView is inverted */
+    isInvertedScrollView?: boolean;


This change is not on main and this does not look related to the forwardRef migration?

Same as above, I will look into it

Same case as above, I wrote all the details in the conversation above

…-forwardRef-batch7

jakubkalinski0 · 2025-10-07T09:05:19Z

@c3024 @mountiny All taken care of for now

c3024 · 2025-10-07T10:22:39Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

c3024

LGTM!

mountiny

Thanks!

OSBotify · 2025-10-07T10:46:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-08T05:11:30Z

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.27-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-10-08T21:36:01Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.27-6 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jakubkalinski0 added 27 commits October 6, 2025 15:15

Removed forwardRef from ShareTabParticipantsSelector.tsx

a2fbcb5

Removed forwardRef from AmountWithoutCurrencyInput.tsx

5934652

CheckboxWithLabel.tsx

9956585

Removed forwardRef from ContextMenuItem.tsx

f7629e0

Removed forwardRef from Countryselector.tsx

7cb2ca2

Removed forwardRef from CurrencySelector.tsx

f7e69f2

Removed forwardRef from FormScrollView.tsx

1ababcc

Removed forwardRef from HighlightableMenuItem.tsx

a8dc3f4

Removed forwardRef from InteractiveStepSubHeader.tsx

c676a7f

Removed forwardRef from InteractiveStepWrapper.tsx

741c899

Removed forwardRef from MagicCodeInput.tsx

6922f91

Removed forwardRef from PercentageForm.tsx

131f32e

Removed forwardRef from RadioButtons.tsx

b640d21

Small code cleanup

81998c8

Removed forwardRef from SingleChoiceQuestion.tsx

c39a8a6

Removed forwardRef from StateSelector.tsx

00bb09b

Removed forwardRef from TextLink.tsx

bfc8eb2

Removed forwardRef from TimeModalPicker.tsx

6e93743

Removed forwardRef from withToggleVisibilityView.tsx

f933611

Removed forwardRef from withViewportOffsetTop.tsx

7756973

Removed forwardRef from ActionSheetAwareScrollView component

8cd1d96

Removed forwardRef from AddressSearch component

ce77504

Removed forwardRef from AmountPicker component

5e9cef1

Removed forwardRef from AttachmentCarousel/Pager/index.tsx

0a5b189

Removed forwardRef from DatePicker component

cbba10d

Fixed failing spellcheck

7b313ce

Prettier run

4b0d342

melvin-bot bot assigned jakubkalinski0 Oct 6, 2025

jakubkalinski0 marked this pull request as ready for review October 6, 2025 13:39

jakubkalinski0 requested a review from a team as a code owner October 6, 2025 13:39

melvin-bot bot requested review from c3024 and removed request for a team October 6, 2025 13:39

c3024 suggested changes Oct 7, 2025

View reviewed changes

jakubkalinski0 added 3 commits October 7, 2025 10:41

Merge branch 'main' into jakubkalinski0/Fix-console-errors-related-to…

7c1fbb3

…-forwardRef-batch7

Prettier run

35b52b4

Removed unnecessary prop

596eaff

c3024 approved these changes Oct 7, 2025

View reviewed changes

melvin-bot bot requested a review from mountiny October 7, 2025 10:22

mountiny approved these changes Oct 7, 2025

View reviewed changes

mountiny merged commit d9e7480 into Expensify:main Oct 7, 2025
22 of 23 checks passed

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72057

Closed

62 tasks

This was referenced Oct 8, 2025

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" #72106

Merged

Attachment - Infinite loading time when clicking the attachment #72092

Closed

melvin-bot bot mentioned this pull request Oct 8, 2025

[Due for payment 2026-02-03] [$1000] Fix console errors post React 19 upgrade #67033

Open

Jakubkalinski0/fix console errors related to forward ref batch7 #71896

Jakubkalinski0/fix console errors related to forward ref batch7 #71896

Uh oh!

Conversation

jakubkalinski0 commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 6, 2025

Uh oh!

melvin-bot bot commented Oct 6, 2025

Uh oh!

codecov bot commented Oct 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mountiny commented Oct 6, 2025

Uh oh!

mountiny commented Oct 6, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jakubkalinski0 commented Oct 7, 2025

Uh oh!

c3024 commented Oct 7, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

c3024 left a comment

Choose a reason for hiding this comment

Uh oh!

mountiny left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 7, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jakubkalinski0 commented Oct 6, 2025 •

edited

Loading

codecov bot commented Oct 6, 2025 •

edited

Loading