Skip to content

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" #71669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Valforte merged 1 commit into from
Oct 1, 2025
Merged

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7" #71669

Valforte merged 1 commit into from
Oct 1, 2025

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny commented Oct 1, 2025

Reverts #70878

To fix #71652

@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2025

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 1, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #71669.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://71669.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link

codecov bot commented Oct 1, 2025

Codecov Report

❌ Patch coverage is 36.50794% with 40 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/ContextMenuItem.tsx 0.00% 12 Missing ⚠️
src/components/DatePicker/index.tsx 0.00% 7 Missing ⚠️
src/components/MagicCodeInput.tsx 46.15% 7 Missing ⚠️
src/components/PercentageForm.tsx 0.00% 3 Missing ⚠️
...rc/components/ActionSheetAwareScrollView/index.tsx 0.00% 2 Missing ⚠️
src/components/AddressSearch/index.tsx 85.71% 0 Missing and 1 partial ⚠️
src/components/AmountPicker/index.tsx 0.00% 1 Missing ⚠️
src/components/AmountWithoutCurrencyInput.tsx 0.00% 1 Missing ⚠️
src/components/FormScrollView.tsx 0.00% 1 Missing ⚠️
src/components/HighlightableMenuItem.tsx 0.00% 1 Missing ⚠️
... and 4 more

📢 Thoughts on this report? Let us know!

@mountiny
Copy link
Contributor Author

mountiny commented Oct 1, 2025

Screen.Recording.2025-10-01.at.14.20.28.mov

Works!

@mountiny mountiny marked this pull request as ready for review October 1, 2025 12:22
@mountiny mountiny requested a review from a team as a code owner October 1, 2025 12:22
@melvin-bot melvin-bot bot requested review from madmax330 and removed request for a team October 1, 2025 12:23
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2025

@madmax330 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@Valforte Valforte merged commit ae62fb8 into main Oct 1, 2025
22 of 25 checks passed
@Valforte Valforte deleted the revert-70878-jakubkalinski0/Fix-console-errors-related-to-forwardRef-batch7 branch October 1, 2025 12:39
@melvin-bot
Copy link

melvin-bot bot commented Oct 1, 2025

@Valforte looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Oct 1, 2025
@Valforte
Copy link
Contributor

Valforte commented Oct 1, 2025

Not emergency, straight revert

@mountiny mountiny removed the Emergency label Oct 1, 2025
OSBotify pushed a commit that referenced this pull request Oct 1, 2025
@Valforte @OSBotify
Merge pull request #71669 from Expensify/revert-70878-jakubkalinski0/…
4b4f25b 
…Fix-console-errors-related-to-forwardRef-batch7

[CP Staging] Revert "Jakubkalinski0/fix console errors related to forward ref batch7"

(cherry picked from commit ae62fb8)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 1, 2025
@OSBotify OSBotify mentioned this pull request Oct 1, 2025
Closed
72 tasks
@OSBotify
Copy link
Contributor

OSBotify commented Oct 1, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.21-2 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@Expensify/applauseleads please QA this PR and check it off on the deploy checklist if it passes.

@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2025

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform result
🖥 desktop 🖥 failure ❌
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2025

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 2, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.22-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Oct 3, 2025

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.22-6 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@jakubkalinski0 jakubkalinski0 mentioned this pull request Oct 6, 2025
Merged
54 tasks
@jakubkalinski0 jakubkalinski0 mentioned this pull request Nov 6, 2025
Merged
54 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Valforte Valforte Valforte approved these changes

@madmax330 madmax330 Awaiting requested review from madmax330

Assignees

@mountiny mountiny

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[$250] Android mWeb - Account setting - Unable to save private section informations

4 participants

@mountiny @Valforte @OSBotify