Jakubkalinski0/fix console errors related to forward ref batch7

[jakubkalinski0]

Explanation of Change

The whole issue comes from forwardRef being deprecated in the near future of react thus we will no longer be able to access the passed ref by element.ref as forwardRef is needed for passing ref as a separate attribute. Now in order to pass there reference it has to be passed as one of the props so we can access it directly or like that -> element.props.ref.

In order to adjust the codebase to new react recommendations in every file that was using forwardRef the ref had to be moved to the props instead of being a separate attribute and forwardRef had to be completely removed.

Some files had to be changed due to the changes made in other components. In response to the number of files that needed adjusting the changes are made in batches with this one being the seventh one.

This batch is pretty scattered all over the place just as the previous one due to there being no more clear flows that can provide us with meaningful number of files that require the change, thus all PR's going forward will probably be this scattered.

Modified files are grouped below by the components they are related to. In order to make testing easier there are also screenshots of places in app where you can find those components.

ActionSheetAwareScrollView

This one we test indirectly as it is used by other components

1. src/components/ActionSheetAwareScrollView/index.ios.tsx
2. src/components/ActionSheetAwareScrollView/index.tsx
3. src/components/ActionSheetAwareScrollView/types.ts

AddressSearch

This one has as different display name

4. src/components/AddressSearch/index.tsx
5. src/components/AddressSearch/types.ts

AmountPicker

6. src/components/AmountPicker/index.tsx
7. src/components/AmountPicker/types.ts

AmountWithoutCurrencyInput

8. src/components/AmountWithoutCurrencyInput.tsx

AttachmentCarousel/Pager

This one is only on native:

9. src/components/Attachments/AttachmentCarousel/Pager/index.tsx

CheckboxWithLabel

10. src/components/CheckboxWithLabel.tsx

ContextMenuItem

11. src/components/ContextMenuItem.tsx

CountrySelector

12. src/components/CountrySelector.tsx

CurrencySelector

13. src/components/CurrencySelector.tsx

DatePicker

14. src/components/DatePicker/index.tsx
15. src/components/DatePicker/types.ts

FormScrollView

16. src/components/FormScrollView.tsx

HighlightableMenuItem

17. src/components/HighlightableMenuItem.tsx

InteractiveStep

18. src/components/InteractiveStepSubHeader.tsx

19. src/components/InteractiveStepWrapper.tsx

MagicCodeInput

20. src/components/MagicCodeInput.tsx

PercentageForm

21. src/components/PercentageForm.tsx

RadioButtons

22. src/components/RadioButtons.tsx

ShareTabParticipantsSelector

This one is only on native:

23. src/components/Share/ShareTabParticipantsSelector.tsx

SingleChoiceQuestion

24. src/components/SingleChoiceQuestion.tsx

StateSelector

25. src/components/StateSelector.tsx

TextLink

26. src/components/TextLink.tsx

TimeModalPicker

27. src/components/TimeModalPicker.tsx

withToggleVisibilityView

This one has a display name a little different than it's called, so don't get surprised

28. src/components/withToggleVisibilityView.tsx

withViewportOffsetTop

29. src/components/withViewportOffsetTop.tsx

Fixed Issues

$ #67033
PROPOSAL: N/A

Tests

1. Open Expensify without being logged in (now we will be testing MagicCodeInput and withToggleVisibilityView components)
2. Input your email to the BaseLoginForm - with that we test withToggleVisibilityView which is used by the BaseLoginForm
3. Verify that it works properly by pressing Continue
4. Input the magic code
5. Verify that MagicCodeInput works properly by pressing Sign in after inputing the code
6. Now go to Account -> Profile
7. Press Address in Private section (now we will be testing AddressSearch, CountrySelector and StateSelector components)
8. Verify if AddressSearch works properly (i.e. you can look up any address)
9. Change the country using CountrySelector
10. Verify that changing the country works properly
11. Now change the country to United States
12. Change the state using StateSelector
13. Verify that changing the state works properly
14. Verify that adding the chosen address works properly, by pressing Save
15. Now press Date of birth in Private section (now we will be testing DatePicker component)
16. Choose any date from the calendar (you can play around with years and months)
17. Verify if DatePicker works by checking if the picked date shows up in the Date input on top
18. Verify if adding the chosen date works by pressing Save
19. Now go to Subscription
20. Press Add payment card (now we will be testing CurrencySelector component)
21. Verify that the CurrencySelector works correctly by pressing it and changing the currency
22. Now go to Security
23. Press Merge accounts (now we will be testing CheckboxWithLabel)
24. Verify that CheckboxWithLabel works correctly by pressing it (you can do it multiple times)
25. Now go to Wallet
26. Press Enable wallet (now we will be testing InteractiveStepSubHeader, InteractiveStepWrapper, RadioButtons and SingleChoiceQuestion components)
27. Fill out the forms using this info -> https://swmansion.slack.com/archives/C01GTK53T8Q/p1711049879962529 (this data is required as it has to be real in order for the validation to let you through to the targeted forms)
28. Verify that InteractiveStepWrapper works properly by filling out the bank info
29. Verify that InteractiveStepSubHeader works properly by checking if the step header 'checks' the first step and moves on to focus the second one after filling out the bank info
30. Now fill out the PersonalInfo section using information from the above slack discussion but it is for some reason crucial that you input the last name as Bobbeth otherwise you won't see IdologyQuestions which we need to test
31. Verify that RadioButtons and SingleChoiceQuestion components work properly by answering the questions (you can do that correctly or not or both ways to test it - testing it with only one of those is fine and completely enough)
32. Now go to Workspaces and choose any workspace that you are an owner of
33. Press More -> Share (now we will be testing if ContextMenuItem component works properly)
34. Verify that ContextMenuItem works properly by pressing the Copy URL and pasting it in the search bar of the web browser
35. Verify that HighlightableMenuItem works properly by going to any feature of the workspace - if you can navigate between the features of the workspace (for example Overview to More features) then it works
36. Go to More features and turn on Taxes, Rules and Per diem
37. Press Taxes (now we will be testing AmountPicker component)
38. Press +Add rate -> Value
39. Verify that AmountPicker works properly by pressing it and adding the value
40. Press Rules (now we will be testing PercentageForm component)
41. Turn on Auto-approve compliant reports
42. Verify that PercentageForm works properly by changing the value of Random report audit
43. Press Per diem (now we will be testing TextLink component)
44. Verify that TextLink works properly by pressing it and checking if the ExpensifyHelp site opens
45. Download one of the Per Diem Rate Templates
46. Import the downloaded spreadsheet
47. Press the + floating button in the left bottom corner (now we will be testing TimeModalPicker component)
48. Press Create expense -> Per diem and choose any per diem rate
49. Verify that TimeModalPicker works properly by changing Start time or End time of the per diem expense
50. Now go to Reports -> Filters
51. Press Amount (now we will be testing AmountWithoutCurrencyInput component)
52. Choose any one of Equal to, Greater than, Less than
53. Verify that AmountWithoutCurrencyInput works properly by changing the value of one of the above and checking if it filtered the results properly
54. Now go to any 1:1 chat (now we will be testing withViewportOffsetTop which is used to open some of the popovers properly -> in this case the EmojiPicker)
55. Verify that withViewportOffsetTop works properly by pressing the EmojiPicker and choosing some emoji - check if it's properly added to the message composer

This one needs to be done on staging
56. Go to URL https://staging.new.expensify.com/
57. Login with any account
58. Verify that FormScrollView works properly by opening the enable payments page http://staging.new.expensify.com/enable-payments - if it loads correctly and you are able to go further with the flow then it works

This one need to be done on native
59. Go to the Photos/Gallery on the phone and share some image with Expensify
60. Verify that ShareTabParticipantsSelector works properly by sharing the image with other user/workspace
61. Now go to any 1:1 chat and add a few images in the chat
62. Press on the image so that the AttachmentCarousel opens up
63. Verify that the Pager works correctly by traversing through the attachments
64. Go to any 1:1 chat and add a few messages
65. Verify that ActionSheetAwareScrollView works properly by editing one of the messages

• Verify that no errors appear in the JS console

Offline tests

Same as Tests

QA Steps

Same as Tests

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

Steps from 59 to 65:

59to65.mp4

iOS: mWeb Safari

MacOS: Chrome / Safari

Steps from 1 to 18:

1to18.mp4

Steps from 19 to 24:

19to24.mp4

Steps from 25 to 31:

25to31.mp4

Steps from 32 to 49:

32to49.mp4

Steps from 50 to 55:

50to55.mp4

This one has to be done on staging
Steps from 56 to 58:

56to58.mp4

MacOS: Desktop

[codecov]

Codecov Report

❌ Patch coverage is 36.50794% with 40 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/ContextMenuItem.tsx	0.00%	12 Missing ⚠️
src/components/DatePicker/index.tsx	0.00%	7 Missing ⚠️
src/components/MagicCodeInput.tsx	46.15%	7 Missing ⚠️
src/components/PercentageForm.tsx	0.00%	3 Missing ⚠️
src/components/AmountWithoutCurrencyInput.tsx	0.00%	2 Missing ⚠️
...rc/components/ActionSheetAwareScrollView/index.tsx	0.00%	1 Missing ⚠️
src/components/AddressSearch/index.tsx	85.71%	0 Missing and 1 partial ⚠️
src/components/AmountPicker/index.tsx	0.00%	1 Missing ⚠️
src/components/FormScrollView.tsx	0.00%	1 Missing ⚠️
src/components/HighlightableMenuItem.tsx	0.00%	1 Missing ⚠️
... and 4 more

📢 Thoughts on this report? Let us know!

[melvin-bot]

@c3024 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[mountiny]

@c3024 what is your ETA for the review?

[c3024]

Reviewer Checklist

• I have verified the author checklist is complete (all boxes are checked off).
• I verified the correct issue is linked in the ### Fixed Issues section above
• I verified testing steps are clear and they cover the changes made in this PR
  • I verified the steps for local testing are in the Tests section
  • I verified the steps for Staging and/or Production testing are in the QA steps section
  • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
• I checked that screenshots or videos are included for tests on all platforms
• I included screenshots or videos for tests on all platforms
• I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
• I verified tests pass on all platforms & I tested again on:
  • Android: HybridApp
  • Android: mWeb Chrome
  • iOS: HybridApp
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
  • MacOS: Desktop
• If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I verified proper code patterns were followed (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I verified that this PR follows the guidelines as stated in the Review Guidelines
• I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• If a new component is created I verified that:
  • A similar component doesn't exist in the codebase
  • All props are defined accurately and each prop has a /** comment above it */
  • The file is named correctly
  • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
  • The only data being stored in the state is data necessary for rendering and nothing else
  • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
  • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
  • All JSX used for rendering exists in the render method
  • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
• I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

ref7Android.mov

Android: mWeb Chrome

ref7AndroidmWeb.mov

ref7AndroidmWeb1.mov

iOS: HybridApp

ref7iOS1.mov

iOS: mWeb Safari

ref7iOSmWeb.mov

MacOS: Chrome / Safari

ref7Chrome1.mp4

ref7Chrome2.mov

ref7Chrome3.mp4

ref7Chrome4.mp4

ref7Chrome5.mp4

MacOS: Desktop

ref7Desktop.mov

[c3024]

Does not seem related to this migration but we can remove this redundant forwardRef here.

App/src/components/SubStepForms/SingleFieldStep.tsx

Line 133 in 0cb2776

export default forwardRef(SingleFieldStep);

[c3024]

LGTM!

[jakubkalinski0]

@c3024 Yeah, this component will be taken care of in the next batch. I hope I can fit all the remaining components (about 20-ish) into batch 8 and finish the migration.

[mountiny]

Code changes look good to me

[OSBotify]

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[OSBotify]

🚀 Deployed to staging by https://github.com/mountiny in version: 9.2.21-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform	result
🖥 desktop 🖥	failure ❌
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/Julesssss in version: 9.2.21-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅