[Standardize payment button] Invoice Bulk by hungvu193 · Pull Request #72445 · Expensify/App

hungvu193 · 2025-10-13T11:12:53Z

NOTE FOR QA: This feature is under beta

Explanation of Change

Part of #55876.

This PR adds bulk payment option for Invoice 🤞 You're now able to select multiple invoices and pay them in one go ⚡

Fixed Issues

$ #55876
#72399
PROPOSAL: N/A

Tests

Same as QA steps

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."
Prerequisite:
Your account is under payment button beta

Test 1: First time payment

Login with account A.
Request some invoices to account B.
Login with account B and go to Reports.
Select all invoices from account A.
Choose bulk option > Pay.
Verify that you can see 2 options under Pay. (Pay as business and Pay as personal)
Choose one of the option and try to pay the Invoice.
Verify that you can pay the invoice.

Test 2: Paid the invoice before.

After paying invoices successfully from Test 1.
Login with account A and request a few other invoices to account B.
Login with Account B and go to Reports.
Select all the Invoices from account A and choose bulk option.
Verify that you can see the Pay option > Click on Pay options.
Verify that all invoices are paid successfully.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Screen.Recording.2025-11-03.at.00.13.21.mov

MacOS: Desktop

Screen.Recording.2025-11-03.at.00.17.23.mov

codecov · 2025-10-13T11:24:17Z

Codecov Report

❌ Patch coverage is 12.12121% with 58 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/hooks/useBulkPayOptions.ts	0.00%	28 Missing ⚠️
src/pages/Search/SearchPage.tsx	0.00%	16 Missing ⚠️
src/libs/actions/Search.ts	57.14%	6 Missing ⚠️
src/hooks/usePaymentOptions.ts	0.00%	3 Missing ⚠️
src/libs/ReportUtils.ts	0.00%	3 Missing ⚠️
src/components/Search/SearchContext.tsx	0.00%	2 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/PopoverMenu.tsx	`76.63% <ø> (ø)`
...ts/SelectionListWithSections/Search/ActionCell.tsx	`57.77% <ø> (+2.45%)`	⬆️
src/components/Search/SearchContext.tsx	`25.00% <0.00%> (ø)`
src/hooks/usePaymentOptions.ts	`0.00% <0.00%> (ø)`
src/libs/ReportUtils.ts	`74.97% <0.00%> (-0.14%)`	⬇️
src/libs/actions/Search.ts	`11.25% <57.14%> (-8.63%)`	⬇️
src/pages/Search/SearchPage.tsx	`0.00% <0.00%> (ø)`
src/hooks/useBulkPayOptions.ts	`0.00% <0.00%> (ø)`

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

hungvu193 · 2025-10-29T16:29:42Z

src/hooks/useBulkPayOptions.ts

+                    additionalData: {
+                        payAsBusiness,
+                        methodID: formattedPaymentMethod.methodID,
+                        paymentMethod: formattedPaymentMethod.accountType,
+                    },  


Explanation for these changes:

Unlike SettlementButton options, with bulk pay, our option is nested under another sub-menu item, it looks like this at the moment:

Pay > Pay with business (or personal) > Our options (Mark as paid or Add business bank account or bank account list).

In this case, to handle onPress of these sub-menu items, the only way to get this necessary information is from the sub-menu item option itself.

App/src/components/ButtonWithDropdownMenu/index.tsx

Lines 109 to 116 in ae4386a

if (option.onSelected) {

option.onSelected();

} else {

onOptionSelected?.(option);

onPress(event, option.value);

}

onSubItemSelected?.(option, 0, event);

We can't use onSelected props of the sub-menu item because we still execute onSubItemSelected?.(option, 0, event); anyway after option.onSelected(); is called.

Since we're also using onSubItemSelected to handle the previous bulk options, I decided to do that with invoice bulk too, so we can reuse all the existing logic:

App/src/components/Search/SearchPageHeader/SearchFiltersBar.tsx

Lines 683 to 695 in ae4386a

onSubItemSelected={(subItem) =>

handleBulkPayItemSelected(

subItem,

triggerKYCFlow,

isAccountLocked,

showLockedAccountModal,

currentPolicy,

latestBankItems,

activeAdminPolicies,

isUserValidated,

confirmPayment,

)

}

Let me know if you guys have any questions or suggestions 👋

cc @grgia and @getusha

…into feat-invoice-bulk

melvin-bot · 2025-11-02T17:04:46Z

@getusha Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/SettlementButton/index.tsx

github-actions · 2025-11-02T17:06:39Z

LGTM 👍 Thank you for your hard work!

src/components/SettlementButton/index.tsx

github-actions · 2025-11-03T21:54:35Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-11-06T15:17:13Z

🚧 @joekaufmanexpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-11-06T15:22:06Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72445.

Android 🤖	iOS 🍎
⏩ SKIPPED ⏩	⏩ SKIPPED ⏩
The build for Android was skipped	The build for iOS was skipped

Desktop 💻	Web 🕸️
⏩ SKIPPED ⏩	https://72445.pr-testing.expensify.com
The build for Desktop was skipped

👀 View the workflow run that generated this build 👀

joekaufmanexpensify · 2025-11-06T15:34:44Z

QUESTION: No option to bulk pay invoices from different senders if you haven't paid before. Is this expected?

I think yes because they are coming from different policies based on the sender. Is that right?

joekaufmanexpensify · 2025-11-06T15:35:30Z

BUG: Adding system message twice when bulk paying invoice

We should only add the pay confirmation system message to each invoice once when paying, it's being duplicated right now.

2025-11-06_10-33-06.mp4

joekaufmanexpensify

Otherwise tests well from my perspective!

hungvu193 · 2025-11-06T15:47:44Z

Otherwise tests well from my perspective!

This is on main I believe. But let me double check. I remember @getusha also reported similar one in our previous PR

hungvu193 · 2025-11-06T15:51:36Z

Here you are:

#72651

It's backend issue and being worked on.

hungvu193 · 2025-11-06T16:00:14Z

I think yes because they are coming from different policies based on the sender. Is that right?

Yes. Correct. They should be from the same policy

getusha · 2025-11-06T19:12:23Z

@hungvu193 we've got a conflict!

hungvu193 · 2025-11-07T02:33:47Z

@hungvu193 we've got a conflict!

Resolved 😄

getusha · 2025-11-07T10:48:24Z

Screenshot 2025-11-07 at 1 48 04 in the afternoon

Screenshot 2025-11-07 at 1 47 01 in the afternoon

grgia

NAB comment, great work on pushing through this project!

src/pages/Search/SearchPage.tsx

OSBotify · 2025-11-07T17:30:33Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-07T23:46:17Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.47-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-10T12:00:51Z

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

invoice bulk

84ae0da

melvin-bot bot assigned hungvu193 Oct 13, 2025

hungvu193 added 4 commits October 13, 2025 23:26

add basic invoice bulk logic

635c451

merge main

9780a08

linting + add extra props for PopOverItem

ec1b147

remove console & resolve console error

ad82e39

This comment was marked as outdated.

Sign in to view

Add TODO notes

deb6897

hungvu193 commented Oct 29, 2025

View reviewed changes

hungvu193 added 6 commits October 31, 2025 15:41

merge main

3473fa1

linting

cda94ee

merge main

c85df85

Merge branch 'feat-invoice-bulk' of https://github.com/hungvu193/App …

14defd2

…into feat-invoice-bulk

update params for invoice on Search

16b8a9d

linting

6e0939d

hungvu193 marked this pull request as ready for review November 2, 2025 17:04

hungvu193 requested a review from a team as a code owner November 2, 2025 17:04

melvin-bot bot requested review from getusha and removed request for a team November 2, 2025 17:04

github-actions bot reviewed Nov 2, 2025

View reviewed changes

src/components/SettlementButton/index.tsx Outdated Show resolved Hide resolved

address comment

1d452ba

hungvu193 changed the title ~~Feat invoice bulk~~ [Standardize payment button] Invoice Bulk Nov 2, 2025

hungvu193 commented Nov 2, 2025

View reviewed changes

src/components/SettlementButton/index.tsx Outdated Show resolved Hide resolved

remove unused code

110f4b9

hungvu193 mentioned this pull request Nov 3, 2025

[Standardize Payment Button][NO QA] Remove paymentButtons beta #74059

Merged

54 tasks

sync submodule

8e3b0e8

joekaufmanexpensify requested review from joekaufmanexpensify and removed request for heyjennahay November 6, 2025 15:15

joekaufmanexpensify reviewed Nov 6, 2025

View reviewed changes

update submodule

e221c86

getusha approved these changes Nov 7, 2025

View reviewed changes

melvin-bot bot requested a review from grgia November 7, 2025 08:41

hungvu193 added 3 commits November 7, 2025 16:21

merge main

4e091a4

correct options

a1e7ad7

update expensify option

fb99d54

getusha approved these changes Nov 7, 2025

View reviewed changes

hungvu193 mentioned this pull request Nov 7, 2025

[Standardize Payment Button] Correct the Pay options #74553

Closed

54 tasks

grgia approved these changes Nov 7, 2025

View reviewed changes

src/pages/Search/SearchPage.tsx Show resolved Hide resolved

grgia merged commit eb3c7be into Expensify:main Nov 7, 2025
31 checks passed

github-actions bot mentioned this pull request Nov 7, 2025

Investigate workflow job failing on main: test / test (job 2) #74562

Closed

OSBotify mentioned this pull request Nov 7, 2025

Deploy Checklist: New Expensify 2025-11-07 #74626

Closed

48 tasks

melvin-bot bot mentioned this pull request Nov 10, 2025

[Due for payment 2025-11-17] [Due for payment 2025-11-04] [Standardize the pay button] Invoices #55876

Closed

lanitochka17 mentioned this pull request Nov 10, 2025

[$250] Invoice - New workspace is not created after paying invoice as business on Reports #74759

Closed

16 tasks

	if (option.onSelected) {
	option.onSelected();
	} else {
	onOptionSelected?.(option);
	onPress(event, option.value);
	}

	onSubItemSelected?.(option, 0, event);

	onSubItemSelected={(subItem) =>
	handleBulkPayItemSelected(
	subItem,
	triggerKYCFlow,
	isAccountLocked,
	showLockedAccountModal,
	currentPolicy,
	latestBankItems,
	activeAdminPolicies,
	isUserValidated,
	confirmPayment,
	)
	}

Conversation

hungvu193 commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

NOTE FOR QA: This feature is under beta

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

Test 1: First time payment

Test 2: Paid the invoice before.

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

hungvu193 Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hungvu193 Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

hungvu193 Nov 2, 2025

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 2, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 3, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

joekaufmanexpensify commented Nov 6, 2025

QUESTION: No option to bulk pay invoices from different senders if you haven't paid before. Is this expected?

Uh oh!

joekaufmanexpensify commented Nov 6, 2025

BUG: Adding system message twice when bulk paying invoice

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

hungvu193 commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hungvu193 commented Nov 6, 2025

Uh oh!

hungvu193 commented Nov 6, 2025

Uh oh!

getusha commented Nov 6, 2025

Uh oh!

hungvu193 commented Nov 7, 2025

Uh oh!

getusha commented Nov 7, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

OSBotify commented Nov 7, 2025

Uh oh!

OSBotify commented Nov 7, 2025

Uh oh!

OSBotify commented Nov 10, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

hungvu193 commented Oct 13, 2025 •

edited

Loading

codecov bot commented Oct 13, 2025 •

edited

Loading

hungvu193 Oct 29, 2025 •

edited

Loading

hungvu193 commented Nov 6, 2025 •

edited

Loading