[Standardize Payment Button] Correct the Pay options#74553
Closed
hungvu193 wants to merge 1 commit intoExpensify:mainfrom
Closed
[Standardize Payment Button] Correct the Pay options#74553hungvu193 wants to merge 1 commit intoExpensify:mainfrom
hungvu193 wants to merge 1 commit intoExpensify:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
... and 246 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Author
|
The changes are small, we decided to fix it in #72445 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
Correct the Pay options that was previously added in #62107
Fixed Issues
$ #72399
PROPOSAL: N/A
Tests
Same as QA steps
Offline tests
N/A
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Precondition:
Prerequisite: "Delay submissions" and "Add approvals" are disabled in Workflows settings.
10 Enter reason and save it.
Pay with Businessbutton.PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-11-07.at.16.38.55.mov
MacOS: Desktop
Screen.Recording.2025-11-07.at.16.48.38.mov