Allow initial avatars by jmusial · Pull Request #72685 · Expensify/App

jmusial · 2025-10-15T12:17:42Z

Explanation of Change

This PR adds a possibility to select a colored inital letter as users avatar.

Fixed Issues

$ #71889
$ #71890
PROPOSAL:

Tests

Open app
Go to Account -> Profile
Click on Avatar
Perform different actions like:
- Select custom image avatar
- Try to go back (confirm modal appears)
- Save custom avatar
- Select letter avatar
- Remove avatar
The feel should be smooth :)

Offline tests

QA Steps

Same as tests

PR Author Checklist

Screenshots/Videos

Android: Native

0053.android.native.mov

Android: mWeb Chrome

0053.android.chrome.mov

iOS: Native

0053.ios.native.mov

iOS: mWeb Safari

0053.ios.chrome.mov

MacOS: Chrome / Safari

0053.desktop.chrome.mov

MacOS: Desktop

0053.desktop.native.mov

jmusial · 2025-10-15T12:38:54Z

It's a initial draft. Video of how the flows look like now:

Screen.Recording.2025-10-15.at.14.18.10.mov

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-10-15.at.14.42.35.mov

github-actions · 2025-10-15T13:12:02Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

grgia

triggered a build >:)

melvin-bot · 2025-10-16T14:51:55Z

@dukenv0307 @grgia One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

jmusial · 2025-10-16T14:52:28Z

@grgia can you please trigger the translations workflow ?

grgia

ran translation workflow

grgia

Woop! Running a build for some good ol design review @dannymcclain

github-actions · 2025-10-16T15:29:52Z

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-16T15:51:14Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72685.

Android 🤖	iOS 🍎
https://github.com/Expensify/App/actions/runs/18566493606/artifacts/4290401996	https://github.com/Expensify/App/actions/runs/18566493606/artifacts/4290374562

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72685/NewExpensify.dmg	https://72685.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dukenv0307 · 2025-10-20T16:18:01Z

on it now

dukenv0307 · 2025-10-20T16:31:35Z

src/components/AvatarSelector.tsx

 import useThemeStyles from '@hooks/useThemeStyles';
-import type {ALL_CUSTOM_AVATARS} from '@libs/Avatars/CustomAvatarCatalog';
-import {CUSTOM_AVATAR_CATALOG} from '@libs/Avatars/CustomAvatarCatalog';
+// import {CUSTOM_AVATAR_CATALOG} from '@libs/Avatars/CustomAvatarCatalog';


Do we need this?

JmillsExpensify · 2025-10-20T16:42:11Z

Appreciate the hustle on this PR. As a heads up, we are aiming to announce this feature to all users tomorrow, so it's pretty critical that we try and get it to staging today, followed by production on Wednesday. Otherwise, we'll need to remove this from this month's product update.

dukenv0307 · 2025-10-20T16:47:29Z

BUG: Press browser back button doesn't reset the uploaded image

Screen.Recording.2025-10-20.at.23.45.39.mov

dukenv0307 · 2025-10-20T17:16:26Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-21.at.00.13.23.mov

Android: mWeb Chrome

iOS: HybridApp

Screen.Recording.2025-10-21.at.00.14.06.mov

iOS: mWeb Safari

Screen.Recording.2025-10-21.at.00.09.30.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-21.at.00.02.19.mov

MacOS: Desktop

Screen.Recording.2025-10-21.at.00.15.04.mov

dukenv0307 · 2025-10-20T17:17:18Z

@jmusial Should we fix this issue here or in the follow-up PR?

dukenv0307 · 2025-10-20T17:17:29Z

The rest looks good

jmusial · 2025-10-20T20:39:36Z

@dukenv0307 yeah can fix it in followup. Should be just aligning callbacks.

JmillsExpensify · 2025-10-20T21:50:41Z

Looks like we'll merge this tomorrow?

dukenv0307 · 2025-10-21T01:57:20Z

all yours @grgia, cc @JmillsExpensify

jmusial · 2025-10-21T09:34:13Z

BUG: Press browser back button doesn't reset the uploaded image

Screen.Recording.2025-10-20.at.23.45.39.mov

Fixed in #72542

Screen.Recording.2025-10-21.at.11.33.32.mov

OSBotify · 2025-10-21T10:12:45Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-21T23:29:39Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.36-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2025-10-22T04:44:37Z

PR is fail with this issue
This issue is reproducible in: All platforms

OSBotify · 2025-10-23T12:44:22Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.36-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

poc

a5248fe

melvin-bot bot assigned jmusial Oct 15, 2025

fix lint

bc03ce3

jmusial changed the title ~~poc~~ Allow initial avatars Oct 15, 2025

grgia reviewed Oct 15, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

jmusial added 3 commits October 16, 2025 12:15

Merge branch 'main' into feat/allow-initial-avatars

9a4a225

cleanup AvatarCatalog; Add tests for useLetterAvatars

1db86c7

fix lint

eff232b

grgia requested a review from dannymcclain October 16, 2025 12:30

jmusial added 4 commits October 16, 2025 15:15

update Avatar Selector tests

ada1a9b

rename ColoredLetterAvatar

81d98f3

Refactor Avatar Page

6354223

remove unused types

63f951f

jmusial marked this pull request as ready for review October 16, 2025 14:51

jmusial requested review from a team as code owners October 16, 2025 14:51

melvin-bot bot requested review from dukenv0307 and grgia and removed request for a team October 16, 2025 14:51

grgia reviewed Oct 16, 2025

View reviewed changes

This comment has been minimized.

Sign in to view

update translation

8a752d8

grgia reviewed Oct 16, 2025

View reviewed changes

grgia previously approved these changes Oct 20, 2025

View reviewed changes

dukenv0307 reviewed Oct 20, 2025

View reviewed changes

dukenv0307 approved these changes Oct 21, 2025

View reviewed changes

melvin-bot bot requested a review from grgia October 21, 2025 01:56

Merge branch 'main' into feat/allow-initial-avatars

0bd58e5

jmusial dismissed grgia’s stale review via 0bd58e5 October 21, 2025 07:59

fix tsc

45bbb85

prettier fix

8e7f89c

grgia approved these changes Oct 21, 2025

View reviewed changes

grgia merged commit 429a430 into Expensify:main Oct 21, 2025
25 checks passed

OSBotify mentioned this pull request Oct 21, 2025

Deploy Checklist: New Expensify 2025-10-21 #73157

Closed

57 tasks

jponikarchuk mentioned this pull request Oct 22, 2025

[Due for payment 2025-10-31] Discard changes shows up when trying to Save "Letter" profile picture #73172

Closed

8 tasks

mitarachim mentioned this pull request Oct 22, 2025

"Letter" image quality is very low for Profile Avatar picture #73173

Open

8 tasks

melvin-bot bot mentioned this pull request Oct 23, 2025

[Due for payment 2025-10-30] [Avatar Customization] Create Initial Avatar Generator Logic #71889

Closed

melvin-bot bot mentioned this pull request Oct 23, 2025

[Due for payment 2025-10-30] [Avatar Customization] Integrate Initial Avatars into list of Custom Avatar Options #71890

Closed

dukenv0307 mentioned this pull request Jan 14, 2026

[Tracking][New Feature][Avatar] - Expensify Avatar Customization #71653

Closed

Conversation

jmusial commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

jmusial commented Oct 15, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 15, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

melvin-bot bot commented Oct 16, 2025

Uh oh!

jmusial commented Oct 16, 2025

Uh oh!

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

This comment has been minimized.

grgia left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

github-actions bot commented Oct 16, 2025

Uh oh!

dukenv0307 commented Oct 20, 2025

Uh oh!

dukenv0307 Oct 20, 2025

Choose a reason for hiding this comment

Uh oh!

JmillsExpensify commented Oct 20, 2025

Uh oh!

dukenv0307 commented Oct 20, 2025

Uh oh!

dukenv0307 commented Oct 20, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

dukenv0307 commented Oct 20, 2025

Uh oh!

dukenv0307 commented Oct 20, 2025

Uh oh!

jmusial commented Oct 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JmillsExpensify commented Oct 20, 2025

Uh oh!

dukenv0307 commented Oct 21, 2025

Uh oh!

jmusial commented Oct 21, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 21, 2025

Uh oh!

OSBotify commented Oct 21, 2025

Uh oh!

jponikarchuk commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

jmusial commented Oct 15, 2025 •

edited

Loading

jmusial commented Oct 15, 2025 •

edited

Loading

jmusial commented Oct 20, 2025 •

edited

Loading

jponikarchuk commented Oct 22, 2025 •

edited

Loading