fix: reduce the PDF download steps by one click by daledah · Pull Request #72846 · Expensify/App

daledah · 2025-10-17T08:13:06Z

Explanation of Change

Fixed Issues

$ #72035
PROPOSAL: #72035 (comment)

Tests

Create a report
Add a couple of expenses to it
Click More > Download as PDF
Click Download
Verify that: The report is automatically downloaded after loading.

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create a report
Add a couple of expenses to it
Click More > Download as PDF
Click Download
Verify that: The report is automatically downloaded after loading.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mov

Android: mWeb Chrome

Screen.Recording.2025-10-17.at.15.50.57.mov

iOS: Native

ios.mov

iOS: mWeb Safari

Screen.Recording.2025-10-17.at.15.56.43.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-17.at.15.59.22.mov

MacOS: Desktop

Screen.Recording.2025-10-17.at.16.00.28.mov

codecov · 2025-10-17T08:25:08Z

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/MoneyReportHeader.tsx	0.00%	6 Missing ⚠️

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.71% <ø> (+1.90%)`	⬆️
src/components/MoneyReportHeader.tsx	`0.18% <0.00%> (+<0.01%)`	⬆️

... and 276 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-17T09:05:42Z

@alitoshmatov Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dannymcclain · 2025-10-18T16:17:56Z

@dubielzyk-expensify does this alignment for the spinner look right to you? It doesn't feel quite as centered as you have it laid out here. Could just be my eyes playing tricks though—@daledah can you double check?

For iOS, why doesn't this modal have a title like it does on desktop/web? And why does it change?

Same question for mobile web, why does the modal change part way through?

dubielzyk-expensify · 2025-10-20T00:34:15Z

Agree with everything you're saying Danny. Doesn't look vertically centered:

JmillsExpensify · 2025-10-20T08:13:58Z

@alitoshmatov please help us with a PR review when you're on. We'd like to prioritize getting this improvement to production.

src/languages/en.ts

src/components/MoneyReportHeader.tsx

alitoshmatov · 2025-10-20T20:39:50Z

Same question for mobile web, why does the modal change part way through?

@daledah Is this because downloading is also taking a little bit time.

May be we should combine both waiting for file and downloading states into one, and show single message in both cases here:

App/src/components/MoneyReportHeader.tsx

Lines 291 to 299 in a97e742

    
           const messagePDF = useMemo(() => { 
        
               if (!reportPDFFilename) { 
        
                   return translate('reportDetailsPage.waitForPDF'); 
        
               } 
        
               if (reportPDFFilename === CONST.REPORT_DETAILS_MENU_ITEM.ERROR) { 
        
                   return translate('reportDetailsPage.errorPDF'); 
        
               } 
        
               return translate('reportDetailsPage.generatedPDF'); 
        
           }, [reportPDFFilename, translate]);

daledah · 2025-10-22T16:51:36Z

@alitoshmatov I updated using your suggestions.

For iOS, why doesn't this modal have a title like it does on desktop/web? And why does it change?

Currently I can't find the RCA for this, but the modal component cuts off its contents so the header is not shown. I'll take a deeper look into this. But IMO it's a out-of-scope bug for this PR.

trjExpensify · 2025-10-22T22:03:38Z

@daledah are you saying that the iOS modal title bug is present in other modals on production?

trjExpensify · 2025-10-27T16:15:08Z

Bump @daledah!

situchan · 2025-10-27T16:17:40Z

I'd be happy to review this since @alitoshmatov is OOO starting today

trjExpensify · 2025-10-27T18:57:07Z

Yes please!

melvin-bot · 2025-10-28T03:33:46Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. If you want to automatically generate translations for other locales, you can run the Generate static translations GitHub workflow.

Please look at the code and make sure there are no malicious changes before running the workflow.

If you have the K2 extension, you can simply click: [this button]

daledah · 2025-10-28T03:34:13Z

@trjExpensify Fixed the header not showing, turns out it's because of incorrect stylings 😅

situchan · 2025-10-28T11:25:28Z

Unit Tests failing

situchan · 2025-10-28T11:25:57Z

I am being redirected to expensify.com.dev
Is it expected?

web.mov

daledah · 2025-10-30T02:45:58Z

I'm checking now

melvin-bot · 2025-10-30T07:27:33Z

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

Look at the code and make sure there are no malicious changes.
Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

daledah · 2025-10-30T07:37:54Z

I am being redirected to expensify.com.dev Is it expected?

web.mov

@situchan This is expected when testing on the dev branch as logic here

App/src/libs/actions/Report.ts

Lines 4921 to 4927 in 13a0e11

    
           function downloadReportPDF(fileName: string, reportName: string) { 
        
               const baseURL = addTrailingForwardSlash(getOldDotURLFromEnvironment(environment)); 
        
               const downloadFileName = `${reportName}.pdf`; 
        
               setDownload(fileName, true); 
        
               const pdfURL = `${baseURL}secure?secureType=pdfreport&filename=${encodeURIComponent(fileName)}&downloadName=${encodeURIComponent(downloadFileName)}&email=${encodeURIComponent( 
        
                   currentUserEmail ?? '', 
        
               )}`;

daledah · 2025-10-30T07:55:10Z

@situchan Looks like the PDF download link is having problems with the dev environment. After changing to use staging environment, it works well

ios.mov

daledah · 2025-10-30T08:12:37Z

I am still seeing missing header on native.

@situchan i updated the videos on native

situchan · 2025-10-30T17:37:12Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android.mov

Android: mWeb Chrome

mchrome.mov

iOS: HybridApp

ios.mov

iOS: mWeb Safari

msafari.mov

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

situchan · 2025-10-30T17:38:36Z

@trjExpensify can you please generate adhoc build here?
As download is not working correctly in dev env, wanna test adhoc build.

trjExpensify · 2025-10-30T17:41:14Z

On it

github-actions · 2025-10-30T17:42:04Z

🚧 @trjExpensify has triggered a test Expensify/App build. You can view the workflow run here.

github-actions · 2025-10-30T18:06:38Z

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #72846.

Android 🤖	iOS 🍎
https://ad-hoc-expensify-cash.s3.amazonaws.com/android/72846/index.html	https://ad-hoc-expensify-cash.s3.amazonaws.com/ios/72846/index.html

Desktop 💻	Web 🕸️
https://ad-hoc-expensify-cash.s3.amazonaws.com/desktop/72846/NewExpensify.dmg	https://72846.pr-testing.expensify.com

👀 View the workflow run that generated this build 👀

dannymcclain · 2025-10-30T19:40:44Z

Doesn't seem to be working on that build for me.

trjExpensify · 2025-10-31T16:10:49Z

@daledah, what's your next step here?

daledah · 2025-10-31T16:19:14Z

@trjExpensify i resolved all comments. Waiting for the next review from @situchan

situchan · 2025-10-31T16:23:47Z

Doesn't seem to be working on that build for me.

I think the question is about this

situchan · 2025-10-31T17:39:49Z

Doesn't seem to be working on that build for me.

@dannymcclain which platforms have you tested on? Can you please share video?

I tested on android native, android chrome, ios safari and worked fine.

dannymcclain · 2025-10-31T17:46:29Z

Looks like Chrome is the bugger here for some reason. Works fine for me on Safari?

Chrome
It spins like it's making the PDF or something, but nothing ever happens. The modal just goes away.

CleanShot.2025-10-31.at.12.41.52.mp4

Safari
Works so quickly I don't even see the modal haha. I didn't expect the new tab to pop open, but it properly closes the tab and everything works how I would expect, so it seems good to me.

CleanShot.2025-10-31.at.12.43.10.mp4

situchan · 2025-10-31T17:51:42Z

@dannymcclain maybe because it's adhoc url. Hopefully work fine on staging / production

Please allow here

situchan · 2025-10-31T17:56:09Z

src/components/MoneyReportHeader.tsx

+                            <ActivityIndicator
+                                size={CONST.ACTIVITY_INDICATOR_SIZE.SMALL}
+                                color={theme.textSupporting}
+                                style={styles.ml3}


When failed to generate pdf, still shows loading indicator. Hope this would be fine.

dannymcclain · 2025-10-31T18:04:19Z

maybe because it's adhoc url. Hopefully work fine on staging / production
Please allow here

Ah ha! Thank you so much for that—didn't even see that it blocked a pop up 🤦‍♂️

Once I allowed from there it worked perfectly 👍

dubielzyk-expensify · 2025-11-03T02:28:33Z

Dialog looks good from my eyes 👍

OSBotify · 2025-11-03T11:59:24Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-03T23:01:54Z

🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.43-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-04T20:49:27Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

daledah added 3 commits October 10, 2025 03:00

fix: reduce the PDF download steps by one click

e4186b5

Merge branch 'main' into fix/72035

a00af63

fix: update styles

1b3106f

melvin-bot bot assigned daledah Oct 17, 2025

daledah marked this pull request as ready for review October 17, 2025 09:05

daledah requested a review from a team as a code owner October 17, 2025 09:05

melvin-bot bot requested review from alitoshmatov and removed request for a team October 17, 2025 09:05

daledah mentioned this pull request Oct 17, 2025

[Due for payment 2025-11-11] [CFI] Reduce the PDF download steps by one click. #72035

Closed

16 tasks

alitoshmatov reviewed Oct 20, 2025

View reviewed changes

src/languages/en.ts Show resolved Hide resolved

src/languages/en.ts Outdated Show resolved Hide resolved

src/components/MoneyReportHeader.tsx Outdated Show resolved Hide resolved

daledah added 2 commits October 22, 2025 15:22

Merge branch 'main' into fix/72035

34dfb5d

fix: update suggestions

2543ca4

trjExpensify requested a review from situchan October 27, 2025 18:57

daledah added 2 commits October 28, 2025 09:21

Merge branch 'main' into fix/72035

6f22588

fix: header is not displayed

c28320b

Merge branch 'main' into fix/72035

c07d5e8

situchan reviewed Oct 31, 2025

View reviewed changes

situchan approved these changes Oct 31, 2025

View reviewed changes

melvin-bot bot requested a review from cristipaval October 31, 2025 17:56

cristipaval approved these changes Nov 3, 2025

View reviewed changes

cristipaval merged commit 8c53c50 into Expensify:main Nov 3, 2025
29 checks passed

OSBotify mentioned this pull request Nov 3, 2025

Deploy Checklist: New Expensify 2025-11-03 #74140

Closed

54 tasks

situchan mentioned this pull request Dec 5, 2025

Persist PDF modal and let user trigger download manually to fix transient activation bug #76766

Merged

51 tasks

Conversation

daledah commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 17, 2025

Uh oh!

dannymcclain commented Oct 18, 2025

Uh oh!

dubielzyk-expensify commented Oct 20, 2025

Uh oh!

JmillsExpensify commented Oct 20, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

alitoshmatov commented Oct 20, 2025

Uh oh!

daledah commented Oct 22, 2025

Uh oh!

trjExpensify commented Oct 22, 2025

Uh oh!

trjExpensify commented Oct 27, 2025

Uh oh!

situchan commented Oct 27, 2025

Uh oh!

trjExpensify commented Oct 27, 2025

Uh oh!

melvin-bot bot commented Oct 28, 2025

Uh oh!

daledah commented Oct 28, 2025

Uh oh!

situchan commented Oct 28, 2025

Uh oh!

situchan commented Oct 28, 2025

Uh oh!

daledah commented Oct 30, 2025

Uh oh!

melvin-bot bot commented Oct 30, 2025

Uh oh!

daledah commented Oct 30, 2025

Uh oh!

daledah commented Oct 30, 2025

Uh oh!

daledah commented Oct 30, 2025

Uh oh!

situchan commented Oct 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

situchan commented Oct 30, 2025

Uh oh!

trjExpensify commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

github-actions bot commented Oct 30, 2025

Uh oh!

dannymcclain commented Oct 30, 2025

Uh oh!

trjExpensify commented Oct 31, 2025

Uh oh!

daledah commented Oct 31, 2025

Uh oh!

situchan commented Oct 31, 2025

Uh oh!

situchan commented Oct 31, 2025

Uh oh!

dannymcclain commented Oct 31, 2025

daledah commented Oct 17, 2025 •

edited

Loading

codecov bot commented Oct 17, 2025 •

edited

Loading

situchan commented Oct 30, 2025 •

edited

Loading