Fix negative value behavior in IOURequestStepAmount after navigation#72871
Conversation
Codecov Report❌ Patch coverage is
... and 6 files with indirect coverage changes 🚀 New features to boost your workflow:
|
41ebabc to
da60bb0
Compare
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
da60bb0 to
339a568
Compare
|
@ZhenjaHorbach Please also check case mentioned in issue here #72156 (comment) 🙏 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridApp2025-10-30.13.50.07.movAndroid: mWeb Chrome2025-10-30.13.52.06.moviOS: HybridApp2025-10-30.13.44.27.moviOS: mWeb Safari2025-10-30.13.44.27.movMacOS: Chrome / Safari2025-10-30.13.31.29.movMacOS: Desktop2025-10-30.13.31.29.mov |
I didn't find any specific issue |
|
@LukasMod |
…to fix/negative-values-return-confirm-page
…callstack-internal/Expensify-App into fix/negative-values-return-confirm-page
|
@ZhenjaHorbach done |
|
LGTM! |
|
@lakchote |
Yeah sorry I thought I had merged it |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.43-0 🚀
|
|
🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.43-2 🚀
|
Explanation of Change
Set iouType to
CREATEwhen navigating toMONEY_REQUEST_CREATEor back fromMONEY_REQUEST_STEP_PARTICIPANTSFixed Issues
$ #72156
PROPOSAL:
Tests
Precondition:
Delete all workspaces.
Case with FAB actions
Case with FAB quick scan
In both cases, users should be able to add negative values at the start of the flow, as they can after moving back from the confirm screen.
Offline tests
QA Steps
Same as tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
android.native.mov
Android: mWeb Chrome
android.chrome.mov
iOS: Native
ios.native.mov
iOS: mWeb Safari
ios.safari.mov
MacOS: Chrome / Safari
https://github.com/user-attachments/assets/e7a6755e-2de9-4bd4-84dc-6a05e5560a18
https://github.com/user-attachments/assets/91337aea-428b-45e3-9a09-cd09152e28e6
MacOS: Desktop
desktop.mov