Skip to content

Fix negative value behavior in IOURequestStepAmount after navigation #72871

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lakchote merged 6 commits into from
Nov 3, 2025
Merged

Fix negative value behavior in IOURequestStepAmount after navigation #72871

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
339a568
Fix wrong iouType type when moving to startMoneyRequest
LukasMod Oct 20, 2025
a26cb4f
Add stricter condition
LukasMod Oct 20, 2025
99ccbe9
Fix wrong iouType type when moving to startMoneyRequest
LukasMod Oct 20, 2025
761e9ee
Add stricter condition
LukasMod Oct 20, 2025
898afad
Merge branch 'main' of github.com:callstack-internal/Expensify-App in…
LukasMod Oct 30, 2025
43001cd
Merge branch 'fix/negative-values-return-confirm-page' of github.com:…
LukasMod Oct 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/FloatingCameraButton/BaseFloatingCameraButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ function BaseFloatingCameraButton({icon}: BaseFloatingCameraButtonProps) {

const quickActionReportID = policyChatForActivePolicy?.reportID ?? reportID;
Tab.setSelectedTab(CONST.TAB.IOU_REQUEST_TYPE, CONST.IOU.REQUEST_TYPE.SCAN);
startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID, CONST.IOU.REQUEST_TYPE.SCAN, !!policyChatForActivePolicy?.reportID, undefined, allTransactionDrafts);
startMoneyRequest(CONST.IOU.TYPE.CREATE, quickActionReportID, CONST.IOU.REQUEST_TYPE.SCAN, !!policyChatForActivePolicy?.reportID, undefined, allTransactionDrafts);
});
};

Expand Down
2 changes: 1 addition & 1 deletion src/pages/home/sidebar/FloatingActionButtonAndPopover.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,7 +260,7 @@ function FloatingActionButtonAndPopover({onHideCreateMenu, onShowCreateMenu, ref

const quickActionReportID = policyChatForActivePolicy?.reportID ?? reportID;
Tab.setSelectedTab(CONST.TAB.IOU_REQUEST_TYPE, CONST.IOU.REQUEST_TYPE.SCAN);
startMoneyRequest(CONST.IOU.TYPE.SUBMIT, quickActionReportID, CONST.IOU.REQUEST_TYPE.SCAN, !!policyChatForActivePolicy?.reportID, undefined, allTransactionDrafts);
startMoneyRequest(CONST.IOU.TYPE.CREATE, quickActionReportID, CONST.IOU.REQUEST_TYPE.SCAN, !!policyChatForActivePolicy?.reportID, undefined, allTransactionDrafts);
});
}, [policyChatForActivePolicy?.policyID, policyChatForActivePolicy?.reportID, reportID, allTransactionDrafts]);

Expand Down
8 changes: 7 additions & 1 deletion src/pages/iou/request/step/IOURequestStepParticipants.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -357,7 +357,13 @@ function IOURequestStepParticipants({
Navigation.goBack(backTo);
return;
}
navigateToStartMoneyRequestStep(iouRequestType, iouType, initialTransactionID, reportID, action);

// Change iouType param to enable negative values
const shouldForceIOUType =
action === CONST.IOU.ACTION.CREATE && iouType === CONST.IOU.TYPE.SUBMIT && (iouRequestType === CONST.IOU.REQUEST_TYPE.MANUAL || iouRequestType === CONST.IOU.REQUEST_TYPE.SCAN);
const iouTypeValue = shouldForceIOUType ? CONST.IOU.TYPE.CREATE : iouType;

navigateToStartMoneyRequestStep(iouRequestType, iouTypeValue, initialTransactionID, reportID, action);
}, [backTo, iouRequestType, iouType, initialTransactionID, reportID, action]);

useEffect(() => {
Expand Down
Loading