Fix tax updating for changing waypoints or currency by roryabraham · Pull Request #73045 · Expensify/App

roryabraham · 2025-10-21T01:51:22Z

Explanation of Change

Due to excessive and incorrect value-diffing with usePrevious, tax rates are not being correctly updated when parameters (such as the waypoints for a distance expense) change.

Fixed Issues

$ #72380

Tests / QA Steps

Prerequisites

Create a workspace
Enable tax and distance rates
Set up two tax rates:
1. A default for the workspace currency default (USD)
2. A different default for foreign currencies
Go to workspace settings -> distance rates -> settings -> enable tax tracking

Test changing waypoints

Click on the global create button -> track distance
Enter two waypoints
Click next
Observe the tax amount
Click back
Change one of the waypoints
Click next
Verify the tax amount updated in accordance with the new waypoints

Test changing currency

Click on the global create expense button
Enter a $20USD expense
Verify that the workspace default tax rate is applied
Click back
Change the currency to a different currency
Verify that the foreign currency tax rate is applied

Verify that no errors appear in the JS console

Offline tests

None.

QA Steps

Same as tests.

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

melvin-bot · 2025-10-21T01:53:54Z

@Gonals Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

github-actions · 2025-10-21T01:55:01Z

src/components/MoneyRequestConfirmationList.tsx

+        if (defaultTaxCode !== currentTaxCode) {
+            setMoneyRequestTaxRate(transactionID, defaultTaxCode ?? '');
+        }
+    }, [customUnitRateID, policy, shouldShowTax, transaction, transactionID]);


❌ PERF-6 (docs)

Instead of passing entire objects as dependencies, specify individual object properties to create more granular dependency tracking and reduce unnecessary hook executions.

}, [customUnitRateID, policy, shouldShowTax, transaction?.taxCode, transaction?.currency, transaction?.modifiedCurrency, transactionID]);

This suggestion is not correct as written. In theory I agree with the principle, but in practice there are a bunch of transaction fields used within this effect, and while I could enumerate them all, it would make the effect more brittle - changing one of the TransactionUtils functions to use an additional property would result in the effect not being re-run when it needs to.

This is the kind of thing React Compiler could probably memoize much more effectively than we could manually, because it could deeply analyze the usage of all variables in your function scope and apply the kind of granular memoization that this comment strives for, but can do it reliably at build time.

github-actions · 2025-10-21T01:55:08Z

src/components/MoneyRequestConfirmationList.tsx

-        previousTaxCode,
-        distance,
-    ]);
+    }, [policy, shouldShowTax, transaction, isDistanceRequest, customUnitRateID, distance]);


❌ PERF-6 (docs)

Instead of passing entire objects as dependencies, specify individual object properties to create more granular dependency tracking and reduce unnecessary hook executions.

}, [policy, shouldShowTax, transaction?.amount, transaction?.taxAmount, transaction?.taxCode, transaction?.currency, transaction?.transactionID, isDistanceRequest, customUnitRateID, distance]);

codecov · 2025-10-21T02:03:27Z

Codecov Report

❌ Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/components/MoneyRequestConfirmationList.tsx	28.57%	5 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/MoneyRequestConfirmationList.tsx	`51.11% <28.57%> (+0.27%)`	⬆️

... and 9 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Burhan-Rashid · 2025-10-21T11:27:31Z

@roryabraham there is a regression with these changes.
When the user goes back from the confirmation page to the amount selection page changes the currency to some non-default currency and proceeds to the confirmation page, the tax code that is seen on the confirmation page doesn't reflect the foreign currency default tax code, instead it still shows the previous tax code.

taxcodeissuechanges.mp4

roryabraham · 2025-10-22T00:17:06Z

@Burhan-Rashid I'm not able to reproduce that regression on this branch. It is explicitly covered by the test/QA steps and the video I included in the PR description shows that the bug you describe is not present.

github-actions · 2025-10-22T00:21:40Z

LGTM . Thank you for your hard work!

Burhan-Rashid · 2025-10-22T02:15:49Z

@Burhan-Rashid I'm not able to reproduce that regression on this branch. It is explicitly covered by the test/QA steps and the video I included in the PR description shows that the bug you describe is not present.

I think there might have been some cache related issue on my local. I am also not able to reproduce it currently. Sorry for the inconvenience.

roryabraham · 2025-10-22T05:44:50Z

No worries - thank you for your diligence in testing 😄

jjcoffee · 2025-10-22T12:40:38Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

android-app-2025-10-22_16.30.53.mp4

Android: mWeb Chrome

android-chrome-2025-10-22_16.25.46.mp4

iOS: HybridApp

ios-app-2025-10-22_18.22.24.mp4

iOS: mWeb Safari

ios-safari-2025-10-22_18.26.17.mp4

MacOS: Chrome / Safari

desktop-chrome-2025-10-22_14.35.50.mp4

MacOS: Desktop

desktop-app-2025-10-22_15.12.18.mp4

jjcoffee

LGTM! Tests well and is much cleaner like this, thanks for stepping in!

melvin-bot · 2025-10-22T16:29:12Z

@luacmartins Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

luacmartins

LGTM

OSBotify · 2025-10-22T18:32:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-23T13:10:50Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.37-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…aypoints" This reverts commit 63e72de, reversing changes made to 001dd99.

OSBotify · 2025-10-24T17:53:01Z

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

roryabraham added 2 commits October 20, 2025 18:33

Remove usePrevious tracking to fix waypoints not updating tax

0459a32

Fix manual currency change case too

13021fa

roryabraham self-assigned this Oct 21, 2025

roryabraham requested a review from jjcoffee October 21, 2025 01:53

roryabraham marked this pull request as ready for review October 21, 2025 01:53

roryabraham requested a review from a team as a code owner October 21, 2025 01:53

roryabraham mentioned this pull request Oct 21, 2025

[Due for payment 2025-10-31] [$250] Expense - In confirm page, tax amount not updated accordingly to new waypoints selected #72380

Closed

8 tasks

melvin-bot bot requested review from Gonals and removed request for a team October 21, 2025 01:53

github-actions bot reviewed Oct 21, 2025

View reviewed changes

Merge branch 'main' into Rory-TaxUpdatingForWaypoints

47c93ba

jjcoffee approved these changes Oct 22, 2025

View reviewed changes

melvin-bot bot requested a review from luacmartins October 22, 2025 16:29

luacmartins approved these changes Oct 22, 2025

View reviewed changes

luacmartins merged commit 63e72de into main Oct 22, 2025
29 checks passed

luacmartins deleted the Rory-TaxUpdatingForWaypoints branch October 22, 2025 18:19

OSBotify mentioned this pull request Oct 23, 2025

Deploy Checklist: New Expensify 2025-10-23 #73307

Closed

88 tasks

jponikarchuk mentioned this pull request Oct 23, 2025

[Due for payment 2025-11-03] Expense - Unable to change tax rate and tax amount on confirm page #73309

Closed

8 tasks

blimpich mentioned this pull request Oct 23, 2025

Revert "Fix tax updating for changing waypoints or currency" #73352

Closed

blimpich added a commit that referenced this pull request Oct 24, 2025

Revert "Merge pull request #73045 from Expensify/Rory-TaxUpdatingForW…

2e46e2d

…aypoints" This reverts commit 63e72de, reversing changes made to 001dd99.

blimpich mentioned this pull request Oct 24, 2025

Revert 3 tax related PRs #73443

Closed

54 tasks

jjcoffee mentioned this pull request Oct 28, 2025

Add useEffect to select default tax code #43519

Merged

50 tasks

Conversation

roryabraham commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests / QA Steps

Prerequisites

Test changing waypoints

Test changing currency

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Oct 21, 2025

Uh oh!

github-actions bot Oct 21, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

roryabraham Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions bot Oct 21, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Burhan-Rashid commented Oct 21, 2025

Uh oh!

roryabraham commented Oct 22, 2025

Uh oh!

github-actions bot commented Oct 22, 2025

Uh oh!

Burhan-Rashid commented Oct 22, 2025

Uh oh!

roryabraham commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jjcoffee commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

jjcoffee left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Oct 22, 2025

Uh oh!

luacmartins left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 22, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

OSBotify commented Oct 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

roryabraham commented Oct 21, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited

Loading

roryabraham commented Oct 22, 2025 •

edited

Loading

jjcoffee commented Oct 22, 2025 •

edited

Loading