Revert "Fix tax updating for changing waypoints or currency"#73352
Revert "Fix tax updating for changing waypoints or currency"#73352
Conversation
|
@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
| } | ||
| }, [customUnitRateID, policy, shouldShowTax, transaction, transactionID]); | ||
| setMoneyRequestTaxRate(transactionID, defaultTaxCode ?? ''); | ||
| }, [customUnitRateID, policy, previousCustomUnitRateID, previousTransactionCurrency, previousTransactionModifiedCurrency, shouldShowTax, transaction, transactionID]); |
There was a problem hiding this comment.
❌ PERF-6 (docs)
In useEffect, useMemo, and useCallback, specify individual object properties as dependencies instead of passing entire objects.
Replace the transaction dependency with its specific properties that are actually used:
}, [customUnitRateID, policy, previousCustomUnitRateID, previousTransactionCurrency, previousTransactionModifiedCurrency, shouldShowTax, transaction?.taxCode, transactionID]);| previousCustomUnitRateID, | ||
| previousTaxCode, | ||
| distance, | ||
| ]); |
There was a problem hiding this comment.
❌ PERF-6 (docs)
In useEffect, useMemo, and useCallback, specify individual object properties as dependencies instead of passing entire objects.
Replace the transaction dependency with its specific properties that are actually used in this effect:
}, [
policy,
shouldShowTax,
previousTransactionAmount,
previousTransactionCurrency,
transaction?.amount,
transaction?.currency,
transaction?.taxCode,
transaction?.taxAmount,
transaction?.transactionID,
isDistanceRequest,
customUnitRateID,
previousCustomUnitRateID,
previousTaxCode,
distance,
]);
Codecov Report❌ Patch coverage is
... and 11 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Reverts #73045