Skip to content

Revert "Fix tax updating for changing waypoints or currency"#73352

Closed
blimpich wants to merge 1 commit intomainfrom
revert-73045-Rory-TaxUpdatingForWaypoints
Closed

Revert "Fix tax updating for changing waypoints or currency"#73352
blimpich wants to merge 1 commit intomainfrom
revert-73045-Rory-TaxUpdatingForWaypoints

Conversation

@blimpich
Copy link
Contributor

Reverts #73045

@blimpich blimpich self-assigned this Oct 23, 2025
@blimpich blimpich requested a review from a team as a code owner October 23, 2025 19:44
@melvin-bot melvin-bot bot requested review from srikarparsi and removed request for a team October 23, 2025 19:45
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2025

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

}
}, [customUnitRateID, policy, shouldShowTax, transaction, transactionID]);
setMoneyRequestTaxRate(transactionID, defaultTaxCode ?? '');
}, [customUnitRateID, policy, previousCustomUnitRateID, previousTransactionCurrency, previousTransactionModifiedCurrency, shouldShowTax, transaction, transactionID]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ PERF-6 (docs)

In useEffect, useMemo, and useCallback, specify individual object properties as dependencies instead of passing entire objects.

Replace the transaction dependency with its specific properties that are actually used:

}, [customUnitRateID, policy, previousCustomUnitRateID, previousTransactionCurrency, previousTransactionModifiedCurrency, shouldShowTax, transaction?.taxCode, transactionID]);

previousCustomUnitRateID,
previousTaxCode,
distance,
]);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ PERF-6 (docs)

In useEffect, useMemo, and useCallback, specify individual object properties as dependencies instead of passing entire objects.

Replace the transaction dependency with its specific properties that are actually used in this effect:

    }, [
        policy,
        shouldShowTax,
        previousTransactionAmount,
        previousTransactionCurrency,
        transaction?.amount,
        transaction?.currency,
        transaction?.taxCode,
        transaction?.taxAmount,
        transaction?.transactionID,
        isDistanceRequest,
        customUnitRateID,
        previousCustomUnitRateID,
        previousTaxCode,
        distance,
    ]);

@codecov
Copy link

codecov bot commented Oct 23, 2025

Codecov Report

❌ Patch coverage is 39.13043% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/MoneyRequestConfirmationList.tsx 39.13% 14 Missing ⚠️
Files with missing lines Coverage Δ
src/components/MoneyRequestConfirmationList.tsx 50.83% <39.13%> (-0.28%) ⬇️

... and 11 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blimpich blimpich closed this Oct 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant