Expense-In offline, Try it out button is not responsive in scan expense flow by lorretheboy · Pull Request #73055 · Expensify/App

lorretheboy · 2025-10-21T04:13:31Z

Explanation of Change

Fixed Issues

$ #72881
PROPOSAL: #72881 (comment)

Tests

Go to ND
Login with new account
Go offline
Click plus icon - Create expense - Scan
Verify that

scan test tooltip does not appear (mWeb + desktop + web)
scan test tooltip works well (ios + android)
Verify that no errors appear in the JS console

Offline tests

QA Steps

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

ANDROID.mov

Android: mWeb Chrome

WEBSITE.ANDROID.mov

iOS: Native

IOS.mov

iOS: mWeb Safari

WEBSITE.IOS.mov

MacOS: Chrome / Safari

WEBSITE.mov

MacOS: Desktop

DESKTOP.mov

codecov · 2025-10-21T04:25:44Z

Codecov Report

❌ Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/pages/iou/request/IOURequestStartPage.tsx	75.00%	1 Missing ⚠️

Files with missing lines	Coverage Δ
src/pages/iou/request/IOURequestStartPage.tsx	`85.91% <75.00%> (-0.85%)`	⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-21T04:31:49Z

@dominictb Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

dominictb · 2025-10-21T07:19:26Z

src/components/ProductTrainingContext/index.tsx

+        const platform = getPlatform();
+        const isNonNativePlatform = platform === CONST.PLATFORM.WEB || platform === CONST.PLATFORM.DESKTOP || platform === CONST.PLATFORM.MOBILE_WEB;
+        if (isNonNativePlatform && isOffline && tooltipName === CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP) {
+            return false;
+        }


Let's do this in IOURequestStartPage as I suggested before #72881 (comment)

And add a brief comment explaining the changes:

The test receipt image is served via our server on web so it requires internet connection

dominictb · 2025-10-21T07:23:56Z

src/components/ProductTrainingContext/index.tsx

+        const platform = getPlatform();
+        const isNonNativePlatform = platform === CONST.PLATFORM.WEB || platform === CONST.PLATFORM.DESKTOP || platform === CONST.PLATFORM.MOBILE_WEB;


Move this out of the component like this one

I meant to the top level of IOURequestStartPage file, not to a separate util function

dominictb · 2025-10-21T07:26:30Z

src/components/ProductTrainingContext/index.tsx


    const shouldShowProductTrainingTooltip = useMemo(() => {
+        const platform = getPlatform();
+        const isNonNativePlatform = platform === CONST.PLATFORM.WEB || platform === CONST.PLATFORM.DESKTOP || platform === CONST.PLATFORM.MOBILE_WEB;


Suggested change

const isNonNativePlatform = platform === CONST.PLATFORM.WEB || platform === CONST.PLATFORM.DESKTOP || platform === CONST.PLATFORM.MOBILE_WEB;

const isWeb = [CONST.PLATFORM.WEB, CONST.PLATFORM.DESKTOP, CONST.PLATFORM.MOBILE_WEB].includes(platform);

lorretheboy · 2025-10-21T18:26:31Z

@dominictb please check again. Thx

dominictb · 2025-10-22T10:55:47Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-22.at.18.03.04.mov

Android: mWeb Chrome

Screen.Recording.2025-10-22.at.18.05.20.mov

iOS: HybridApp

Screen.Recording.2025-10-22.at.17.46.43.mov

iOS: mWeb Safari

Screen.Recording.2025-10-22.at.17.57.06.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-22.at.17.36.16.mov

MacOS: Desktop

Screen.Recording.2025-10-22.at.17.44.08-compressed.mov

dominictb

LGTM 🎀

dominictb · 2025-10-29T11:48:42Z

Bump @chuckdries

@lorretheboy Can you merge main?

dominictb · 2025-11-05T10:02:24Z

@lorretheboy Can you merge main? I'll ask for someone else to review this PR.

chuckdries

Looks good! Sorry for the delay on reviewing, I was out of office

lorretheboy · 2025-11-06T16:38:03Z

Sorry all, I missed the ping ^. Just merged main. Please check again. Thanks

melvin-bot · 2025-11-06T17:02:25Z

@chuckdries looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

chuckdries · 2025-11-06T17:03:51Z

The button was green :///

OSBotify · 2025-11-06T23:51:10Z

🚀 Deployed to staging by https://github.com/chuckdries in version: 9.2.46-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-07T23:31:17Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

fix: hide scan test tooltip in offline

2a42737

melvin-bot bot assigned lorretheboy Oct 21, 2025

lorretheboy changed the title ~~fix: hide scan test tooltip in offline~~ Expense-In offline, Try it out button is not responsive in scan expense flow Oct 21, 2025

lorretheboy marked this pull request as ready for review October 21, 2025 04:31

lorretheboy requested a review from a team as a code owner October 21, 2025 04:31

melvin-bot bot requested a review from dominictb October 21, 2025 04:31

melvin-bot bot removed the request for review from a team October 21, 2025 04:31

lorretheboy mentioned this pull request Oct 21, 2025

[$250] Expense-In offline, Try it out button is not responsive in scan expense flow. #72881

Closed

8 tasks

dominictb suggested changes Oct 21, 2025

View reviewed changes

lorretheboy added 5 commits October 22, 2025 01:12

Merge branch 'main' of https://github.com/Expensify/App into fix/72881

1d33635

fix: refactoring code

cd81844

fix: refactoring code

f151f9c

fix: lint

1687dc8

fix: type

6b57da6

dominictb approved these changes Oct 22, 2025

View reviewed changes

melvin-bot bot requested a review from chuckdries October 22, 2025 11:06

chuckdries previously approved these changes Nov 6, 2025

View reviewed changes

resolve conflicts

e1e578f

lorretheboy dismissed chuckdries’s stale review via e1e578f November 6, 2025 16:37

lorretheboy requested a review from a team as a code owner November 6, 2025 16:37

melvin-bot bot requested review from heyjennahay and removed request for a team November 6, 2025 16:37

chuckdries approved these changes Nov 6, 2025

View reviewed changes

chuckdries merged commit ebb4255 into Expensify:main Nov 6, 2025
40 of 48 checks passed

melvin-bot bot added the Emergency label Nov 6, 2025

chuckdries removed the Emergency label Nov 6, 2025

OSBotify mentioned this pull request Nov 6, 2025

Deploy Checklist: New Expensify 2025-11-06 #74515

Closed

64 tasks

		const platform = getPlatform();
		const isNonNativePlatform = platform === CONST.PLATFORM.WEB \|\| platform === CONST.PLATFORM.DESKTOP \|\| platform === CONST.PLATFORM.MOBILE_WEB;

	const isNonNativePlatform = platform === CONST.PLATFORM.WEB \|\| platform === CONST.PLATFORM.DESKTOP \|\| platform === CONST.PLATFORM.MOBILE_WEB;
	const isWeb = [CONST.PLATFORM.WEB, CONST.PLATFORM.DESKTOP, CONST.PLATFORM.MOBILE_WEB].includes(platform);

Conversation

lorretheboy commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 21, 2025

Uh oh!

dominictb Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Oct 21, 2025

Choose a reason for hiding this comment

Uh oh!

dominictb Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dominictb Oct 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

lorretheboy commented Oct 21, 2025

Uh oh!

dominictb commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

dominictb left a comment

Choose a reason for hiding this comment

Uh oh!

dominictb commented Oct 29, 2025

Uh oh!

dominictb commented Nov 5, 2025

Uh oh!

chuckdries left a comment

Choose a reason for hiding this comment

Uh oh!

lorretheboy commented Nov 6, 2025

Uh oh!

Uh oh!

melvin-bot bot commented Nov 6, 2025

Uh oh!

chuckdries commented Nov 6, 2025

Uh oh!

OSBotify commented Nov 6, 2025

Uh oh!

OSBotify commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

lorretheboy commented Oct 21, 2025 •

edited

Loading

codecov bot commented Oct 21, 2025 •

edited

Loading

dominictb Oct 21, 2025 •

edited

Loading

dominictb Oct 21, 2025 •

edited

Loading

dominictb commented Oct 22, 2025 •

edited

Loading