Skip to content

Expense-In offline, Try it out button is not responsive in scan expense flow #73055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chuckdries merged 7 commits into from
Nov 6, 2025
Merged

Expense-In offline, Try it out button is not responsive in scan expense flow #73055

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
2a42737
fix: hide scan test tooltip in offline
lorretheboy Oct 21, 2025
1d33635
Merge branch 'main' of https://github.com/Expensify/App into fix/72881
lorretheboy Oct 21, 2025
cd81844
fix: refactoring code
lorretheboy Oct 21, 2025
f151f9c
fix: refactoring code
lorretheboy Oct 21, 2025
1687dc8
fix: lint
lorretheboy Oct 21, 2025
6b57da6
fix: type
lorretheboy Oct 21, 2025
e1e578f
resolve conflicts
lorretheboy Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/pages/iou/request/IOURequestStartPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import TabSelector from '@components/TabSelector/TabSelector';
import useCurrentUserPersonalDetails from '@hooks/useCurrentUserPersonalDetails';
import useHandleBackButton from '@hooks/useHandleBackButton';
import useLocalize from '@hooks/useLocalize';
import useNetwork from '@hooks/useNetwork';
import useOnyx from '@hooks/useOnyx';
import usePermissions from '@hooks/usePermissions';
import usePolicy from '@hooks/usePolicy';
Expand All @@ -20,6 +21,8 @@ import {dismissProductTraining} from '@libs/actions/Welcome';
import {isMobile} from '@libs/Browser';
import {canUseTouchScreen} from '@libs/DeviceCapabilities';
import getNonEmptyStringOnyxID from '@libs/getNonEmptyStringOnyxID';
import getPlatform from '@libs/getPlatform';
import type Platform from '@libs/getPlatform/types';
import Navigation from '@libs/Navigation/Navigation';
import OnyxTabNavigator, {TabScreenWithFocusTrapWrapper, TopTab} from '@libs/Navigation/OnyxTabNavigator';
import {getIsUserSubmittedExpenseOrScannedReceipt} from '@libs/OptionsListUtils';
Expand All @@ -46,6 +49,9 @@ type IOURequestStartPageProps = WithWritableReportOrNotFoundProps<typeof SCREENS
defaultSelectedTab: SelectedTabRequest;
};

const platform = getPlatform(true);
const isWeb = ([CONST.PLATFORM.WEB, CONST.PLATFORM.DESKTOP, CONST.PLATFORM.MOBILE_WEB] as Platform[]).includes(platform);

function IOURequestStartPage({
route,
route: {
Expand Down Expand Up @@ -73,6 +79,7 @@ function IOURequestStartPage({
});
const [isMultiScanEnabled, setIsMultiScanEnabled] = useState((optimisticTransactions ?? []).length > 1);
const [currentDate] = useOnyx(ONYXKEYS.CURRENT_DATE, {canBeMissing: true});
const {isOffline} = useNetwork();
const [nvpDismissedProductTraining] = useOnyx(ONYXKEYS.NVP_DISMISSED_PRODUCT_TRAINING, {canBeMissing: true});

const tabTitles = {
Expand Down Expand Up @@ -185,7 +192,11 @@ function IOURequestStartPage({
const setTestReceiptAndNavigateRef = useRef<() => void>(() => {});
const {shouldShowProductTrainingTooltip, renderProductTrainingTooltip} = useProductTrainingContext(
CONST.PRODUCT_TRAINING_TOOLTIP_NAMES.SCAN_TEST_TOOLTIP,
!getIsUserSubmittedExpenseOrScannedReceipt(nvpDismissedProductTraining) && isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) && selectedTab === CONST.TAB_REQUEST.SCAN,
// The test receipt image is served via our server on web so it requires internet connection
!getIsUserSubmittedExpenseOrScannedReceipt(nvpDismissedProductTraining) &&
isBetaEnabled(CONST.BETAS.NEWDOT_MANAGER_MCTEST) &&
selectedTab === CONST.TAB_REQUEST.SCAN &&
!(isOffline && isWeb),
{
onConfirm: () => {
setTestReceiptAndNavigateRef?.current?.();
Expand Down
Loading