Skip to content

Revert "[No QA] Fix autofocus after hiding side panel v2"#73171

Closed
situchan wants to merge 1 commit intoExpensify:mainfrom
situchan:revert-71788-fix/autofocus-after-hiding-side-panel-v2
Closed

Revert "[No QA] Fix autofocus after hiding side panel v2"#73171
situchan wants to merge 1 commit intoExpensify:mainfrom
situchan:revert-71788-fix/autofocus-after-hiding-side-panel-v2

Conversation

@situchan
Copy link
Copy Markdown
Contributor

Reverts #71788 to fix #73169

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 22, 2025

Codecov Report

❌ Patch coverage is 57.14286% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Modal/ReanimatedModal/index.tsx 33.33% 2 Missing ⚠️
src/components/Modal/BaseModal.tsx 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/hooks/useAutoFocusInput.ts 83.33% <100.00%> (-8.98%) ⬇️
src/components/Modal/BaseModal.tsx 85.12% <50.00%> (-0.71%) ⬇️
src/components/Modal/ReanimatedModal/index.tsx 88.33% <33.33%> (+2.22%) ⬆️

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@carlosmiceli
Copy link
Copy Markdown
Contributor

Let's hold on this revert and see if #73229 fixes the issue.

@situchan
Copy link
Copy Markdown
Contributor Author

@carlosmiceli I tested locally. That PR fixes the regression. It's just partial revert.

@situchan situchan closed this Oct 24, 2025
@situchan situchan deleted the revert-71788-fix/autofocus-after-hiding-side-panel-v2 branch October 24, 2025 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Due for payment 2025-10-31] [Due for payment 2025-10-30] iOS- Attachment - Nothing happen when tapping on Add Attachment

2 participants