[No QA] Fix autofocus after hiding side panel v2 by jmusial · Pull Request #71788 · Expensify/App

jmusial · 2025-10-02T16:22:18Z

Explanation of Change

This is a second version of side panel focus fix after a revert of #70097.

[No QA] because help panel is hidden in a way that makes QA testing impossible.

Root cause

Rewriting useSidePanel into context exposed underlying issue with flags timing in useAutofocusInput.

The right combination of shouldHideSidePanel, prevShouldHideSidePanel and isSidePanelTransitionEnded wasn't happening at the same time (Before it was because the default values int the hook).

Difference in approach from the previous reverted PR & current

removed prevShouldHideSidePanel, which caused side effects in other parts of the app

Current:

Added state that will 'wait' after side panel is hidden (shouldHideSidePanel === true && prevShouldHideSidePanel === false) till the animation finishes and isSidePanelTransitionEnded === true
Moved onDismiss logic to be consistent across platforms. When testing it proved unreliable in the previous form. I consider this a low risk change since we were only using it internally between BaseModal and ReanimatedModal

Fixed Issues

$ #69766

PROPOSAL:

N/A

Tests

Pre requisite:
Account that had side panel enabled before
Revert this PR

Open the app
Open Acount -> Status page
Focus text input if not focused
Click the Help button to open the side panel.
Close side panel
After closing the side panel, the text input should automatically regain focus.

Retest of #70625

Go to workspace settings - company cards
Tap next - American express -next
In Delivery file name input field focus is shown so keypad also must be shown.

Offline tests

N/A

QA Steps

N/A

PR Author Checklist

Screenshots/Videos

Android: Native

0050.android.native.mov

Android: mWeb Chrome

0050.android.chrome.mov

iOS: Native

0050.ios.native.mov

iOS: mWeb Safari

0050.ios.safari.mov

MacOS: Chrome / Safari

0050.desktop.chrome.mov

MacOS: Desktop

0050.desktop.native.mov

codecov · 2025-10-02T16:43:18Z

Codecov Report

❌ Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
src/hooks/useAutoFocusInput.ts	80.00%	0 Missing and 1 partial ⚠️

Files with missing lines	Coverage Δ
src/components/Modal/BaseModal.tsx	`85.83% <100.00%> (+0.70%)`	⬆️
src/components/Modal/ReanimatedModal/index.tsx	`86.11% <ø> (-0.38%)`	⬇️
src/hooks/useAutoFocusInput.ts	`92.30% <80.00%> (-7.70%)`	⬇️

... and 72 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

melvin-bot · 2025-10-02T16:44:09Z

@hoangzinh Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

hoangzinh · 2025-10-03T10:26:07Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-10-21.at.22.54.56.android.mov

Android: mWeb Chrome

Screen.Recording.2025-10-21.at.22.50.34.android.chrome.mov

iOS: HybridApp

Screen.Recording.2025-10-21.at.23.05.07.ios.mov

iOS: mWeb Safari

Screen.Recording.2025-10-21.at.22.57.00.ios.safari.mov

MacOS: Chrome / Safari

Screen.Recording.2025-10-21.at.22.45.05.web.mov

MacOS: Desktop

Screen.Recording.2025-10-21.at.22.47.50.desktop.mov

hoangzinh · 2025-10-07T23:30:39Z

src/hooks/useAutoFocusInput.ts

    // Trigger focus when Side Panel transition ends
    const {isSidePanelTransitionEnded, shouldHideSidePanel} = useSidePanel();
    const prevShouldHideSidePanel = usePrevious(shouldHideSidePanel);
+    const wasSidePanelClosed = useRef(false);


Hi @jmusial, does it still work if we use useState here?

hoangzinh · 2025-10-07T23:35:47Z

src/components/Modal/ReanimatedModal/index.tsx

-        if (getPlatform() === CONST.PLATFORM.ANDROID) {
-            onModalHide();
-        }
+        onModalHide();


There is a PR, which is reverted here #71568, which has the same approach. Can you check if it also causes the same deploy blocker if we go with this approach?

#71760 (comment)

From the convo there it seems like this wasn't the issue, but nonetheless will check later today

Ok there is no clear DB mention but from this comment I assume this was the issue #71542

On IOS with repro steps:

Open app

Go to any conversation or workspace chat

Tap on + button

Tap on Add attachment

Expected Result:
5. Option list for add attachment should display

Video:

Simulator.Screen.Recording.-.iPhone.15.Pro.-.2025-10-08.at.11.01.39.mov

The above bug happened again and caused deploy blocker:
#73169

We should be very careful and do thorough testing as modal is used everywhere throughout the app.

hoangzinh · 2025-10-12T09:04:20Z

Hi @jmusial can you check my feedback here? Besides that, can you briefly explain new approach to fix issues (root cause and solution)? Thank you.

jmusial · 2025-10-14T08:14:10Z

hey @hoangzinh will do. Just I got swamped a bit with other (higher prio) tasks. Will try to do it tomorrow.

jmusial · 2025-10-16T08:17:45Z

@hoangzinh Updated the PR description with more detailed issue description

hoangzinh · 2025-10-18T08:32:11Z

@jmusial do you know how to open sidepanel currently? I tried to trigger Onyx.set('nvp_sidePanel', { open: true }) but it doesn't work

jmusial · 2025-10-20T10:46:49Z

@jmusial do you know how to open sidepanel currently? I tried to trigger Onyx.set('nvp_sidePanel', { open: true }) but it doesn't work

I'm using this

Account that had side panel enabled before
Revert Remove all code that sets side panel NVP #70543

hoangzinh

LGTM

carlosmiceli · 2025-10-21T16:24:58Z

Closed and reopened to run the last workflow.

OSBotify · 2025-10-21T16:40:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-21T23:29:24Z

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.36-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mallenexpensify · 2025-10-22T21:08:14Z

Looks like this caused a regression

[Due for payment 2025-10-31] [Due for payment 2025-10-30] iOS- Attachment - Nothing happen when tapping on Add Attachment #73169 (comment)

OSBotify · 2025-10-23T12:44:07Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.36-7 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix autofocus after hiding side panel

d7fdb1d

melvin-bot bot assigned jmusial Oct 2, 2025

prettier fix

899e613

jmusial changed the title ~~Fix autofocus after hiding side panel v2~~ [No QA] Fix autofocus after hiding side panel v2 Oct 2, 2025

jmusial marked this pull request as ready for review October 2, 2025 16:44

jmusial requested a review from a team as a code owner October 2, 2025 16:44

melvin-bot bot requested a review from hoangzinh October 2, 2025 16:44

melvin-bot bot removed the request for review from a team October 2, 2025 16:44

hoangzinh reviewed Oct 7, 2025

View reviewed changes

Merge branch 'main' into fix/autofocus-after-hiding-side-panel-v2

74420df

jmusial added 2 commits October 15, 2025 17:18

Merge branch 'main' into fix/autofocus-after-hiding-side-panel-v2

6c92ae3

useState instead of useRef

c70fa24

hoangzinh approved these changes Oct 21, 2025

View reviewed changes

melvin-bot bot requested a review from carlosmiceli October 21, 2025 16:08

carlosmiceli closed this Oct 21, 2025

carlosmiceli reopened this Oct 21, 2025

carlosmiceli approved these changes Oct 21, 2025

View reviewed changes

carlosmiceli merged commit a92f71d into Expensify:main Oct 21, 2025
28 of 29 checks passed

OSBotify mentioned this pull request Oct 21, 2025

Deploy Checklist: New Expensify 2025-10-21 #73157

Closed

57 tasks

This was referenced Oct 22, 2025

Revert "[No QA] Fix autofocus after hiding side panel v2" #73171

Closed

[Due for payment 2025-10-31] [Due for payment 2025-10-30] iOS- Attachment - Nothing happen when tapping on Add Attachment #73169

Closed

jmusial mentioned this pull request Oct 22, 2025

[CP Staging] Revert onDismiss removal #73229

Merged

52 tasks

situchan mentioned this pull request Oct 22, 2025

[Due for payment 2025-12-23] [$250] Status - Cursor overlaps with text after adding an emoji #72648

Closed

8 tasks

melvin-bot bot mentioned this pull request Oct 23, 2025

[Due for payment 2025-10-30] [$250] Profile - Status - The text input is not focused after closing side panel #69766

Closed

16 tasks

Conversation

jmusial commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Root cause

Difference in approach from the previous reverted PR & current

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Oct 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Oct 2, 2025

Uh oh!

hoangzinh commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

hoangzinh Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 16, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh Oct 7, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 8, 2025

Choose a reason for hiding this comment

Uh oh!

jmusial Oct 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

situchan Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

hoangzinh commented Oct 12, 2025

Uh oh!

jmusial commented Oct 14, 2025

Uh oh!

jmusial commented Oct 16, 2025

Uh oh!

hoangzinh commented Oct 18, 2025

Uh oh!

jmusial commented Oct 20, 2025

Uh oh!

hoangzinh left a comment

Choose a reason for hiding this comment

Uh oh!

carlosmiceli commented Oct 21, 2025

Uh oh!

Uh oh!

OSBotify commented Oct 21, 2025

Uh oh!

OSBotify commented Oct 21, 2025

Uh oh!

mallenexpensify commented Oct 22, 2025

Uh oh!

OSBotify commented Oct 23, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

jmusial commented Oct 2, 2025 •

edited

Loading

codecov bot commented Oct 2, 2025 •

edited

Loading

hoangzinh commented Oct 3, 2025 •

edited

Loading

jmusial Oct 8, 2025 •

edited

Loading