fix: Split input field is not aligned on the right on confirm page#73228
Merged
marcaaron merged 2 commits intoExpensify:mainfrom Oct 23, 2025
Merged
fix: Split input field is not aligned on the right on confirm page#73228marcaaron merged 2 commits intoExpensify:mainfrom
marcaaron merged 2 commits intoExpensify:mainfrom
Conversation
|
@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Patch coverage is
... and 8 files with indirect coverage changes 🚀 New features to boost your workflow:
|
Contributor
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-10-23.at.19.49.51.movAndroid: mWeb ChromeScreen.Recording.2025-10-23.at.19.52.51.moviOS: HybridAppUploading Screen Recording 2025-10-23 at 19.36.35.mov… iOS: mWeb SafariScreen.Recording.2025-10-23.at.19.45.22.movMacOS: Chrome / SafariScreen.Recording.2025-10-23.at.19.33.58.movMacOS: DesktopScreen.Recording.2025-10-23.at.19.55.39.mov |
linhvovan29546
approved these changes
Oct 23, 2025
marcaaron
approved these changes
Oct 23, 2025
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
71 tasks
Contributor
|
🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.38-0 🚀
|
Contributor
|
🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀
|
16 tasks
54 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation of Change
fix: Split input field is not aligned on the right on confirm page
Fixed Issues
$ #72140
PROPOSAL: #72140 (comment)
Tests
Offline tests
Same
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-10-22.at.21.55.39.mov
Android: mWeb Chrome
Screen.Recording.2025-10-22.at.21.54.14.mov
iOS: Native
Screen.Recording.2025-10-22.at.21.57.35.mov
iOS: mWeb Safari
Screen.Recording.2025-10-22.at.21.58.12.mov
MacOS: Chrome / Safari
Screen.Recording.2025-10-22.at.21.53.45.mov
MacOS: Desktop
Screen.Recording.2025-10-22.at.22.02.20.mov