Reapply "Merge pull request #56092 from callstack-internal/feature/al… by pasyukevich · Pull Request #65001 · Expensify/App

pasyukevich · 2025-06-26T11:06:22Z

…low-negative"

This reverts commit e3255ba.

Re-apply changes of reverted PR: $#56092

Regressions reported previous time:
$ #65147
$ #64851
$ #64853
$ #64855
$ #64856
$ #64857
$ #64863
$ #64868
$ #64870
$ #64872
$ #64874
$ #64876
$ #64880
$ #64896
$ #64927
$ #64964
$ #71012

Explanation of Change

Fixed Issues

$ #53441
PROPOSAL:

Tests

📱 Mobile

1️⃣ Verify negative expense can be created without a workspace only to DM

(account without workspaces needed)

Open the Create Expense screen.
Enter an amount and press Flip.
Verify that a minus sign appears before the currency.
Press Next.
Verify that you can proceed only with the DM.

2️⃣ Verify negative value functionality

(workspace required before running this test)

Open the Create Expense screen.
Enter an amount and press Flip.
Verify that a minus sign appears before the currency.
Press Next.
Verify that the selected workspace is the receiver.
Confirm the amount is negative on the current screen and submit the expense.
Open the newly created expense.
Verify that the amount has a minus sign.
Tap the amount and confirm that the minus sign appears before the currency.
Enter a new amount, press Flip, and submit.
Verify that the updated value is correct.
Verify that the update confirmation message is correct.

3️⃣ Verify negative value option is not hidden for DM

Open DM.
Open the Create Expense screen.
Verify that the Flip button is not hidden.

4️⃣ Verify negative value option is hidden for Split Bill

Start creating a Split Bill.
Verify that the Flip button is disabled.
Complete creation of the Split Bill.
Open the created Split Bill.
Update the amount.
Verify that the amount updated correctly and the history comment is accurate.

💻 Desktop

⚠️ Note: No Flip button — negative value input is manual using -.

1️⃣ Verify negative expense cannot be created without a workspace

(account without workspaces needed)

Open the Create Expense screen.
Place the cursor at the start of the amount field and enter - followed by a number.
Verify that a minus sign appears before the currency.
Press Next.
Verify that you cannot proceed because a workspace is required.

2️⃣ Verify negative value functionality

(workspace required before running this test)

Open the Create Expense screen.
Place the cursor at the start of the amount field and enter - followed by a number.
Verify that a minus sign appears before the currency.
Press Next.
Verify that the selected workspace is the receiver.
Confirm the amount is negative on the current screen and submit the expense.
Open the newly created expense.
Verify that the amount has a minus sign.
Edit the amount and confirm that the minus sign appears before the currency in the input field.
Enter a new amount with - and submit.
Verify that the updated value is correct.
Verify that the update confirmation message is correct.

3️⃣ Verify negative value option is not hidden for DM

Open DM.
Open the Create Expense screen.
Attempt to enter -.
Verify that:
- The minus sign is added

4️⃣ Verify negative value option is hidden for Split Bill

Start creating a Split Bill.
Attempt to enter - in the amount field.
Verify that:
- The minus sign is ignored
Complete creation of the Split Bill.
Open the created Split Bill.
Update the amount (without minus).
Verify that the amount updated correctly and the history comment is accurate.
Verify that no errors appear in the JS console

Offline tests

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Tests

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android-native-converted.webm

Android: mWeb Chrome

android-web-converted.webm

iOS: Native

ios-native-converted.mp4

iOS: mWeb Safari

ios-web-converted.mp4

MacOS: Chrome / Safari

mac-web-converted.mov

MacOS: Desktop

mac-desktop-converted.mov

…eature/allow-negative" This reverts commit e3255ba.

melvin-bot · 2025-06-26T11:06:28Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

Krishna2323 · 2025-07-01T17:04:42Z

src/pages/iou/MoneyRequestAmountForm.tsx

            return;
        }
-        initializeAmount(amount);
+        initializeAmount(absoluteAmount);


@pasyukevich, we also need to set isNegative to false here to fix this issue.

Thanks

I will check this

…stead of Next button

pasyukevich · 2025-07-04T17:59:36Z

Updates:

Keep working on fixes for reported issues

…uestAmountForm

trjExpensify · 2025-07-08T14:13:28Z

👋 @pasyukevich did you get any further on the ETA to address the regressions in this PR? We're trying to decide if this will make it into the product release message going out on Monday or not.

pasyukevich · 2025-07-09T11:52:18Z

Hi! @trjExpensify

Yes, I have. The fixes should be ready in the second half of next week. But I think it’s a bit early to announce that, as there might still be some hidden issues or missing links. We’ll also need to do more testing after the updates.

…sion handling

pasyukevich · 2025-07-17T15:04:06Z

Updates:

pasyukevich · 2025-07-17T15:04:32Z

Tommorow will be OOO

I will continue work here on monday

nkuoch · 2025-07-22T15:02:22Z

src/libs/TransactionUtils/index.ts

 * Return the amount field from the transaction, return the modifiedAmount if present.
 */
-function getAmount(transaction: OnyxInputOrEntry<Transaction>, isFromExpenseReport = false, isFromTrackedExpense = false): number {
+function getAmount(transaction: OnyxInputOrEntry<Transaction>, isFromExpenseReport = false, isFromTrackedExpense = false, allowNegative = false, disableOppositeConversion = false): number {


Can you double check wherever getAmount is called, that it's passing the proper value for isFromExpenseReport? In Transaction.ts, seems like we're not passing anything, but maybe we should

Sure, I will check

Yes, we are not passing the value from isFromExpenseReport in Transaction

I did not find anything that was broken due to this

I think we should create a separate PR to address this and verify - for me looks like a tech debt and more like an inconsistency that could lead to edge case bugs

That will update getTransactionPreviewTextAndTranslationPaths from TransactionPreviewUtils.ts
And getUpdateMoneyRequestParams from IOU.ts

OSBotify · 2025-10-08T15:26:29Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-10-08T21:56:32Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.28-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

…ature/allow-nagative-2" This reverts commit 9ef7cc5, reversing changes made to fe1ccab.

eh2077 · 2025-10-10T09:18:46Z

src/libs/OptionsListUtils/index.ts

+        if (reportUtilsIsPolicyExpenseChat(report) && !isEmptyObject(iouReport)) {
+            lastMessageTextFromReport = formatReportLastMessageText(getReportName(iouReport));


I believe this change is related to this issue (a demoted deploy blocker) #72139

@pasyukevich, this seems to be on purpose. Is there a reason/discussion about it?

Yes, here is the discussion - https://expensify.slack.com/archives/C07NMDKEFMH/p1759260448692239?thread_ts=1758645326.423979&cid=C07NMDKEFMH

cc @trjExpensify

Agreed, commented: #72139 (comment)

OSBotify · 2025-10-10T10:50:55Z

🚀 Deployed to production by https://github.com/lakchote in version: 9.2.28-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

linhvovan29546 · 2025-10-31T04:17:25Z

src/components/NumberWithSymbolForm.tsx


    return (
-        <>
+        <ScrollView contentContainerStyle={styles.flexGrow1}>


This caused the issue Split input field is not aligned on the right on confirm page, and we fixed it in this PR: #73228.

Krishna2323 · 2025-11-05T18:24:36Z

src/libs/ReportUtils.ts

    if (!isEmptyObject(iouReportAction) && !isIOUReport(report) && iouReportAction && isSplitBillReportAction(iouReportAction)) {
        // This covers group chats where the last action is a split expense action
        const linkedTransaction = getLinkedTransaction(iouReportAction);
        if (isEmptyObject(linkedTransaction)) {


We missed adding a fallback to format the message, which caused issue #72149. More details are available in the OP of PR #73071.

suneox · 2025-11-06T16:11:41Z

src/components/ReportActionItem/MoneyRequestView.tsx

    const transactionViolations = useTransactionViolations(transaction?.transactionID);
    const [outstandingReportsByPolicyID] = useOnyx(ONYXKEYS.DERIVED.OUTSTANDING_REPORTS_BY_POLICY_ID, {canBeMissing: true});

+    const allowNegativeAmount = shouldEnableNegative(report, policy);


Coming from #72165 checklist: this change missed adding the iouType parameter, causing invoices to incorrectly return false for negative amount allowance. We should pass iouType the same way as in IOURequestStepAmount

linhvovan29546 · 2025-11-09T04:08:20Z

src/components/NumberWithSymbolForm.tsx

+                        onMouseDown={(event) => focusTextInput(event, [NUMBER_VIEW_ID])}
+                        style={[styles.moneyRequestAmountContainer, styles.flexRow, styles.w100, styles.alignItemsCenter, styles.justifyContentCenter]}
+                    >
+                        {textInputComponent}


These changes caused the input to lose focus when clicking outside (see #72160). This PR updates the styles to fix the issue.

Reapply "Merge pull request Expensify#56092 from callstack-internal/f…

fea00d0

…eature/allow-negative" This reverts commit e3255ba.

pasyukevich mentioned this pull request Jun 27, 2025

[Due for payment 2025-10-17] [$250] Cannot make an expense negative #53441

Closed

8 tasks

Krishna2323 mentioned this pull request Jul 1, 2025

[Due for payment 2025-10-17][$250] BNP - Minus sign display is inconsistent consistent when navigating back from scan tab #64927

Closed

16 tasks

Krishna2323 reviewed Jul 1, 2025

View reviewed changes

pasyukevich added 4 commits July 3, 2025 18:19

Merge branch 'main' into feature/allow-nagative-2

f55b3e7

fix: error message when amount is missing is above currency button in…

4abd559

…stead of Next button

fix: negative amount when expense is created without a negative sign

0396a1d

Merge branch 'main' into feature/allow-nagative-2

a3e25be

fix: reset negative amount state when initializing amount in MoneyReq…

172aa03

…uestAmountForm

pasyukevich added 2 commits July 8, 2025 18:08

Merge branch 'main' into feature/allow-nagative-2

101b592

Merge branch 'main' into feature/allow-nagative-2

405a168

pasyukevich added 9 commits July 9, 2025 17:52

fix: lost variable after merge

9aeb435

fix: correct amount calculation in getDeletedTransactionMessage function

08bc9cd

Merge branch 'main' into feature/allow-nagative-2

114a649

fix: negative amount flow reset

e5574f6

fix: update amount comparison logic to include better opposite conver…

dbf5281

…sion handling

fix: prettier

ef37ddd

Merge branch 'main' into feature/allow-nagative-2

32c149f

Merge branch 'main' into feature/allow-nagative-2

78fe2df

Merge branch 'main' into feature/allow-nagative-2

034baa2

nkuoch reviewed Jul 22, 2025

View reviewed changes

pasyukevich added 3 commits July 22, 2025 17:28

Merge branch 'main' into feature/allow-nagative-2

ad8733f

fix prettier

41662ac

Merge branch 'main' into feature/allow-nagative-2

bd0411a

luacmartins approved these changes Oct 8, 2025

View reviewed changes

luacmartins merged commit 9ef7cc5 into Expensify:main Oct 8, 2025
22 checks passed

OSBotify mentioned this pull request Oct 8, 2025

Deploy Checklist: New Expensify 2025-10-08 #72135

Closed

62 tasks

lanitochka17 mentioned this pull request Oct 8, 2025

[Due for payment 2025-10-31] Expense - Old amount in the system message does not show negative sign #72137

Closed

16 tasks

mitarachim mentioned this pull request Oct 8, 2025

[Due for payment 2025-10-28] Expense - Negative expense can be added to IOU report, which causes error #72138

Closed

8 tasks

lanitochka17 mentioned this pull request Oct 8, 2025

[Due for payment 2025-10-28] [$250] Expense - App allows to merge negative expense with IOU expense, negative amount is not saved #72143

Closed

16 tasks

pasyukevich added a commit to callstack-internal/Expensify-App that referenced this pull request Oct 9, 2025

Revert "Merge pull request Expensify#65001 from callstack-internal/fe…

fb5ed26

…ature/allow-nagative-2" This reverts commit 9ef7cc5, reversing changes made to fe1ccab.

pasyukevich added a commit to callstack-internal/Expensify-App that referenced this pull request Oct 9, 2025

Revert "Merge pull request Expensify#65001 from callstack-internal/fe…

6205fc3

…ature/allow-nagative-2" This reverts commit 9ef7cc5, reversing changes made to fe1ccab.

jponikarchuk mentioned this pull request Oct 9, 2025

[Due for payment 2025-11-03] Reports - After reset app, expense row does not show negative sign on Reports > Expenses #72205

Closed

8 tasks

This was referenced Oct 9, 2025

Expense - When workspace has bank account, LHN shows GBR after approving negative expense #72198

Closed

[Due for payment 2025-10-17] Expense - Self DM is not present on recipient list during expense creation. #72152

Closed

eh2077 reviewed Oct 10, 2025

View reviewed changes

milos213 mentioned this pull request Oct 15, 2025

[Due for payment 2025-11-03] [$250] Expense - Split input field is not aligned on the right on confirm page #72140

Closed

16 tasks

linhvovan29546 reviewed Oct 31, 2025

View reviewed changes

Krishna2323 reviewed Nov 5, 2025

View reviewed changes

suneox reviewed Nov 6, 2025

View reviewed changes

linhvovan29546 reviewed Nov 9, 2025

View reviewed changes

		if (reportUtilsIsPolicyExpenseChat(report) && !isEmptyObject(iouReport)) {
		lastMessageTextFromReport = formatReportLastMessageText(getReportName(iouReport));

Conversation

pasyukevich commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

📱 Mobile

1️⃣ Verify negative expense can be created without a workspace only to DM

2️⃣ Verify negative value functionality

3️⃣ Verify negative value option is not hidden for DM

4️⃣ Verify negative value option is hidden for Split Bill

💻 Desktop

1️⃣ Verify negative expense cannot be created without a workspace

2️⃣ Verify negative value functionality

3️⃣ Verify negative value option is not hidden for DM

4️⃣ Verify negative value option is hidden for Split Bill

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Jun 26, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

pasyukevich commented Jul 4, 2025

Uh oh!

trjExpensify commented Jul 8, 2025

Uh oh!

pasyukevich commented Jul 9, 2025

Uh oh!

pasyukevich commented Jul 17, 2025

Uh oh!

pasyukevich commented Jul 17, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

OSBotify commented Oct 8, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

OSBotify commented Oct 10, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

14 participants

pasyukevich commented Jun 26, 2025 •

edited

Loading