Add merge option when selecting transactions in the report page#73248
Add merge option when selecting transactions in the report page#73248youssef-lr merged 135 commits intomainfrom
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 @youssef-lr has triggered a test Expensify/App build. You can view the workflow run here. |
This comment has been minimized.
This comment has been minimized.
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/youssef-lr in version: 9.2.85-0 🚀
|
|
This PR is failing because of issue ##78174 The issue is reproducible in: Web Bug7034057_1766190152359.4.1.mp4 |
|
This PR is failing because of issue ##78176 The issue is reproducible in: Web Bug7034053_1766192615574.03.1.mp4 |
|
This PR is failing because of issue ##78179 The issue is reproducible in: Web Bug7034060_1766190495498.5.1.mp4 |
|
🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.85-7 🚀
|
Explanation of Change
Fixed Issues
$ #65574
$ #74110
PROPOSAL:
Tests
See QA section
Offline tests
Same test steps while offline.
QA Steps
In the tests, editable means that the transaction is unreported, is in a draft report, or is a report that is awaiting the first approval.
For a manager, they can edit transactions where they are currently the manager and the report is in the submitted state.
For admins, they can edit all transactions of the policy where the parent report is either draft, or submitted.
Two editable transactions without receipts
Two editable transactions, one of them with a receipt
Two editable card transactions
One card, and one cash transaction with receipt
Manager with editable expenses
Admin
Admin with approved transactions
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
MacOS: Desktop