ValidationStep title changes based on VBA state#7331
Merged
Conversation
ctkochan22
added
the
Internal
nkuoch
approved these changes
Jan 20, 2022
|
@nkuoch looks like this was merged without passing tests. Please add a note explaining why this was done and remove the |
Contributor
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
33 tasks
Contributor
|
@ctkochan22 What platforms do you need this tested on? all or just Web |
Author
|
Just web is fine! |
Contributor
|
🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀
|
Contributor
|
Removing Emergency label. It's old |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@Expensify/pullerbear
cc @kevinksullivan
Details
A bank account has two state when it hits the ValidationStep: PENDING or VERIFYING. Currently the step title will only show "Test Transactions" for all situations. We should now show "Connect Bank Account" for VERIFYING, and "Test Transaction" for PENDING
Fixed Issues
$#7322
Tests / QA Steps
Follow https://stackoverflow.com/c/expensify/questions/342 to add a PENDING bank account
When you get the PENDING state, verify that the title says "Test Transactions"
Add another VBA that needs to be verified and is in the VERIFYING state
When you get to the validationStep, verify that the title says "Connect Bank Account"
Tested On
Screenshots
Web
Mobile Web
Desktop
iOS
Android