Skip to content

Change IOU preview statement to use you#7332

Merged
luacmartins merged 1 commit intoExpensify:mainfrom
sobitneupane:sn_feature-iou-preview-naming
Jan 20, 2022
Merged

Change IOU preview statement to use you#7332
luacmartins merged 1 commit intoExpensify:mainfrom
sobitneupane:sn_feature-iou-preview-naming

Conversation

@sobitneupane
Copy link
Copy Markdown
Contributor

Details

Changed IOU preview statements to make use of you in the appropriate place.

Fixed Issues

$ #7148

Tests

  • Perform IOU operations like Request Money and Pay.
  • Check if IOU preview statement like "John owes you" is correct or not.

QA Steps

  • Perform IOU operations like Request Money and Pay.
  • Check if IOU preview statement like "John owes you" is correct or not.

Tested On

  • Web
  • Mobile Web
  • Desktop
  • iOS
  • Android

Screenshots

Web

Screenshot from 2022-01-20 13-02-37
Screenshot from 2022-01-20 13-01-37

Mobile Web

Desktop

iOS

Android

Screenshot_20220120-140007_New Expensify

@sobitneupane sobitneupane requested a review from a team as a code owner January 20, 2022 08:58
@MelvinBot MelvinBot requested review from luacmartins and rushatgabhane and removed request for a team January 20, 2022 08:58
Copy link
Copy Markdown
Contributor

@luacmartins luacmartins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested well on all platforms. Thanks @sobitneupane!

@luacmartins luacmartins merged commit f052b94 into Expensify:main Jan 20, 2022
@OSBotify
Copy link
Copy Markdown
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@rushatgabhane
Copy link
Copy Markdown
Member

rushatgabhane commented Jan 20, 2022

Hmm weird, I approved this a while ago but now it's missing 👻

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to staging by @luacmartins in version: 1.1.31-2 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

@OSBotify
Copy link
Copy Markdown
Contributor

🚀 Deployed to production by @AndrewGable in version: 1.1.32-0 🚀

platform result
🤖 android 🤖 success ✅
🖥 desktop 🖥 success ✅
🍎 iOS 🍎 success ✅
🕸 web 🕸 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants