Skip to content

Revert "fix: User's name is not displayed in mention"#73356

Merged
puneetlath merged 1 commit intomainfrom
revert-72291-fix/70893
Oct 23, 2025
Merged

Revert "fix: User's name is not displayed in mention"#73356
puneetlath merged 1 commit intomainfrom
revert-72291-fix/70893

Conversation

@puneetlath
Copy link
Contributor

@puneetlath puneetlath commented Oct 23, 2025

Reverts #72291. The bug report that led to that PR misunderstands how mentions are supposed to work in Expensify, so the wrong behavior was implemented. The feature was working fine as it was before.

@puneetlath puneetlath marked this pull request as ready for review October 23, 2025 20:23
@puneetlath puneetlath requested a review from a team as a code owner October 23, 2025 20:23
@melvin-bot melvin-bot bot requested review from Beamanator and removed request for a team October 23, 2025 20:23
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2025

@Beamanator Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@github-actions
Copy link
Contributor

LGTM :feelsgood:. Thank you for your hard work!

@puneetlath puneetlath merged commit 8c5b076 into main Oct 23, 2025
25 of 29 checks passed
@puneetlath puneetlath deleted the revert-72291-fix/70893 branch October 23, 2025 20:31
@melvin-bot melvin-bot bot added the Emergency label Oct 23, 2025
@melvin-bot
Copy link

melvin-bot bot commented Oct 23, 2025

@puneetlath looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@puneetlath
Copy link
Contributor Author

Straight revert, so checklists were not needed.

OSBotify pushed a commit that referenced this pull request Oct 23, 2025
Revert "fix: User's name is not displayed in mention"

(cherry picked from commit 8c5b076)

(cherry-picked to staging by puneetlath)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Oct 23, 2025
@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.37-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/blimpich in version: 9.2.37-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Cherry-picked to staging by https://github.com/puneetlath in version: 9.2.38-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/puneetlath in version: 9.2.38-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants