[No QA] Update to pass failing test #73372
[No QA] Update to pass failing test #73372stephanieelliott merged 322 commits intoVictoriaExpensify-patch-5from
Conversation
…no transaction thread yet
Revert "fix: User's name is not displayed in mention"
[Translation Migration] Fix split or incomplete translations in violations
…r-briefly-shown Fix search page footer briefly shows after approve report
…t-patch-18 [No QA] Revert "[No QA] Update Compliance-Documentation.md"
Concierge reviewer checklist:
For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member? cc @lschurr |
melvin-bot
bot
requested review from
lschurr and
mollfpr
and removed request for
a team
|
@mollfpr @lschurr One of you needs to copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] NOTE: It looks like |
🦜 Polyglot Parrot! 🦜Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues: The diff is too large to include in this comment (128KB), so I've created a gist for you: 📋 View the translation diff here 📋 Note You can apply these changes to your branch by copying the patch to your clipboard, then running |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| useEffect(() => { | ||
| if (removeMembersConfirmModalVisible && !deepEqual(accountIDs, prevAccountIDs)) { | ||
| setRemoveMembersConfirmModalVisible(false); | ||
| if (!removeMembersConfirmModalVisible || deepEqual(accountIDs, prevAccountIDs)) { |
There was a problem hiding this comment.
❌ PERF-5 (docs)
Using deepEqual for array comparison creates performance overhead by recursively checking all elements, which often costs more than the conditional logic it prevents.
Replace deep equality check with array length comparison or shallow comparison:
if (!removeMembersConfirmModalVisible || (accountIDs.length === prevAccountIDs.length && accountIDs.every((id, index) => id === prevAccountIDs[index]))) {
return;
}Or for simple array comparison:
if (!removeMembersConfirmModalVisible || accountIDs === prevAccountIDs || (accountIDs.length === prevAccountIDs.length && accountIDs.every((id, index) => id === prevAccountIDs[index]))) {
return;
}
github-actions
bot
changed the title
|
A preview of your ExpensifyHelp changes have been deployed to https://de96c319.helpdot.pages.dev ⚡️ Updated articles: |
| Considerations when removing `backTo` from a URL: | ||
|
|
||
| - For RHP screens, check if the correct central screen is under the overlay after refreshing the page. More information on how to set the default screen underneath RHP can be found (here)[#setting-the-correct-screen-underneath-rhp]. | ||
| - Ensure that after refreshing the page and pressing the back button in the application, you return to the page from which you initially accessed the currently displayed screen. |
There was a problem hiding this comment.
Markdown formatting violation: The link syntax is incorrect. Use [here](#setting-the-correct-screen-underneath-rhp) instead of (here)[#setting-the-correct-screen-underneath-rhp] for proper markdown link formatting.
HelpDot Documentation ReviewOverall AssessmentThis PR contains mixed documentation changes affecting three files: a major overhaul of navigation documentation, a minor compliance document update, and a redirect removal. While the changes are technically sound, there are several areas needing attention for optimal HelpDot standards. Scores Summary
Key Findings
Recommendations
Files Reviewed
Note: This is a top-level assessment. The documentation changes successfully address their intended purpose of deprecating backTo parameters while maintaining clear developer guidance. |
stephanieelliott
merged commit 65a8079
into
VictoriaExpensify-patch-5
20 participants
No description provided.