Make `NetSuiteInvoiceItemPreferenceSelectPage` use new `SelectionList` by zfurtak · Pull Request #73935 · Expensify/App

zfurtak · 2025-10-31T15:57:32Z

Explanation of Change

Fixed Issues

$ #72969
PROPOSAL:

Tests

Go to the Workspaces tab
Go to your chosen workspace
Enable the Accounting toggle
Navigate to the Accounting tab
Add the NetSuite accounting system to the workspace
Go to Export -> Invoice Item
Verify that the list from the NetSuiteInvoiceItemPreferenceSelectPage is working correctly
7.1. It's important to check this page also with Simulate failing network requests enabled in Troubleshoot

Verify that no errors appear in the JS console

Offline tests

QA Steps

as above

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

android.mp4

Android: mWeb Chrome

android-web.mp4

iOS: Native

ios.mov

iOS: mWeb Safari

ios-web.mov

MacOS: Chrome / Safari

Web without errors

web.mov

Web with error

web-with-errors.mov

MacOS: Desktop

…erd03/migrate-NetSuiteInvoiceItemPreferenceSelectPage

…enceSelectPage

github-actions · 2025-10-31T15:59:32Z

src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemPreferenceSelectPage.tsx

+        const selectedIndex = options.findIndex((option) => option.isSelected);
+        if (selectedIndex !== -1 && selectionListRef.current) {
+            selectionListRef.current?.updateFocusedIndex(selectedIndex);
+        }


❌ PERF-6 (docs)

The options array is recreated on every render (line 43), causing this useEffect to run unnecessarily. Passing the entire options array causes the hook to re-execute whenever any property changes in the dependency chain.

Suggested fix: Use specific primitive dependencies instead:

useEffect(() => { const selectedIndex = options.findIndex((option) => option.isSelected); if (selectedIndex !== -1 && selectionListRef.current) { selectionListRef.current?.updateFocusedIndex(selectedIndex); } }, [selectedValue]);

Since selectedValue already determines which option is selected, and options array structure doesn't change (only the isSelected property changes based on selectedValue), using selectedValue as the sole dependency is more granular and prevents unnecessary re-executions.

The options array has only two elements, so for the sake of clear code I just pust this find(... inside useEffect and then I put it also to the dependencies.

I don't think there's need to change it, if someone thinks different I'm here to discuss 😊

I think that without react compiler this might result in an infinite loop. The safest approach would be to add useMemo to options

src/components/SelectionList/types.ts

codecov · 2025-11-03T09:28:26Z

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...export/NetSuiteInvoiceItemPreferenceSelectPage.tsx	0.00%	8 Missing ⚠️
src/components/SelectionList/BaseSelectionList.tsx	25.00%	6 Missing ⚠️

Files with missing lines	Coverage Δ
src/components/SelectionList/BaseSelectionList.tsx	`54.38% <25.00%> (-1.72%)`	⬇️
...export/NetSuiteInvoiceItemPreferenceSelectPage.tsx	`0.00% <0.00%> (ø)`

... and 27 files with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…ceSelectPage

src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemPreferenceSelectPage.tsx

blazejkustra

LGTM

src/components/SelectionList/types.ts

melvin-bot · 2025-11-03T13:12:08Z

@rushatgabhane Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemPreferenceSelectPage.tsx

dukenv0307 · 2025-11-03T14:39:13Z

Left a comment here

dukenv0307 · 2025-11-04T16:31:59Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-04.at.23.12.51.mov

Android: mWeb Chrome

Screen.Recording.2025-11-04.at.23.10.34.mov

iOS: HybridApp

Screen.Recording.2025-11-04.at.23.13.48.mov

iOS: mWeb Safari

Screen.Recording.2025-11-04.at.23.11.00.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-04.at.23.01.36.mov

MacOS: Desktop

Screen.Recording.2025-11-04.at.23.14.37.mov

OSBotify · 2025-11-06T23:52:13Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.46-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-11-07T17:32:41Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-07T23:32:20Z

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OlGierd03 and others added 9 commits October 17, 2025 17:50

Merge branch '@zfurtak/migrate-CategoryDefaultTaxRatePage' into @OlGi…

21549f2

…erd03/migrate-NetSuiteInvoiceItemPreferenceSelectPage

Merge branch '@zfurtak/migrate-CategoryDefaultTaxRatePage' into @OlGi…

7f069fe

…erd03/migrate-NetSuiteInvoiceItemPreferenceSelectPage

Make NetSuiteInvoiceItemPreferenceSelectPage use new SelectionList

2e7e44d

Merge branch 'main' into @OlGierd03/migrate-NetSuiteInvoiceItemPrefer…

619a87c

…enceSelectPage

Adjust styling

2ddc53a

Merge branch 'main' into @OlGierd03/migrate-NetSuiteInvoiceItemPrefer…

e7ca08c

…enceSelectPage

Merge branch 'main' into @OlGierd03/migrate-NetSuiteInvoiceItemPrefer…

f0c7915

…enceSelectPage

Fix styling and focusing

70a9fe4

Add missing blank line

46b8e53

melvin-bot bot assigned zfurtak Oct 31, 2025

github-actions bot reviewed Oct 31, 2025

View reviewed changes

src/components/SelectionList/types.ts Outdated Show resolved Hide resolved

Fix typo

3ee5890

zfurtak mentioned this pull request Nov 3, 2025

[Due for payment 2026-01-23] [SelectionList Improvements][Phase 2] Migrate all usages (~100) #65655

Closed

Merge branch 'main' into @zfurtak/migrate-NetSuiteInvoiceItemPreferen…

21a2654

…ceSelectPage

blazejkustra suggested changes Nov 3, 2025

View reviewed changes

src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemPreferenceSelectPage.tsx Show resolved Hide resolved

Wrap options with useMemo

892ce63

zfurtak requested a review from blazejkustra November 3, 2025 12:08

blazejkustra approved these changes Nov 3, 2025

View reviewed changes

src/components/SelectionList/types.ts Outdated Show resolved Hide resolved

Adjust comment

60b0213

zfurtak marked this pull request as ready for review November 3, 2025 13:12

zfurtak requested review from a team as code owners November 3, 2025 13:12

melvin-bot bot requested review from rushatgabhane and removed request for a team November 3, 2025 13:12

github-actions bot reviewed Nov 3, 2025

View reviewed changes

src/pages/workspace/accounting/netsuite/export/NetSuiteInvoiceItemPreferenceSelectPage.tsx Show resolved Hide resolved

rushatgabhane requested review from dukenv0307 and removed request for rushatgabhane November 3, 2025 13:38

Rerun tests

7f0f406

dukenv0307 approved these changes Nov 4, 2025

View reviewed changes

melvin-bot bot requested a review from grgia November 4, 2025 16:32

grgia approved these changes Nov 6, 2025

View reviewed changes

grgia merged commit c53df3e into Expensify:main Nov 6, 2025
26 of 29 checks passed

zfurtak deleted the @zfurtak/migrate-NetSuiteInvoiceItemPreferenceSelectPage branch November 6, 2025 13:43

github-actions bot mentioned this pull request Nov 6, 2025

Investigate workflow job failing on main: test / test (job 2) #74483

Closed

OSBotify mentioned this pull request Nov 6, 2025

Deploy Checklist: New Expensify 2025-11-06 #74515

Closed

64 tasks

Conversation

zfurtak commented Oct 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

github-actions bot Oct 31, 2025

Choose a reason for hiding this comment

❌ PERF-6 (docs)

Uh oh!

zfurtak Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

blazejkustra Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codecov bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

melvin-bot bot commented Nov 3, 2025

Uh oh!

Uh oh!

dukenv0307 commented Nov 3, 2025

Uh oh!

dukenv0307 commented Nov 4, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 6, 2025

Uh oh!

OSBotify commented Nov 7, 2025

Uh oh!

OSBotify commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

zfurtak commented Oct 31, 2025 •

edited

Loading

codecov bot commented Nov 3, 2025 •

edited

Loading