Make `DebugReportActions` use new `SelectionList` by zfurtak · Pull Request #74112 · Expensify/App

zfurtak · 2025-11-03T18:39:51Z

Explanation of Change

Fixed Issues

$ #72970
PROPOSAL:

Tests

Go to Settings -> Troubleshoot
Turn on Debug mode
Go to Inbox
Click on debug view
Go to Actions tab
Verify that list with input is working correctly

Verify that no errors appear in the JS console

Offline tests

QA Steps

Verify that no errors appear in the JS console

PR Author Checklist

I linked the correct issue in the ### Fixed Issues section above
I wrote clear testing steps that cover the changes made in this PR
- I added steps for local testing in the Tests section
- I added steps for the expected offline behavior in the Offline steps section
- I added steps for Staging and/or Production testing in the QA steps section
- I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
I included screenshots or videos for tests on all platforms
I ran the tests on all platforms & verified they passed on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
I verified there are no new alerts related to the canBeMissing param for useOnyx
I followed proper code patterns (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
  - If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I followed the guidelines as stated in the Review Guidelines
I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
I verified that if a function's arguments changed that all usages have also been updated correctly
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
If new assets were added or existing ones were modified, I verified that:
- The assets are optimized and compressed (for SVG files, run npm run compress-svg)
- The assets load correctly across all supported platforms.
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

screen-20251105-170746.mp4

Android: mWeb Chrome

iOS: Native

ios.mov

iOS: mWeb Safari

MacOS: Chrome / Safari

web.mov

MacOS: Desktop

src/pages/Debug/Report/DebugReportActions.tsx

github-actions · 2025-11-03T18:42:35Z

src/pages/Debug/Report/DebugReportActions.tsx

+                    label: translate('common.search'),
+                    onChangeText: setSearchValue,
+                    headerMessage: getHeaderMessageForNonUserList(searchedReportActions.length > 0, debouncedSearchValue),
+                }}


❌ PERF-4 (docs)

Creating a new arrow function on every render causes unnecessary re-renders of the SelectionList component, as the function reference changes each time.

Memoize this callback using useCallback:

const handleSelectRow = useCallback( (item) => Navigation.navigate(ROUTES.DEBUG_REPORT_ACTION.getRoute(reportID, item.reportActionID)), [reportID] ); // Then use: onSelectRow={handleSelectRow}

I don't think we should use useCallback in every possible place

codecov · 2025-11-03T19:13:36Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Debug/Report/DebugReportActions.tsx	`94.11% <100.00%> (+0.17%)`	⬆️
.../components/SelectionList/components/TextInput.tsx	`94.73% <92.30%> (+44.73%)`	⬆️
src/components/SelectionList/BaseSelectionList.tsx	`62.87% <33.33%> (+7.64%)`	⬆️
... and 167 files with indirect coverage changes

blazejkustra

LGTM

melvin-bot · 2025-11-07T13:19:06Z

@truph01 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

src/components/SelectionList/components/TextInput.tsx

JmillsExpensify

No review required from a product perspective. Unsubscribing.

truph01 · 2025-11-11T10:33:21Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-11.at.18.20.10.mov

Android: mWeb Chrome

Screen.Recording.2025-11-11.at.18.17.05.mov

iOS: HybridApp

Screen.Recording.2025-11-11.at.18.14.41.mov

iOS: mWeb Safari

Screen.Recording.2025-11-11.at.18.15.35.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-11.at.18.12.52.mov

MacOS: Desktop

Screen.Recording.2025-11-11.at.18.16.15.mov

truph01 · 2025-11-11T11:03:14Z

src/components/SelectionList/components/TextInput.tsx

+            if (text === '') {
+                setFocusedIndex(-1);
+            } else {
+                setFocusedIndex(0);
+            }


@zfurtak Why do we need to add this logic? It causes the behavior in the report action debug page to differ from what's seen in staging.

This PR:

Screen.Recording.2025-11-11.at.17.58.36.mov

Staging:

Screen.Recording.2025-11-11.at.17.58.49.mov

You can see what it looks like on main below, however I got the impression that the behaviour of focused index which stays on the first one looks like bug (after deleting everything or No results)
What do you think? If we want to stick with this behaviour I'll revert it

Screen.Recording.2025-11-12.at.11.37.47.mov

@zfurtak I think it makes sense to revert this for now and follow up with the design team about your suggestion in a separate ticket. Since TextInput is a widely used component across the app, any changes to it should go through proper design review first.

Yeah, you're right

Btw I found a bug, input didn't focus automatically after entering the page, just pushed a fix

truph01 · 2025-11-13T04:22:15Z

Btw I found a bug, input didn't focus automatically after entering the page, just pushed a fix

@zfurtak In native, the input didn't auto focus after entering the page:

Screen.Recording.2025-11-13.at.11.21.15.mov

zfurtak · 2025-11-14T08:31:30Z

@truph01 should be all good now :)

zfurtak · 2025-11-18T10:06:06Z

@truph01 could you re-check the PR?
I want to have it merged as soon as possible, cause I need the changes in all other PRs

truph01 · 2025-11-18T11:30:24Z

I am checking it now

zfurtak · 2025-11-18T12:53:42Z

hi @grgia could you review and then merge this one? It has changes needed for all next PRs 😊

OSBotify · 2025-11-21T12:26:12Z

🚀 Deployed to staging by https://github.com/grgia in version: 9.2.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

mitarachim · 2025-11-24T02:30:46Z

@zfurtak This PR is failing because of a regression issue #75838

The issue is reproducible in: iOS

Bug7010286_1763741269495.89952f6b-2a97-4757-8fe0-9b520a3238bc.mp4

OSBotify · 2025-11-24T20:01:14Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

truph01 · 2025-12-02T10:21:58Z

@grgia could you handle payment for me since the PR is deployed to production?

Make DebugReportActions use new SelectionList

d8c00d1

melvin-bot bot assigned zfurtak Nov 3, 2025

github-actions bot reviewed Nov 3, 2025

View reviewed changes

src/pages/Debug/Report/DebugReportActions.tsx Show resolved Hide resolved

github-actions bot reviewed Nov 3, 2025

View reviewed changes

src/pages/Debug/Report/DebugReportActions.tsx Show resolved Hide resolved

github-actions bot reviewed Nov 3, 2025

View reviewed changes

zfurtak mentioned this pull request Nov 3, 2025

[Due for payment 2025-12-10] [Due for payment 2025-12-05] [Due for payment 2025-12-03] Migrate Wave 4 #72970

Open

zfurtak added 2 commits November 3, 2025 19:49

Wrap textInputOptions in useMemo

4557141

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

1ef387b

zfurtak added 3 commits November 5, 2025 14:15

Fix focusing within TextInput

b7d7aac

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

2670b64

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

cf6d812

blazejkustra approved these changes Nov 6, 2025

View reviewed changes

zfurtak marked this pull request as ready for review November 7, 2025 13:19

zfurtak requested review from a team as code owners November 7, 2025 13:19

melvin-bot bot requested a review from truph01 November 7, 2025 13:19

melvin-bot bot requested review from JmillsExpensify and removed request for a team November 7, 2025 13:19

github-actions bot reviewed Nov 7, 2025

View reviewed changes

src/components/SelectionList/components/TextInput.tsx Outdated Show resolved Hide resolved

zfurtak added 2 commits November 7, 2025 15:40

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

b4c1297

Change dependencies in useMemo

9283c83

zfurtak mentioned this pull request Nov 7, 2025

Make IndustryCodeSelector use new SelectionList #74586

Merged

54 tasks

JmillsExpensify reviewed Nov 7, 2025

View reviewed changes

truph01 reviewed Nov 11, 2025

View reviewed changes

zfurtak added 2 commits November 12, 2025 18:22

Revert changing focus

46c0c2a

Fix autofocus

ff4f92b

zfurtak added 2 commits November 12, 2025 18:41

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

b072513

Add missing jsdoc

c9dbfd9

zfurtak mentioned this pull request Nov 12, 2025

Make NewReportWorkspaceSelectionPage use new SelectionList #74974

Merged

54 tasks

zfurtak added 5 commits November 13, 2025 09:38

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

d0aeb2d

Fix autofocus on native

41ca883

Adjustments

4f8c240

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

2e37d3c

Merge branch 'main' into @zfurtak/migrate-DebugReportActions

15fd05b

OlGierd03 mentioned this pull request Nov 14, 2025

Make ConstantPicker use new SelectionList #73748

Merged

52 tasks

zfurtak mentioned this pull request Nov 18, 2025

Make ReportChangeWorkspacePage use new SelectionList #75378

Merged

54 tasks

truph01 approved these changes Nov 18, 2025

View reviewed changes

dukenv0307 mentioned this pull request Nov 19, 2025

Make PushRowModal use new SelectionList #75431

Merged

54 tasks

grgia self-requested a review November 19, 2025 09:33

OlGierd03 mentioned this pull request Nov 19, 2025

Make CountrySelectionPage use new SelectionList #75543

Merged

52 tasks

dukenv0307 mentioned this pull request Nov 19, 2025

Make AssigneeStep (assignCard) use new SelectionList #75529

Merged

54 tasks

grgia approved these changes Nov 19, 2025

View reviewed changes

grgia merged commit eff1fcf into Expensify:main Nov 19, 2025
27 checks passed

OSBotify mentioned this pull request Nov 21, 2025

Deploy Checklist: New Expensify 2025-11-21 #75728

Closed

mitarachim mentioned this pull request Nov 24, 2025

[PAY 11/12] [$250] Debug Actions - Search input does not return results for valid keywords #75838

Closed

8 tasks

This was referenced Dec 4, 2025

[CLEAN] Synthetic Benchmark PR #74112 - Make DebugReportActions use new SelectionList qodo-benchmark/App#25

Open

[CORRUPTED] Synthetic Benchmark PR #74112 - Make DebugReportActions use new SelectionList qodo-benchmark/App#26

Open

Conversation

zfurtak commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

Uh oh!

Uh oh!

github-actions bot Nov 3, 2025

Choose a reason for hiding this comment

❌ PERF-4 (docs)

Uh oh!

zfurtak Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 3, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blazejkustra left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 7, 2025

Uh oh!

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

truph01 commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

zfurtak Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

truph01 Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

zfurtak Nov 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

truph01 commented Nov 13, 2025

Uh oh!

zfurtak commented Nov 14, 2025

Uh oh!

zfurtak commented Nov 18, 2025

Uh oh!

truph01 commented Nov 18, 2025

Uh oh!

zfurtak commented Nov 18, 2025

Uh oh!

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

mitarachim commented Nov 24, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

truph01 commented Dec 2, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

zfurtak commented Nov 3, 2025 •

edited

Loading

codecov bot commented Nov 3, 2025 •

edited by github-actions bot

Loading

truph01 commented Nov 11, 2025 •

edited

Loading

truph01 Nov 11, 2025 •

edited

Loading

zfurtak Nov 12, 2025 •

edited

Loading