Skip to content

[CP Staging] Revert "Can't select an empty report from the Reports > Reports page"#74551

Merged
techievivek merged 1 commit intomainfrom
revert-70877-fix/70591
Nov 7, 2025
Merged

[CP Staging] Revert "Can't select an empty report from the Reports > Reports page"#74551
techievivek merged 1 commit intomainfrom
revert-70877-fix/70591

Conversation

@mountiny
Copy link
Contributor

@mountiny mountiny commented Nov 7, 2025

Reverts #70877

$ #74518
$ #74519
$ #74520
$ #74521
$ #74522
$ #74534
$ #74536
$ #74537
$ #74538
$ #74539

QA steps

Please retest the linked issues

@mountiny mountiny self-assigned this Nov 7, 2025
@mountiny mountiny requested review from a team as code owners November 7, 2025 09:14
@melvin-bot melvin-bot bot requested review from AndrewGable and trjExpensify and removed request for a team November 7, 2025 09:14
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2025

@AndrewGable Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@codecov
Copy link

codecov bot commented Nov 7, 2025

Codecov Report

❌ Patch coverage is 2.63158% with 37 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/components/Search/index.tsx 0.00% 30 Missing ⚠️
src/components/Search/SearchList/index.tsx 0.00% 5 Missing ⚠️
...stWithSections/Search/TransactionGroupListItem.tsx 50.00% 1 Missing ⚠️
src/pages/Search/SearchPage.tsx 0.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
src/libs/actions/Search.ts 11.68% <ø> (-8.19%) ⬇️
...stWithSections/Search/TransactionGroupListItem.tsx 79.68% <50.00%> (-3.13%) ⬇️
src/pages/Search/SearchPage.tsx 0.00% <0.00%> (ø)
src/components/Search/SearchList/index.tsx 0.00% <0.00%> (ø)
src/components/Search/index.tsx 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@techievivek techievivek merged commit c2751ad into main Nov 7, 2025
27 of 32 checks passed
@techievivek techievivek deleted the revert-70877-fix/70591 branch November 7, 2025 09:30
@melvin-bot
Copy link

melvin-bot bot commented Nov 7, 2025

@techievivek looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@mountiny
Copy link
Contributor Author

mountiny commented Nov 7, 2025

Straight revert

@techievivek
Copy link
Contributor

Not an emergency merge, discussed here https://expensify.slack.com/archives/C03TQ48KC/p1762507441387319

@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify pushed a commit that referenced this pull request Nov 7, 2025
[CP Staging] Revert "Can't select an empty report from the Reports > Reports page"

(cherry picked from commit c2751ad)

(cherry-picked to staging by lakchote)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Nov 7, 2025
@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2025

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.46-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@IuliiaHerets
Copy link

IuliiaHerets commented Nov 7, 2025

@mountiny all linked issues were checked and passed by the QA team, commented in each issue

@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2025

🚀 Deployed to production by https://github.com/luacmartins in version: 9.2.46-3 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 failure ❌

@OSBotify
Copy link
Contributor

OSBotify commented Nov 7, 2025

🚀 Cherry-picked to staging by https://github.com/lakchote in version: 9.2.47-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/cristipaval in version: 9.2.47-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants