Conversation
|
Hey, I noticed you changed If you want to automatically generate translations for other locales, an Expensify employee will have to:
Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running: npx ts-node ./scripts/generateTranslations.ts --helpTypically, you'd want to translate only what you changed by running |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
melvin-bot
bot
requested review from
JmillsExpensify and
Valforte
and removed request for
a team
|
@mananjadhav Will review this issue. @lakchote PR is ready for review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| rejectMoneyRequestsOnSearch(context.currentSearchHash, context.selectedTransactions, comment, allPolicies, allReports); | ||
| context.clearSelectedTransactions(); | ||
| Navigation.goBack(); | ||
| }, |
There was a problem hiding this comment.
❌ PERF-6 (docs)
Passing entire objects as dependencies causes hooks to re-execute whenever any property changes, even unrelated ones. Specifying individual properties creates more granular dependency tracking, reducing unnecessary hook executions.
Instead of depending on the entire context, allPolicies, and allReports objects, specify the individual properties being accessed:
[context.currentSearchHash, context.selectedTransactions, context.clearSelectedTransactions, allPolicies, allReports],Note: While allPolicies and allReports are Onyx collections that ideally should also be narrowed down, at minimum the context object should be broken down into its individual accessed properties.
JmillsExpensify
left a comment
JmillsExpensify
left a comment
There was a problem hiding this comment.
No review required from product.
|
🚧 @lakchote has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
@mananjadhav the conflicts are resolved, anything stopping you approving? |
|
We found one case regarding duplicate messages. Posted in slack here. @lakchote and @truph01 are working on the fix. |
BE fix has been deployed, now waiting on the frontend update cc @truph01 |
|
@mananjadhav The duplicate issue is gone. Could you re-test and complete the checklist? |
|
Testing this now. |
|
Tested and it works fine. web-bulk-reject-duplicate-message-test.movweb-bulk-reject-hold-modal.mov |
|
🎯 @mananjadhav, thanks for reviewing and testing this PR! 🎉 An E/App issue has been created to issue payment here: #76259. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/lakchote in version: 9.2.66-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.66-3 🚀
|
| shouldCloseModalOnSelect: true, | ||
| disabled: isRejectDisabled, | ||
| onSelected: () => { | ||
| if (isOffline) { | ||
| setIsOfflineModalVisible(true); | ||
| return; | ||
| } | ||
|
|
||
| if (!areItemsHydratedForReject) { | ||
| return; | ||
| } | ||
|
|
There was a problem hiding this comment.
@truph01 @mananjadhav We need to prevent copilots with limited access from rejecting expenses. You can refer to this bug for more context: #77609
7 participants
Explanation of Change
Undoes the revert of #72855.
Fixed Issues
$
PROPOSAL:
Tests
Prerequisites:
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.2025-11-13.at.17.51.48.mov
Android: mWeb Chrome
Screen.Recording.2025-11-13.at.17.48.49.mov
iOS: Native
Screen.Recording.2025-11-13.at.18.01.03.mov
iOS: mWeb Safari
Screen.Recording.2025-11-13.at.17.43.15.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-13.at.17.32.24.mov
MacOS: Desktop
Screen.Recording.2025-11-13.at.17.36.19.mov