[CP Staging] fix: remove the bulk reject option from search by mananjadhav · Pull Request #77014 · Expensify/App

mananjadhav · 2025-12-08T16:30:21Z

Explanation of Change

This thread on slack surfaced a potential issue with the bulk reject report prefetch logic. Every report that's not loaded in Onyx, is fetched using the OpenReport call, which not only time consuming but also a block request. Hence the App freezes/slows down. We're looking at alternative performant solutions, but for now we've decided to remove the bulk reject option.
This PR implements the minimal changes required to remove the bulk reject code from the menu including the performance-issue logic of report hydration. Essentially a soft revert for Feat/bulk reject v2 #75007

Fixed Issues

$ #52049
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Prerequisites:

Having a workspace, a workspace owner, a submitter
Delayed submissions and approvals enabled.

Steps

Create and submit a few expenses as a submitter
Go to the Account > Troubleshoot
Click on Clear cache and restart
Go to Reports > Approver
Open the Chrome Dev tools to check the Network request
Select 1-2 expenses
Observe that no OpenReport calls are made.
Click on the dropdown and check no Reject option is shown.

Offline tests

NA

QA Steps

// TODO: These must be filled out, or the issue title must include "[No QA]."

Same as Test Steps

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

mweb-chrome-remove-bulk-reject.mov

iOS: Native

ios-remove-bulk-reject.mov

iOS: mWeb Safari

mweb-safari-remove-bulk-reject.mov

MacOS: Chrome / Safari

web-remove-bulk-reject.mov

Verify Hold modal is not impacted

web-hold-modal.mov

codecov · 2025-12-08T16:39:24Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
src/pages/Search/SearchPage.tsx	`25.98% <ø> (+0.38%)`	⬆️
... and 9 files with indirect coverage changes

…ject-revert

melvin-bot · 2025-12-08T18:41:11Z

@jayeshmangwani Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

mananjadhav · 2025-12-08T18:43:56Z

@mountiny @lakchote For the review.

mananjadhav · 2025-12-08T19:16:19Z

I am getting an error on Reports page in Android.

android-error-on-search.mov

…ject-revert

mananjadhav · 2025-12-08T19:25:37Z

@truph01 Can review this as C+

truph01 · 2025-12-09T06:32:30Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-09.at.14.48.39.mov

Android: mWeb Chrome

Screen.Recording.2025-12-09.at.14.49.41.mov

iOS: HybridApp

Screen.Recording.2025-12-09.at.14.45.43.mov

iOS: mWeb Safari

Screen.Recording.2025-12-09.at.14.46.26.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-09.at.14.39.54.mov

…ject-revert

truph01 · 2025-12-09T07:40:42Z

@mananjadhav We have type error, could you fix it?

mananjadhav · 2025-12-09T07:59:10Z

I am not sure how this Type error occurred. I am afk and will be back in a few hours.

truph01 · 2025-12-09T08:37:16Z

@lakchote The typescript error doesn't cause by this PR, is it fine to ignore it?

lakchote · 2025-12-09T08:51:30Z

@lakchote The typescript error doesn't cause by this PR, is it fine to ignore it?

No it's not.
Typescript checks are passing for recent PRs:

Try to merge main again @mananjadhav?

…ject-revert

mananjadhav · 2025-12-09T09:11:13Z

Just synced again. Hopefully it should fix it 🤞

This thread is about the same type error, which seems to be merged in main already.

lakchote

LGTM

OSBotify · 2025-12-09T10:44:56Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

[CP Staging] fix: remove the bulk reject option from search (cherry picked from commit fa89a75) (cherry-picked to staging by mountiny)

OSBotify · 2025-12-09T16:43:08Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.74-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-10T21:41:21Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T21:57:35Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	failure ❌

OSBotify · 2025-12-10T22:07:06Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-10T23:02:00Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.74-12 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-11T00:00:20Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-12T19:02:16Z

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

OSBotify · 2025-12-12T22:07:26Z

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: remove the reject option from search

1ab6adf

melvin-bot bot assigned mananjadhav Dec 8, 2025

fix: lint error

f4ab16f

mananjadhav changed the title ~~fix: remove the reject option from search~~ fix: remove the bulk reject option from search Dec 8, 2025

mananjadhav added 2 commits December 8, 2025 23:53

Merge branch 'main' of github.com:mananjadhav/App into fix/mj-bulk-re…

cc16632

…ject-revert

fix: remove unused import

6ad633b

mananjadhav marked this pull request as ready for review December 8, 2025 18:41

mananjadhav requested review from a team as code owners December 8, 2025 18:41

melvin-bot bot requested review from jayeshmangwani and trjExpensify and removed request for a team December 8, 2025 18:41

melvin-bot bot removed the request for review from a team December 8, 2025 18:41

Merge branch 'main' of github.com:mananjadhav/App into fix/mj-bulk-re…

cd1abe3

…ject-revert

lakchote requested review from lakchote and truph01 and removed request for jayeshmangwani December 9, 2025 06:05

lakchote changed the title ~~fix: remove the bulk reject option from search~~ [CP Staging] fix: remove the bulk reject option from search Dec 9, 2025

Merge branch 'main' of github.com:mananjadhav/App into fix/mj-bulk-re…

b4f6041

…ject-revert

Merge branch 'main' of github.com:mananjadhav/App into fix/mj-bulk-re…

4817a82

…ject-revert

truph01 approved these changes Dec 9, 2025

View reviewed changes

lakchote approved these changes Dec 9, 2025

View reviewed changes

lakchote merged commit fa89a75 into Expensify:main Dec 9, 2025
31 checks passed

OSBotify pushed a commit that referenced this pull request Dec 9, 2025

Merge pull request #77014 from mananjadhav/fix/mj-bulk-reject-revert

1a6e978

[CP Staging] fix: remove the bulk reject option from search (cherry picked from commit fa89a75) (cherry-picked to staging by mountiny)

OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 9, 2025

OSBotify mentioned this pull request Dec 9, 2025

Deploy Checklist: New Expensify 2025-12-09 #77123

Closed

melvin-bot bot mentioned this pull request Dec 12, 2025

[Reject] [Tracking] Reject (fka Decline) Expense in NewDot #52049

Closed

21 tasks

Krishna2323 mentioned this pull request Dec 23, 2025

Implement bulk change approver flow for Search page v2 #77857

Open

53 tasks

Conversation

mananjadhav commented Dec 8, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Dec 8, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 8, 2025

Uh oh!

mananjadhav commented Dec 8, 2025

Uh oh!

mananjadhav commented Dec 8, 2025

Uh oh!

mananjadhav commented Dec 8, 2025

Uh oh!

truph01 commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

truph01 commented Dec 9, 2025

Uh oh!

mananjadhav commented Dec 9, 2025

Uh oh!

truph01 commented Dec 9, 2025

Uh oh!

lakchote commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mananjadhav commented Dec 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lakchote left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 9, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 10, 2025

Uh oh!

OSBotify commented Dec 11, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

mananjadhav commented Dec 8, 2025 •

edited

Loading

codecov bot commented Dec 8, 2025 •

edited by github-actions bot

Loading

truph01 commented Dec 9, 2025 •

edited

Loading

lakchote commented Dec 9, 2025 •

edited

Loading

mananjadhav commented Dec 9, 2025 •

edited

Loading