[Sentry] Setup performance metrics for open Create Expense by rinej · Pull Request #75309 · Expensify/App

rinej · 2025-11-17T14:48:30Z

Explanation of Change

PR introduces Manual metric to measure opening create expense modal send it to Sentry.
Start:
startMoneyRequest() in IOU.ts - when user taps FAB/quick action to create expense
End:
Multiple locations to cover all flow paths:
IOURequestStartPage.tsx - normal manual/scan flow
DistanceRequestStartPage.tsx - distance flow
IOURequestStepParticipants.tsx - when scan flow skips start page
IOURequestStepConfirmation.tsx - when scan flow goes direct to confirmation
Only the first one actually ends the span.
Measures time from "create expense initiated" to "form displayed" - it matches the existing Performance timing behavior.

Fixed Issues

$ #74135
PROPOSAL:

Tests

Click on Create Expense button
Wait until the Create Expense view or modal fully opens.
Navigate to Sentry and see new transactions under the ManualOpenCreateExpense name for your session.

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Screen.Recording.2025-11-19.at.12.04.15.mp4

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

codecov · 2025-11-17T15:00:30Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	`85.71% <ø> (ø)`
src/pages/iou/request/DistanceRequestStartPage.tsx	`0.00% <ø> (ø)`
src/pages/iou/request/IOURequestStartPage.tsx	`85.91% <ø> (ø)`
...es/iou/request/step/IOURequestStepConfirmation.tsx	`49.34% <100.00%> (+0.11%)`	⬆️
...es/iou/request/step/IOURequestStepParticipants.tsx	`0.00% <0.00%> (ø)`
src/libs/actions/IOU.ts	`64.39% <0.00%> (-0.30%)`	⬇️
... and 23 files with indirect coverage changes

melvin-bot · 2025-11-18T13:30:01Z

@tylerkaraszewski Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

rlinoz

Looks good, thanks!

rlinoz · 2025-11-18T14:09:30Z

src/libs/actions/IOU.ts

 ) {
    Performance.markStart(CONST.TIMING.OPEN_CREATE_EXPENSE);
+    startSpan(CONST.TELEMETRY.SPAN_OPEN_CREATE_EXPENSE, {
+        name: '/money-request-create',


NAB: Do we know the source route that is calling this? Might be beter as a description to the span.

+1 This would be great to actually know where this is being called from, that might require extra param to the method though

we will need to add the extra param everytime we call the startMoneyRequest OR just use this before starting the span:
const sourceRoute = Navigation.getActiveRoute(); and save it in the startSpan attribute

Maybe if we don't set a span.name is gets automatically set to Navigation.getActiveRoute()?

I added the sourceRoute in the span attributes, so it will be easier to filter by it

I renamed and moved the attributes names to CONST, as we agreed

mountiny · 2025-11-18T14:13:27Z

src/libs/actions/IOU.ts

 ) {
    Performance.markStart(CONST.TIMING.OPEN_CREATE_EXPENSE);
+    startSpan(CONST.TELEMETRY.SPAN_OPEN_CREATE_EXPENSE, {
+        name: '/money-request-create',


+1 This would be great to actually know where this is being called from, that might require extra param to the method though

mountiny · 2025-11-18T14:13:54Z

src/libs/actions/IOU.ts

    draftTransactions?: OnyxCollection<OnyxTypes.Transaction>,
 ) {
    Performance.markStart(CONST.TIMING.OPEN_CREATE_EXPENSE);
+    startSpan(CONST.TELEMETRY.SPAN_OPEN_CREATE_EXPENSE, {


Is this method also used for the native share menu?

I don't think so, it is used for the normal in-app expense creation flow, not the share extension flow.
I think we can add it, will have to figure it out. Most likely adding the start span in SubmitDetailsPage.tsx before initMoneyRequest function

heyjennahay · 2025-11-18T19:18:01Z

No product change, removing myself and unsubscribing

rlinoz

All yours @mountiny

rlinoz · 2025-11-19T12:06:09Z

oh actually @rinej there is a failing typecheck.

rinej · 2025-11-19T13:00:39Z

looks like it was failing on main, so not related to our changes. This is the PR with the fix -> https://github.com/Expensify/App/pull/75539/files

rlinoz · 2025-11-20T15:57:28Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Android: mWeb Chrome

iOS: HybridApp

iOS: mWeb Safari

MacOS: Chrome / Safari

MacOS: Desktop

OSBotify · 2025-11-20T16:24:31Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-11-21T12:27:37Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.62-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

izarutskaya · 2025-11-21T13:06:42Z

Hi @rinej Can you please share steps for QA team?

rlinoz · 2025-11-21T13:11:35Z

I will QA this, should have been internal.

rlinoz · 2025-11-21T13:15:39Z

Spans are showing up in Sentry 🎉

OSBotify · 2025-11-24T20:02:38Z

🚀 Deployed to production by https://github.com/marcaaron in version: 9.2.62-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

add open expense sentry span

333fd4e

melvin-bot bot assigned rinej Nov 17, 2025

rlinoz self-requested a review November 17, 2025 17:42

Merge branch 'main' into sentry-setup-metrics-for-open-create-expense

0210391

rinej marked this pull request as ready for review November 18, 2025 13:29

rinej requested review from a team as code owners November 18, 2025 13:29

melvin-bot bot requested review from heyjennahay and tylerkaraszewski and removed request for a team November 18, 2025 13:29

Merge branch 'main' into sentry-setup-metrics-for-open-create-expense

733ab2c

rlinoz previously approved these changes Nov 18, 2025

View reviewed changes

mountiny reviewed Nov 18, 2025

View reviewed changes

rinej mentioned this pull request Nov 18, 2025

[Sentry] Setup performance metrics for open Create Expense #74135

Closed

heyjennahay removed their request for review November 18, 2025 19:18

add sourceRoute as span attribute

5882e8a

rinej dismissed rlinoz’s stale review via 5882e8a November 19, 2025 11:14

Merge branch 'main' into sentry-setup-metrics-for-open-create-expense

5aff8d4

rlinoz previously approved these changes Nov 19, 2025

View reviewed changes

rinej added 2 commits November 19, 2025 14:01

Merge branch 'main' into sentry-setup-metrics-for-open-create-expense

eb9258a

Merge branch 'main' into sentry-setup-metrics-for-open-create-expense

0893b1d

rinej dismissed rlinoz’s stale review via 0893b1d November 20, 2025 11:15

rinej added 2 commits November 20, 2025 14:54

chore: move attributed names to CONST

af284ba

chore: disable eslint deprecation errors

3304d14

rlinoz approved these changes Nov 20, 2025

View reviewed changes

rlinoz merged commit e2cd238 into Expensify:main Nov 20, 2025
30 of 31 checks passed

OSBotify mentioned this pull request Nov 21, 2025

Deploy Checklist: New Expensify 2025-11-21 #75728

Closed

Conversation

rinej commented Nov 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

codecov bot commented Nov 17, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

heyjennahay commented Nov 18, 2025

Uh oh!

rlinoz left a comment

Choose a reason for hiding this comment

Uh oh!

rlinoz commented Nov 19, 2025

Uh oh!

rinej commented Nov 19, 2025

Uh oh!

rlinoz commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

Uh oh!

OSBotify commented Nov 20, 2025

Uh oh!

OSBotify commented Nov 21, 2025

Uh oh!

izarutskaya commented Nov 21, 2025

Uh oh!

rlinoz commented Nov 21, 2025

Uh oh!

rlinoz commented Nov 21, 2025

Uh oh!

OSBotify commented Nov 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

rinej commented Nov 17, 2025 •

edited

Loading

codecov bot commented Nov 17, 2025 •

edited by github-actions bot

Loading

rlinoz commented Nov 20, 2025 •

edited

Loading