Remove outdated fire modal dismissed#75384
Conversation
…age' into war-in/remove-outdated-fire-modal-dismissed
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
No product considerations. Removing my review! |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-hybrid.mp4Android: mWeb Chromeandroid-mweb.mp4iOS: HybridAppios-hybrid.moviOS: mWeb Safariios-mweb.movMacOS: Firefoxweb-firefox.mov |
|
This PR can be taken off HOLD |
# Conflicts: # src/libs/Navigation/Navigation.ts
|
@roryabraham done! all yours |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.73-0 🚀
|
|
🚀 Deployed to production by https://github.com/thienlnam in version: 9.2.73-5 🚀
|
Explanation of Change
Original PR introducing the InteractionManager usage - #64962
Fixed Issues
$ #71913
PROPOSAL:
Tests
(Firefox only)
Offline tests
QA Steps
(Firefox only)
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Firefox
Screen.Recording.2025-11-18.at.12.47.37.mov