Remove InteractionManager from WorkspaceInviteMessagePage#75381
Conversation
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
🚧 @mountiny has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
|
…e-message-page # Conflicts: # src/pages/workspace/WorkspaceInviteMessagePage.tsx
|
@ikevin127 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself. |
|
Please make sure to checkout the AI reviewer comments and flag to @kacper-mikolajczak @mateuuszzzzz if any are not correct |
|
Actually, the comments are pretty solid, great job implementing the reviewer! |
…e-message-page # Conflicts: # src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppandroid-hybrid.mp4Android: mWeb Chromeandroid-mweb.mp4iOS: HybridAppios-hybrid.moviOS: mWeb Safariios-mweb.movMacOS: Chrome / Safariweb.mov |
ikevin127
left a comment
There was a problem hiding this comment.
Tests well, good job on this one!
…e-message-page # Conflicts: # src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
…e-message-page # Conflicts: # src/libs/Navigation/AppNavigator/Navigators/RightModalNavigator.tsx
|
@roryabraham all yours! |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/roryabraham in version: 9.2.72-0 🚀
|
|
🚀 Deployed to production by https://github.com/jasperhuangg in version: 9.2.72-2 🚀
|
Explanation of Change
We often use InteractionManager to run some action after RHP (or any other modal) has been closed. The code looks generally like that
We can achieve the same result by passing the callback to dismissModal and running it once navigation ends
This PR makes RightModalNavigator emit an event on close so
dismissModalcan listen for itI used
WorkspaceInviteMessagePageas a good example of such a flow, but there are a lot of such usages (original PR adding InteractionManager to the mentioned component).Fixed Issues
$ #71913
PROPOSAL:
Tests
Offline tests
QA Steps
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
Screen.Recording.2025-11-18.at.12.28.57.mov
iOS: mWeb Safari
Screen.Recording.2025-11-18.at.12.31.17.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-18.at.11.46.58.mov
MacOS: Desktop