fix: Confirm details page blinks when import members with role column spreadsheet by nkdengineer · Pull Request #75515 · Expensify/App

nkdengineer · 2025-11-19T09:32:19Z

Explanation of Change

fix: Confirm details page blinks when import members with role column spreadsheet

Fixed Issues

$ #74907
PROPOSAL: #74907 (comment)

Tests

Create a Control Workspace
Go to Members
Import Spreadsheet with role column (File 1)
Complete the flow> Import
Click Got it on confirmation modal
Observe the RHP after clicking Got it
Verify that the confirmation page does not blink

Verify that no errors appear in the JS console

Offline tests

None

QA Steps

Create a Control Workspace
Go to Members
Import Spreadsheet with role column (File 1)
Complete the flow> Import
Click Got it on confirmation modal
Observe the RHP after clicking Got it
Verify that the confirmation page does not blink

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-11-19.at.16.05.07.mov

Android: mWeb Chrome

Screen.Recording.2025-11-19.at.16.23.38.mov

iOS: Native

Screen.Recording.2025-11-19.at.16.28.13.mov

iOS: mWeb Safari

Screen.Recording.2025-11-19.at.16.27.08.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-19.at.16.21.25.mov

MacOS: Desktop

Screen.Recording.2025-11-19.at.16.22.06.mov

… spreadsheet

melvin-bot · 2025-11-19T09:36:19Z

@shubham1206agra Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-19T09:44:37Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...rc/pages/workspace/members/ImportedMembersPage.tsx	`0.00% <0.00%> (ø)`
...kspace/members/ImportedMembersConfirmationPage.tsx	`0.00% <0.00%> (ø)`
... and 10 files with indirect coverage changes

JmillsExpensify

No review required from a product perspective. Unsubscribing.

shubham1206agra · 2025-11-21T13:42:15Z

@nkdengineer the flow is stuck on this page after importing the members.

nkdengineer · 2025-11-21T15:07:07Z

@nkdengineer the flow is stuck on this page after importing the members.

@shubham1206agra Is this the result after you clicking on the Got it button?

shubham1206agra · 2025-11-21T15:09:20Z

@nkdengineer the flow is stuck on this page after importing the members.

@shubham1206agra Is this the result after you clicking on the Got it button?

Yes

nkdengineer · 2025-11-23T15:06:30Z

@shubham1206agra I fixed.

shubham1206agra · 2025-11-25T17:06:06Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
xIf a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Screen.Recording.2025-11-25.at.10.34.00.PM.mov

rlinoz · 2025-11-26T11:51:11Z

src/pages/workspace/members/ImportedMembersConfirmationPage.tsx

                shouldHandleNavigationBack={false}
+                onModalHide={() => {
+                    // eslint-disable-next-line @typescript-eslint/no-deprecated
+                    InteractionManager.runAfterInteractions(() => Navigation.goBack(ROUTES.WORKSPACE_MEMBERS.getRoute(policyID)));


Hmm I think we are in the process of removing runAfterInteractions from the codebase, so ideally we should not be adding more.

@war-in any thoughts?

I think we could go with a similar approach to the one I created for RHP - #75381

But that probably would require ConfirmModal refactor

@rlinoz The import modal is just refactored and it's missed the navigation logic here. I only copied the logic on the ImportedMemberPage to fix this.

So once we get to remove from ImportedMembersPage we would end up refactoring the ConfirmModal and would fix this occurence as well?

cc: @war-in @nkdengineer on the above question above.

Yeah, I think so. If @nkdengineer is not adding the new InteractionManager usage, we should not remove the already existing one

OSBotify · 2025-12-01T23:43:14Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T13:55:54Z

🚀 Deployed to staging by https://github.com/rlinoz in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:51:20Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

fix: Confirm details page blinks when import members with role column…

d01ff63

… spreadsheet

melvin-bot bot assigned nkdengineer Nov 19, 2025

nkdengineer marked this pull request as ready for review November 19, 2025 09:36

nkdengineer requested review from a team as code owners November 19, 2025 09:36

melvin-bot bot requested review from JmillsExpensify and shubham1206agra and removed request for a team November 19, 2025 09:36

melvin-bot bot removed the request for review from a team November 19, 2025 09:36

JmillsExpensify reviewed Nov 19, 2025

View reviewed changes

nkdengineer added 2 commits November 23, 2025 21:55

Merge branch 'main' into fix/74907

ac6e7c7

fix navigation issue

5eafc8f

shubham1206agra approved these changes Nov 25, 2025

View reviewed changes

melvin-bot bot requested a review from rlinoz November 25, 2025 17:06

rlinoz requested changes Nov 26, 2025

View reviewed changes

rlinoz approved these changes Dec 1, 2025

View reviewed changes

rlinoz merged commit 7193a63 into Expensify:main Dec 1, 2025
37 checks passed

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

melvin-bot bot mentioned this pull request Dec 3, 2025

[Due for payment 2025-12-10] [$250] Confirm details page blinks when import members with role column spreadsheet #74907

Closed

8 tasks

blazejkustra mentioned this pull request Feb 20, 2026

[BATCH 3] Migrate Navigation usage v2 #83064

Open

Conversation

nkdengineer commented Nov 19, 2025

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 19, 2025

Uh oh!

codecov bot commented Nov 19, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

JmillsExpensify left a comment

Choose a reason for hiding this comment

Uh oh!

shubham1206agra commented Nov 21, 2025

Uh oh!

nkdengineer commented Nov 21, 2025

Uh oh!

shubham1206agra commented Nov 21, 2025

Uh oh!

nkdengineer commented Nov 23, 2025

Uh oh!

shubham1206agra commented Nov 25, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

rlinoz Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

war-in Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nkdengineer Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rlinoz Nov 26, 2025

Choose a reason for hiding this comment

Uh oh!

rlinoz Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

war-in Dec 1, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented Nov 19, 2025 •

edited by github-actions bot

Loading

war-in Nov 26, 2025 •

edited

Loading

nkdengineer Nov 26, 2025 •

edited

Loading