Include URL for workspace rules by marcochavezf · Pull Request #75450 · Expensify/App

marcochavezf · 2025-11-18T19:19:09Z

Explanation of Change

This PR adds a hyperlink to "workspace rules" in MCC categorization system messages when the user is a workspace admin. When Concierge automatically categorizes an expense based on MCC (Merchant Category Code) mapping rules, admins will now see a clickable "workspace rules" link that takes them directly to the workspace rules page

Key technical changes:

Modified ModifiedExpenseMessage.ts to detect admin status and generate hyperlinked text for MCC categorization
Updated message rendering in PureReportActionItem.tsx to use <RenderHTML> component for proper HTML anchor tag support
Added shouldConvertToLowercase parameter to preserve policyID casing in URLs (prevents .toLowerCase() from corrupting the href attribute)
Updated all 10 language files to support conditional hyperlink rendering

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/554975
PROPOSAL:

Tests

Pre-requisite:

Create a workspace and sync it with an integration so we auto-map categories from the integration into the workspace

As a workspace admin, import a card transaction that gets categorized via MCC rules
Navigate to the expense report containing the transaction
Verify Concierge's message shows "set the category based on workspace rules to [Category]" with "workspace rules" as a clickable blue link
Click the "workspace rules" link
Verify you navigate to the workspace rules page (URL should contain /workspaces/{POLICYID}/rules with correct casing)
As a non-admin user, view the same expense
Verify the message shows "set the category based on workspace rule to [Category]" with plain text (no link)

Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as the steps from the test section

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Android: mWeb Chrome

iOS: Native

iOS: mWeb Safari

MacOS: Chrome / Safari

Admin:

Employee:

MacOS: Desktop

…ultiple languages

…les based on user permissions

…th attribution sources

…vation for admin users and update test descriptions for clarity

melvin-bot · 2025-11-18T19:19:15Z

@linhvovan29546 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

codecov · 2025-11-18T19:30:07Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...ges/home/report/ContextMenu/ContextMenuActions.tsx	`0.87% <ø> (ø)`
...report/ContextMenu/BaseReportActionContextMenu.tsx	`0.00% <0.00%> (ø)`
src/pages/home/report/PureReportActionItem.tsx	`52.36% <0.00%> (ø)`
src/libs/ModifiedExpenseMessage.ts	`52.61% <69.56%> (+1.31%)`	⬆️
... and 13 files with indirect coverage changes

OSBotify · 2025-11-18T19:30:38Z

🦜 Polyglot Parrot! 🦜

Squawk! Looks like you added some shiny new English strings. Allow me to parrot them back to you in other tongues:

View the translation diff

diff --git a/src/languages/de.ts b/src/languages/de.ts
index f4db04e4..c49bf8d6 100644
--- a/src/languages/de.ts
+++ b/src/languages/de.ts
@@ -1335,7 +1335,7 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `änderte das ${translatedChangedField} zu ${newMerchant} (zuvor ${oldMerchant}), wodurch der Betrag auf ${newAmountToDisplay} aktualisiert wurde (zuvor ${oldAmountToDisplay})`,
         basedOnAI: 'basierend auf früheren Aktivitäten',
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `basierend auf <a href="${rulesLink}">Arbeitsbereichsregeln</a>` : 'basierend auf Arbeitsbereichsregel'),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `gemäß den <a href="${rulesLink}">Regeln des Arbeitsbereichs</a>` : 'gemäß der Arbeitsbereichsregel'),
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `für ${comment}` : 'Ausgabe'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `Rechnungsbericht Nr. ${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} gesendet${comment ? `für ${comment}` : ''}`,
diff --git a/src/languages/fr.ts b/src/languages/fr.ts
index 4669ee92..e1ec6475 100644
--- a/src/languages/fr.ts
+++ b/src/languages/fr.ts
@@ -1339,7 +1339,7 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `a changé le ${translatedChangedField} en ${newMerchant} (précédemment ${oldMerchant}), ce qui a mis à jour le montant à ${newAmountToDisplay} (précédemment ${oldAmountToDisplay})`,
         basedOnAI: "basé sur l'activité passée",
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `basé sur <a href="${rulesLink}">les règles de l'espace de travail</a>` : "basé sur la règle de l'espace de travail"),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `selon <a href="${rulesLink}">les règles de l'espace de travail</a>` : 'selon la règle de l’espace de travail'),
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `pour ${comment}` : 'dépense'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `Rapport de Facture n°${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} envoyé${comment ? `pour ${comment}` : ''}`,
diff --git a/src/languages/it.ts b/src/languages/it.ts
index 5b9f0368..308259f0 100644
--- a/src/languages/it.ts
+++ b/src/languages/it.ts
@@ -1333,7 +1333,8 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `ha cambiato il ${translatedChangedField} in ${newMerchant} (precedentemente ${oldMerchant}), il che ha aggiornato l'importo a ${newAmountToDisplay} (precedentemente ${oldAmountToDisplay})`,
         basedOnAI: 'basato su attività passate',
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `basato su <a href="${rulesLink}">regole dello spazio di lavoro</a>` : 'basato su regola dello spazio di lavoro'),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) =>
+            rulesLink ? `in base alle <a href="${rulesLink}">regole dello spazio di lavoro</a>` : 'in base alla regola dello spazio di lavoro',
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `per ${comment}` : 'spesa'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `Rapporto Fattura n. ${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} inviato${comment ? `per ${comment}` : ''}`,
diff --git a/src/languages/ja.ts b/src/languages/ja.ts
index 2aa9799e..96e5051a 100644
--- a/src/languages/ja.ts
+++ b/src/languages/ja.ts
@@ -1335,7 +1335,7 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `${translatedChangedField}を${newMerchant}に変更しました（以前は${oldMerchant}）、これにより金額が${newAmountToDisplay}に更新されました（以前は${oldAmountToDisplay}）。`,
         basedOnAI: '過去のアクティビティに基づく',
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `<a href="${rulesLink}">ワークスペースルール</a>に基づく` : 'ワークスペースルールに基づく'),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `<a href="${rulesLink}">ワークスペースのルール</a>に基づいて` : 'ワークスペースのルールに基づく'),
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `${comment}用` : '経費'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `請求書レポート #${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} 送信済み${comment ? `${comment} のために` : ''}`,
diff --git a/src/languages/nl.ts b/src/languages/nl.ts
index 53ccab58..a36413de 100644
--- a/src/languages/nl.ts
+++ b/src/languages/nl.ts
@@ -1333,7 +1333,7 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `veranderde de ${translatedChangedField} naar ${newMerchant} (voorheen ${oldMerchant}), wat het bedrag bijwerkte naar ${newAmountToDisplay} (voorheen ${oldAmountToDisplay})`,
         basedOnAI: 'op basis van eerdere activiteit',
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `op basis van <a href="${rulesLink}">werkruimteregels</a>` : 'op basis van werkruimteregel'),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `op basis van <a href="${rulesLink}">werkruimteregels</a>` : 'gebaseerd op werkruimteregel'),
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `voor ${comment}` : 'uitgave'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `Factuurrapport #${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} verzonden${comment ? `voor ${comment}` : ''}`,
diff --git a/src/languages/pl.ts b/src/languages/pl.ts
index 0a391c95..ab49d244 100644
--- a/src/languages/pl.ts
+++ b/src/languages/pl.ts
@@ -1332,7 +1332,7 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `zmienił ${translatedChangedField} na ${newMerchant} (wcześniej ${oldMerchant}), co zaktualizowało kwotę na ${newAmountToDisplay} (wcześniej ${oldAmountToDisplay})`,
         basedOnAI: 'na podstawie wcześniejszej aktywności',
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `na podstawie <a href="${rulesLink}">reguł przestrzeni roboczej</a>` : 'na podstawie reguły przestrzeni roboczej'),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `na podstawie <a href="${rulesLink}">zasad obszaru roboczego</a>` : 'na podstawie reguły obszaru roboczego'),
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `dla ${comment}` : 'wydatek'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `Raport faktury nr ${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} wysłano${comment ? `dla ${comment}` : ''}`,
diff --git a/src/languages/zh-hans.ts b/src/languages/zh-hans.ts
index 50da26db..f2729eb8 100644
--- a/src/languages/zh-hans.ts
+++ b/src/languages/zh-hans.ts
@@ -1313,7 +1313,7 @@ const translations: TranslationDeepObject<typeof en> = {
         updatedTheDistanceMerchant: ({translatedChangedField, newMerchant, oldMerchant, newAmountToDisplay, oldAmountToDisplay}: UpdatedTheDistanceMerchantParams) =>
             `将${translatedChangedField}更改为${newMerchant}（之前为${oldMerchant}），这更新了金额为${newAmountToDisplay}（之前为${oldAmountToDisplay}）`,
         basedOnAI: '基于过去的活动',
-        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `基于<a href="${rulesLink}">工作空间规则</a>` : '基于工作空间规则'),
+        basedOnMCC: ({rulesLink}: {rulesLink: string}) => (rulesLink ? `基于 <a href="${rulesLink}">工作区规则</a>` : '基于工作区规则'),
         threadExpenseReportName: ({formattedAmount, comment}: ThreadRequestReportNameParams) => `${formattedAmount} ${comment ? `为${comment}` : '费用'}`,
         invoiceReportName: ({linkedReportID}: OriginalMessage<typeof CONST.REPORT.ACTIONS.TYPE.REPORT_PREVIEW>) => `发票报告 #${linkedReportID}`,
         threadPaySomeoneReportName: ({formattedAmount, comment}: ThreadSentMoneyReportNameParams) => `${formattedAmount} 已发送${comment ? `对于${comment}` : ''}`,

Note

You can apply these changes to your branch by copying the patch to your clipboard, then running pbpaste | git apply 😉

…ing unnecessary whitespace and ensuring consistent formatting of policyID in test cases.

… clarity and consistency in messaging.

linhvovan29546 · 2025-11-19T05:01:49Z

Create a workspace and sync it with an integration so we auto-map categories from the integration into the workspace
As a workspace admin, import a card transaction that gets categorized via MCC rules

@marcochavezf How can I setup this, or do I just need to mock the data to test this PR?

marcochavezf · 2025-11-19T15:51:57Z

Create a workspace and sync it with an integration so we auto-map categories from the integration into the workspace
As a workspace admin, import a card transaction that gets categorized via MCC rules

@marcochavezf How can I setup this, or do I just need to mock the data to test this PR?

Just mocking the data will be fine, since I think there's no easy way to test this locally without having access to a local backend service

joekaufmanexpensify

Makes sense from a product perspective 👍

linhvovan29546

I mocked the data locally and it works as expected. But there are several deprecated

src/libs/ModifiedExpenseMessage.ts

tests/unit/ModifiedExpenseMessageTest.ts

…d SESSION

…icyID, improving type safety and clarity in context menus.

…s link generation for admin

marcochavezf · 2025-11-20T19:59:20Z

Updated, thanks for the review!

src/libs/ModifiedExpenseMessage.ts

…o ensure consistent lowercase formatting and adjust source attribution logic.

…re consistent lowercase formatting and modify source attribution logic to prevent unnecessary conversions.

marcochavezf · 2025-11-24T21:03:36Z

Updated, thanks for the review!

linhvovan29546 · 2025-11-25T02:03:48Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-11-25.at.09.18.17.mov

Android: mWeb Chrome

Screen.Recording.2025-11-25.at.09.19.40.mov

iOS: HybridApp

Screen.Recording.2025-11-25.at.09.14.00.mov

iOS: mWeb Safari

Screen.Recording.2025-11-25.at.09.15.41.mov

MacOS: Chrome / Safari

Screen.Recording.2025-11-25.at.09.11.10.mov

linhvovan29546

LGTM and works well.

Note: the unit tests are failing due to a lowercase. I’ll approve since the core feature works as expected. Feel free to merge after the tests are fixed.

melvin-bot · 2025-11-25T02:28:50Z

@srikarparsi Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

melvin-bot · 2025-11-25T02:28:53Z

🎯 @linhvovan29546, thanks for reviewing and testing this PR! 🎉

An E/App issue has been created to issue payment here: #75952.

marcochavezf · 2025-11-25T22:45:06Z

Jest Unit tests are passing now

melvin-bot · 2025-11-26T07:09:53Z

@roryabraham Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

linhvovan29546 · 2025-11-27T03:15:48Z

@srikarparsi All yours

OSBotify · 2025-12-01T23:43:08Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.67-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

kavimuru · 2025-12-02T19:39:32Z

@marcochavezf @jasperhuangg we can't test this step as we don't have card transactions.

As a workspace admin, import a card transaction that gets categorized via MCC rules

OSBotify · 2025-12-03T13:55:48Z

🚀 Deployed to staging by https://github.com/srikarparsi in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-03T14:51:14Z

🚀 Deployed to production by https://github.com/mountiny in version: 9.2.70-0 🚀

platform	result
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

tgolen · 2026-01-15T22:05:41Z

src/libs/ModifiedExpenseMessage.ts


 let allPolicyTags: OnyxCollection<PolicyTagLists> = {};
-Onyx.connect({
+Onyx.connectWithoutView({


@marcochavezf this is wrong. The functions using these values are connected to UI components. Please fix this ASAP, it is already causing problems with people following this anti-pattern.

Sure, working on this tomorrow morning

I'm getting up to date with the Onyx migration; it looks like the correct solution here is to migrate remaining callers (ReportActionItem.tsx, BrowserNotifications.ts, ReportUtils.ts, etc.) to use getForReportActionTemp, correct?

@tgolen AFAIK we need to update getForReportActionTemp to accept currentUserLogin as a parameter instead of reading it from Onyx.connect (because we added currentUserLogin in this PR). That would also updating both getForReportActionTemp and getForReportAction to accept a currentUserLogin parameter for this scope, right?

That sounds right, yeah. I haven't dug into it super close though.

Ok great, I outlined a plan here, since this requires multiple files, and I think we need to update them gradually in different PRs

marcochavezf added 4 commits November 18, 2025 12:27

Update translations to include dynamic links for workspace rules in m…

2045675

…ultiple languages

Enhance modified expense messages with dynamic links for workspace ru…

cd95612

…les based on user permissions

Capitalize "Category" in modified expense messages for consistency wi…

9a65aaa

…th attribution sources

Enhance ModifiedExpenseMessage tests to verify policyID casing preser…

432737c

…vation for admin users and update test descriptions for clarity

marcochavezf self-assigned this Nov 18, 2025

marcochavezf requested review from a team as code owners November 18, 2025 19:19

melvin-bot bot requested review from linhvovan29546 and removed request for a team November 18, 2025 19:19

melvin-bot bot requested review from joekaufmanexpensify and removed request for a team November 18, 2025 19:19

marcochavezf added 2 commits November 18, 2025 13:50

Refactor ModifiedExpenseMessageTest for improved readability by remov…

106fa9a

…ing unnecessary whitespace and ensuring consistent formatting of policyID in test cases.

Update translations for 'basedOnMCC' in multiple languages to improve…

5ab4d8a

… clarity and consistency in messaging.

joekaufmanexpensify previously approved these changes Nov 19, 2025

View reviewed changes

linhvovan29546 reviewed Nov 20, 2025

View reviewed changes

src/libs/ModifiedExpenseMessage.ts Outdated Show resolved Hide resolved

src/libs/ModifiedExpenseMessage.ts Show resolved Hide resolved

tests/unit/ModifiedExpenseMessageTest.ts Outdated Show resolved Hide resolved

marcochavezf added 4 commits November 20, 2025 13:01

Merge branch 'main' into marco-updateUrlMCCCategorization

e13e9f7

Refactor Onyx connection to use connectWithoutView for POLICY_TAGS an…

f2fc723

…d SESSION

Refactor report action handling to use policy directly instead of pol…

c41117d

…icyID, improving type safety and clarity in context menus.

Update test case for ModifiedExpenseMessage to clarify workspace rule…

cfbb31a

…s link generation for admin

marcochavezf dismissed joekaufmanexpensify’s stale review via cfbb31a November 20, 2025 19:35

marcochavezf requested a review from linhvovan29546 November 20, 2025 19:59

linhvovan29546 reviewed Nov 21, 2025

View reviewed changes

src/libs/ModifiedExpenseMessage.ts Outdated Show resolved Hide resolved

marcochavezf added 2 commits November 24, 2025 14:23

Merge branch 'main' into marco-updateUrlMCCCategorization

ccf04a9

Refactor category label handling in getForReportActionTemp function t…

fb570a7

…o ensure consistent lowercase formatting and adjust source attribution logic.

Update category label handling in getForReportAction function to ensu…

2260f3a

…re consistent lowercase formatting and modify source attribution logic to prevent unnecessary conversions.

marcochavezf requested a review from linhvovan29546 November 24, 2025 21:00

linhvovan29546 approved these changes Nov 25, 2025

View reviewed changes

melvin-bot bot requested a review from srikarparsi November 25, 2025 02:28

melvin-bot bot mentioned this pull request Nov 25, 2025

[Due 12/5/25] Payment issue for E/App PR#75450 #75952

Closed

marcochavezf added 2 commits November 25, 2025 15:31

Merge branch 'main' into marco-updateUrlMCCCategorization

3a5a1f5

Fix capitalization in ModifiedExpenseMessageTest expected results

74961e5

linhvovan29546 approved these changes Nov 26, 2025

View reviewed changes

melvin-bot bot requested a review from roryabraham November 26, 2025 07:09

Merge branch 'main' into marco-updateUrlMCCCategorization

1668a1f

srikarparsi approved these changes Nov 29, 2025

View reviewed changes

srikarparsi merged commit 964f725 into main Nov 29, 2025
43 of 44 checks passed

srikarparsi deleted the marco-updateUrlMCCCategorization branch November 29, 2025 01:38

This was referenced Nov 29, 2025

Investigate workflow job failing on main: test / test (job 5) #76314

Closed

Investigate workflow job failing on main: test / test (job 5) #76316

Closed

OSBotify mentioned this pull request Dec 1, 2025

Deploy Checklist: New Expensify 2025-12-01 #76460

Closed

tgolen reviewed Jan 15, 2026

View reviewed changes

marcochavezf mentioned this pull request Jan 23, 2026

[Due for payment 2026-03-24] Migrate ModifiedExpenseMessage.ts from Onyx.connect to useOnyx pattern #80263

Open

Conversation

marcochavezf commented Nov 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Nov 18, 2025

Uh oh!

codecov bot commented Nov 18, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

OSBotify commented Nov 18, 2025

🦜 Polyglot Parrot! 🦜

Uh oh!

linhvovan29546 commented Nov 19, 2025

Uh oh!

marcochavezf commented Nov 19, 2025

Uh oh!

joekaufmanexpensify left a comment

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

marcochavezf commented Nov 20, 2025

Uh oh!

Uh oh!

marcochavezf commented Nov 24, 2025

Uh oh!

linhvovan29546 commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

linhvovan29546 left a comment

Choose a reason for hiding this comment

Uh oh!

melvin-bot bot commented Nov 25, 2025

Uh oh!

melvin-bot bot commented Nov 25, 2025

Uh oh!

marcochavezf commented Nov 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

melvin-bot bot commented Nov 26, 2025

Uh oh!

linhvovan29546 commented Nov 27, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 1, 2025

Uh oh!

kavimuru commented Dec 2, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

OSBotify commented Dec 3, 2025

Uh oh!

tgolen Jan 15, 2026

Choose a reason for hiding this comment

Uh oh!

marcochavezf Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

marcochavezf Jan 16, 2026

Choose a reason for hiding this comment

Uh oh!

linhvovan29546 Jan 17, 2026

Choose a reason for hiding this comment

Uh oh!

tgolen Jan 20, 2026

Choose a reason for hiding this comment

marcochavezf commented Nov 18, 2025 •

edited

Loading

codecov bot commented Nov 18, 2025 •

edited by github-actions bot

Loading

linhvovan29546 commented Nov 25, 2025 •

edited

Loading

marcochavezf commented Nov 25, 2025 •

edited

Loading