-
Notifications
You must be signed in to change notification settings - Fork 3.7k
Include URL for workspace rules #75450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
2045675
Update translations to include dynamic links for workspace rules in m…
marcochavezf cd95612
Enhance modified expense messages with dynamic links for workspace ru…
marcochavezf 9a65aaa
Capitalize "Category" in modified expense messages for consistency wi…
marcochavezf 432737c
Enhance ModifiedExpenseMessage tests to verify policyID casing preser…
marcochavezf 106fa9a
Refactor ModifiedExpenseMessageTest for improved readability by remov…
marcochavezf 5ab4d8a
Update translations for 'basedOnMCC' in multiple languages to improve…
marcochavezf e13e9f7
Merge branch 'main' into marco-updateUrlMCCCategorization
marcochavezf f2fc723
Refactor Onyx connection to use connectWithoutView for POLICY_TAGS an…
marcochavezf c41117d
Refactor report action handling to use policy directly instead of pol…
marcochavezf cfbb31a
Update test case for ModifiedExpenseMessage to clarify workspace rule…
marcochavezf ccf04a9
Merge branch 'main' into marco-updateUrlMCCCategorization
marcochavezf fb570a7
Refactor category label handling in getForReportActionTemp function t…
marcochavezf 2260f3a
Update category label handling in getForReportAction function to ensu…
marcochavezf 3a5a1f5
Merge branch 'main' into marco-updateUrlMCCCategorization
marcochavezf 74961e5
Fix capitalization in ModifiedExpenseMessageTest expected results
marcochavezf 1668a1f
Merge branch 'main' into marco-updateUrlMCCCategorization
marcochavezf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@marcochavezf this is wrong. The functions using these values are connected to UI components. Please fix this ASAP, it is already causing problems with people following this anti-pattern.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, working on this tomorrow morning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm getting up to date with the Onyx migration; it looks like the correct solution here is to migrate remaining callers (ReportActionItem.tsx, BrowserNotifications.ts, ReportUtils.ts, etc.) to use getForReportActionTemp, correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tgolen AFAIK we need to update
getForReportActionTempto acceptcurrentUserLoginas a parameter instead of reading it fromOnyx.connect(because we addedcurrentUserLoginin this PR). That would also updating bothgetForReportActionTempandgetForReportActionto accept acurrentUserLoginparameter for this scope, right?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That sounds right, yeah. I haven't dug into it super close though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok great, I outlined a plan here, since this requires multiple files, and I think we need to update them gradually in different PRs