Implement bulk change approver flow for Search page

[QichenZhu]

Explanation of Change

Fixed Issues

$ #75220
PROPOSAL:

Tests

Same as QA Steps.

• Verify that no errors appear in the JS console

Offline tests

N/A.

QA Steps

Preconditions

1. Create three accounts: A, B, and C.
2. Account A has three Control plan workspaces with Submission frequency set to Manually and Add approvals enabled.
3. Account A has submitted one expense in each of the three Control workspaces.
4. Account B is a member of all three Control workspaces and can approve.
5. Account C is a member of only one of the three Control workspaces.
6. Create two additional non-Control workspaces (NonControl-1 and NonControl-2) with Add approvals enabled, and have Account A submit one expense in each.

Test 1: Bulk Add Approver

1. Go to Reports → Reports.
2. Open the Workspace filter and select the three Control workspaces, then tap Apply.
3. Select any two of the reports created in the Preconditions.
4. Tap “2 selected → Change approver.”
5. Tap “Add approver → Change approver.”
6. Select Account B and save.
7. Verify the Action column for those two reports no longer shows Approve.

Test 2: Bulk Bypass Approver

1. Select all three reports created in the Control workspaces.
2. Tap “3 selected → Change approver.”
3. Tap “Bypass approvers → Change approver.”
4. Verify the Action column for all three reports shows Approve.

Test 3: Account C Visibility Rules

A. Multi-policy selection (C should NOT appear)

1. With all three Control workspaces filtered, select two or more reports across different workspaces.
2. Tap “X selected → Change approver.”
3. Tap “Add approver → Change approver.”
4. Verify Account C does not appear.

B. Single-policy selection (C may appear)

1. Filter to only the Control workspace where Account C is a member.
2. Select the report from that workspace.
3. Tap “1 selected → Change approver.”
4. Tap “Add approver → Change approver.”
5. Verify Account C appears only if C can approve the report and is not already the approver.

Test 4: Single Non-Upgraded (Non-Control) Policy Selected

1. Filter to NonControl-1 only.
2. Select its report.
3. Tap “1 selected → Change approver.”
4. Tap “Add approver → Change approver.”
5. Verify you are redirected to the workspace upgrade screen for NonControl-1.
6. Navigate back and verify no changes were applied.

Test 5: Two Non-Upgraded (Non-Control) Policies Selected

1. Filter to NonControl-1 and NonControl-2.
2. Select one report from each.
3. Tap “2 selected → Change approver.”
4. Tap “Add approver → Change approver.”
5. Verify you are redirected to the general workspace upgrade screen.
6. Navigate back and verify no changes were applied.

Test 6: Mixed State Skip Behavior

1. Select one report already assigned to Account A and one report not assigned to A.
2. Tap “X selected → Change approver → Bypass approvers → Change approver.”
3. Verify the report already assigned to A remains unchanged and the other report changes to A.

• Verify that no errors appear in the JS console

PR Author Checklist

• I linked the correct issue in the ### Fixed Issues section above
• I wrote clear testing steps that cover the changes made in this PR
  • I added steps for local testing in the Tests section
  • I added steps for the expected offline behavior in the Offline steps section
  • I added steps for Staging and/or Production testing in the QA steps section
  • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
  • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
• I included screenshots or videos for tests on all platforms
• I ran the tests on all platforms & verified they passed on:
  • Android: Native
  • Android: mWeb Chrome
  • iOS: Native
  • iOS: mWeb Safari
  • MacOS: Chrome / Safari
• I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
• I verified there are no new alerts related to the canBeMissing param for useOnyx
• I followed proper code patterns (see Reviewing the code)
  • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
  • I verified that comments were added to code that is not self explanatory
  • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
  • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
  • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
  • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
  • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
  • I verified the JSDocs style guidelines (in STYLE.md) were followed
• If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
• I followed the guidelines as stated in the Review Guidelines
• I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
• I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
• I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
• I verified that if a function's arguments changed that all usages have also been updated correctly
• If any new file was added I verified that:
  • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
• If a new CSS style is added I verified that:
  • A similar style doesn't already exist
  • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
• If new assets were added or existing ones were modified, I verified that:
  • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
  • The assets load correctly across all supported platforms.
• If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
• If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
• If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
• If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
• If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
  • I verified that all the inputs inside a form are aligned with each other.
  • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
• If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
• I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
• If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native

android-native-1.webm

android-native-2.webm

android-native-3.webm

android-native-4.webm

android-native-5.webm

android-native-6.webm

Android: mWeb Chrome

android-web-1.webm

android-web-2.webm

android-web-3.webm

android-web-4.webm

android-web-5.webm

android-web-6.webm

iOS: Native

ios-native-1.mov

ios-native-2.mov

ios-native-3.mov

ios-native-4.mov

ios-native-5.mov

ios-native-6.mov

iOS: mWeb Safari

ios-web-1.mov

ios-web-2.mov

ios-web-3.mov

ios-web-4.mov

ios-web-5.mov

ios-web-6.mov

MacOS: Chrome / Safari

mac-web-1.mov

mac-web-2.mov

mac-web-3.mov

mac-web-4.mov

mac-web-5.mov

mac-web-6.mov

[melvin-bot]

Hey, I noticed you changed src/languages/en.ts in a PR from a fork. For security reasons, translations are not generated automatically for PRs from forks.

If you want to automatically generate translations for other locales, an Expensify employee will have to:

1. Look at the code and make sure there are no malicious changes.
2. Run the Generate static translations GitHub workflow. If you have write access and the K2 extension, you can simply click: [this button]

Alternatively, if you are an external contributor, you can run the translation script locally with your own OpenAI API key. To learn more, try running:

npx ts-node ./scripts/generateTranslations.ts --help

Typically, you'd want to translate only what you changed by running npx ts-node ./scripts/generateTranslations.ts --compare-ref main

[codecov]

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/CONST/index.ts	85.84% <ø> (ø)
src/ROUTES.ts	13.22% <ø> (ø)
src/SCREENS.ts	100.00% <ø> (ø)
src/components/Search/SearchContext.tsx	56.00% <100.00%> (+22.66%)	⬆️
...ts/SelectionListWithSections/Search/ActionCell.tsx	56.00% <ø> (ø)
...avigation/linkingConfig/RELATIONS/SEARCH_TO_RHP.ts	100.00% <ø> (ø)
src/libs/Navigation/linkingConfig/config.ts	75.00% <ø> (ø)
src/libs/SearchUIUtils.ts	73.38% <100.00%> (+0.23%)	⬆️
src/pages/ReportChangeApproverPage.tsx	0.00% <ø> (ø)
...gation/AppNavigator/ModalStackNavigators/index.tsx	8.43% <0.00%> (-0.03%)	⬇️
... and 3 more
... and 5 files with indirect coverage changes

[melvin-bot]

@Krishna2323 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

[Krishna2323]

@QichenZhu I'll start reviewing this tomorrow morning, but let me know if it's urgent.

[QichenZhu]

@Krishna2323 thanks! No rush.

Text copy is waiting for approval, then I'll ask to confirm the Spanish translation. Approved.

Other than that, this PR is ready for review.

[QichenZhu]

@marcaaron @Krishna2323 good point! These warnings definitely need to be fixed, but since they are on main too, how about cleaning them up in a separate PR to avoid conflicts with this one, in case someone else is also working on them?

[marcaaron]

LGTM

[marcaaron]

Select all three expenses created in the Control workspaces.

This seems ready, but let's make sure to update the QA steps so they are a bit clearer and mention selecting reports and not expenses.

[QichenZhu]

let's make sure to update the QA steps so they are a bit clearer and mention selecting reports and not expenses.

Done.

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.75-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.77-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	cancelled 🔪
🍎 iOS 🍎	cancelled 🔪

[OSBotify]

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to staging by https://github.com/marcaaron in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

[OSBotify]

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅