Trigger whisper when user invites a member to the chat #75778
Conversation
|
@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
|
@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
heyjennahay
left a comment
There was a problem hiding this comment.
No concern with product change
|
@parasharrajat @DylanDylann seems like we're out of the woods now with all the blockers from last week. Some were actually already happening in prod and were mistakenly assumed to be due to this PR, but some others were fixed by reverting the PR. I went around and closed those issues and linked this new PR to those, which you can see in the list above this comment (4 total). Can we test for those bugs this week, and I can make any BE changes if any is needed? Let's try to find out what happened first, since it was definitely surprising to see so many blockers from what seems like a minor logic change in the PR. Let me know if I can help in any way, need to shift focus to another issue at the moment but will jump on any BE write or payload changes you find are needed if any. Thank you! |
|
PS: Also this issue should be tested as well: #75754 |
|
@DylanDylann can you continue the review here? It is ready. |
|
@parasharrajat Could you confirm that all regression issues will be addressed in this PR? |
…ert-71280-revert-70755-revert-69844-parasharrajat/member
|
@DylanDylann I couldn't reproduce this #75766, and the other seems backend issue. This is ready for your testing. 30.11.2025_16.25.46_REC.mp4 |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppScreen.Recording.2025-11-10.at.14.59.37.movAndroid: mWeb ChromeScreen.Recording.2025-11-10.at.14.55.56.moviOS: HybridAppScreen.Recording.2025-11-10.at.14.56.28.moviOS: mWeb SafariScreen.Recording.2025-11-10.at.14.55.11.movMacOS: Chrome / SafariScreen.Recording.2025-11-10.at.14.52.31.movMacOS: DesktopScreen.Recording.2025-11-10.at.14.58.44.mov |
|
Can't reproduce #75744 Screen.Recording.2025-12-01.at.09.38.16.mov |
|
I can reproduce #75769 and it doesn't look like a BE bug. @parasharrajat Please check again Screen.Recording.2025-12-01.at.09.42.24.mov |
|
Yeah, i will hide the button. |
|
Can't reproduce #75740 Screen.Recording.2025-12-01.at.09.44.59.mov |
|
Fixed. Jest tests are failing on main. |
|
Jest Unit Tests / test (job 8) (pull_request) may be fixed on main, you can try pull the latest main |
|
Not yet fixed. |
…0755-revert-69844-parasharrajat/member
|
@parasharrajat Could you merge the new main? |
…0755-revert-69844-parasharrajat/member
|
Done, but this check failure happens on main. |
|
@DylanDylann is there something that needs to be changed from backend? Otherwise this is ready @carlosmiceli |
I am not sure, what do you want to refer here? |
|
I mean out of all reported bugs, do we need to tackle any? I believe mostly they were backend so i directly referred as backend bugs? |
|
None of them can reproduce now. I think we are fine to move forward |
|
@carlosmiceli All yours. Can you please check whether there were some changes at backend so that we can't reproduce these bugs now? |
|
@carlosmiceli Can you please review this? |
|
Sorry, was OOO the last few days, there seems to be some lint error and then I can review! |
…ert-71280-revert-70755-revert-69844-parasharrajat/member
|
@carlosmiceli Should be good now. |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.75-0 🚀
|
|
🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.77-0 🚀
|
|
🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀
|
Explanation of Change
Fixed Issues
$ #69194
PROPOSAL: #69194
Tests
Offline tests
This feature does not work offline.
QA Steps
same as tests.
--->
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
12.09.2025_20.39.32_REC.mp4
iOS: Native
12.09.2025_21.52.04_REC.mp4
iOS: mWeb Safari
12.09.2025_21.44.42_REC.mp4
MacOS: Chrome / Safari
12.09.2025_20.35.31_REC.mp4
MacOS: Desktop
12.09.2025_20.45.36_REC.mp4