Skip to content

Trigger whisper when user invites a member to the chat #75778

Merged
carlosmiceli merged 8 commits intoExpensify:mainfrom
parasharrajat:revert-75762-revert-71280-revert-70755-revert-69844-parasharrajat/member
Dec 10, 2025
Merged

Trigger whisper when user invites a member to the chat #75778
carlosmiceli merged 8 commits intoExpensify:mainfrom
parasharrajat:revert-75762-revert-71280-revert-70755-revert-69844-parasharrajat/member

Conversation

@parasharrajat
Copy link
Member

Explanation of Change

Fixed Issues

$ #69194
PROPOSAL: #69194

Tests

  1. Open a workspace chat.
  2. Go to details > members.
  3. Click Invite member to go to invite memeber page.
  4. Select a few members.
  5. Click invite.
  6. Verify that you are taken to the report page and the concierge whisper is shown to invite those members.
image 8. Select any option and verify that the result is as per expected behaviour of the whisper.
  • Verify that no errors appear in the JS console

Offline tests

This feature does not work offline.

QA Steps

same as tests.

--->
// TODO: These must be filled out, or the issue title must include "[No QA]."

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

Android: Native
Android: mWeb Chrome
12.09.2025_20.39.32_REC.mp4
iOS: Native
12.09.2025_21.52.04_REC.mp4
iOS: mWeb Safari
12.09.2025_21.44.42_REC.mp4
MacOS: Chrome / Safari
12.09.2025_20.35.31_REC.mp4
MacOS: Desktop
12.09.2025_20.45.36_REC.mp4

@parasharrajat parasharrajat requested review from a team as code owners November 21, 2025 17:15
@melvin-bot melvin-bot bot requested review from DylanDylann and removed request for a team November 21, 2025 17:15
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2025

@DylanDylann Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot requested review from a team, carlosmiceli and heyjennahay and removed request for a team November 21, 2025 17:15
@melvin-bot
Copy link

melvin-bot bot commented Nov 21, 2025

@carlosmiceli Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@melvin-bot melvin-bot bot removed the request for review from a team November 21, 2025 17:15
@codecov
Copy link

codecov bot commented Nov 21, 2025

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines Coverage Δ
src/pages/RoomInvitePage.tsx 0.00% <0.00%> (ø)
src/pages/home/report/PureReportActionItem.tsx 52.12% <0.00%> (-0.08%) ⬇️
src/libs/actions/Report.ts 54.16% <0.00%> (-0.11%) ⬇️
src/libs/ReportActionsUtils.ts 50.27% <0.00%> (-0.15%) ⬇️
... and 5 files with indirect coverage changes

heyjennahay
heyjennahay previously approved these changes Nov 21, 2025
Copy link
Contributor

@heyjennahay heyjennahay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No concern with product change

@carlosmiceli
Copy link
Contributor

@parasharrajat @DylanDylann seems like we're out of the woods now with all the blockers from last week. Some were actually already happening in prod and were mistakenly assumed to be due to this PR, but some others were fixed by reverting the PR. I went around and closed those issues and linked this new PR to those, which you can see in the list above this comment (4 total). Can we test for those bugs this week, and I can make any BE changes if any is needed? Let's try to find out what happened first, since it was definitely surprising to see so many blockers from what seems like a minor logic change in the PR.

Let me know if I can help in any way, need to shift focus to another issue at the moment but will jump on any BE write or payload changes you find are needed if any. Thank you!

@carlosmiceli
Copy link
Contributor

PS: Also this issue should be tested as well: #75754

@parasharrajat
Copy link
Member Author

@DylanDylann can you continue the review here? It is ready.

@DylanDylann
Copy link
Contributor

@parasharrajat Could you confirm that all regression issues will be addressed in this PR?

…ert-71280-revert-70755-revert-69844-parasharrajat/member
@parasharrajat
Copy link
Member Author

parasharrajat commented Nov 30, 2025

@DylanDylann I couldn't reproduce this #75766, and the other seems backend issue. This is ready for your testing.

30.11.2025_16.25.46_REC.mp4

@DylanDylann
Copy link
Contributor

Reviewer Checklist

  • I have verified the author checklist is complete (all boxes are checked off).
  • I verified the correct issue is linked in the ### Fixed Issues section above
  • I verified testing steps are clear and they cover the changes made in this PR
    • I verified the steps for local testing are in the Tests section
    • I verified the steps for Staging and/or Production testing are in the QA steps section
    • I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
  • I checked that screenshots or videos are included for tests on all platforms
  • I included screenshots or videos for tests on all platforms
  • I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
  • I verified tests pass on all platforms & I tested again on:
    • Android: HybridApp
    • Android: mWeb Chrome
    • iOS: HybridApp
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
    • MacOS: Desktop
  • If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
  • I verified there are no new alerts related to the canBeMissing param for useOnyx
  • I verified proper code patterns were followed (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I verified that this PR follows the guidelines as stated in the Review Guidelines
  • I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • If a new component is created I verified that:
    • A similar component doesn't exist in the codebase
    • All props are defined accurately and each prop has a /** comment above it */
    • The file is named correctly
    • The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
    • The only data being stored in the state is data necessary for rendering and nothing else
    • For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
    • Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
    • All JSX used for rendering exists in the render method
    • The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
  • I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp
Screen.Recording.2025-11-10.at.14.59.37.mov
Android: mWeb Chrome
Screen.Recording.2025-11-10.at.14.55.56.mov
iOS: HybridApp
Screen.Recording.2025-11-10.at.14.56.28.mov
iOS: mWeb Safari
Screen.Recording.2025-11-10.at.14.55.11.mov
MacOS: Chrome / Safari
Screen.Recording.2025-11-10.at.14.52.31.mov
MacOS: Desktop
Screen.Recording.2025-11-10.at.14.58.44.mov

@DylanDylann
Copy link
Contributor

Can't reproduce #75744

Screen.Recording.2025-12-01.at.09.38.16.mov

@DylanDylann
Copy link
Contributor

I can reproduce #75769 and it doesn't look like a BE bug. @parasharrajat Please check again

Screen.Recording.2025-12-01.at.09.42.24.mov

@parasharrajat
Copy link
Member Author

Yeah, i will hide the button.

@DylanDylann
Copy link
Contributor

Can't reproduce #75740

Screen.Recording.2025-12-01.at.09.44.59.mov

@parasharrajat
Copy link
Member Author

Fixed. Jest tests are failing on main.

@DylanDylann
Copy link
Contributor

Jest Unit Tests / test (job 8) (pull_request) may be fixed on main, you can try pull the latest main

@parasharrajat
Copy link
Member Author

Not yet fixed.

@DylanDylann
Copy link
Contributor

@parasharrajat Could you merge the new main?

@parasharrajat
Copy link
Member Author

Done, but this check failure happens on main.

@parasharrajat
Copy link
Member Author

@DylanDylann is there something that needs to be changed from backend? Otherwise this is ready @carlosmiceli

@DylanDylann
Copy link
Contributor

@DylanDylann is there something that needs to be changed from backend?

I am not sure, what do you want to refer here?

@parasharrajat
Copy link
Member Author

I mean out of all reported bugs, do we need to tackle any? I believe mostly they were backend so i directly referred as backend bugs?

@DylanDylann
Copy link
Contributor

None of them can reproduce now. I think we are fine to move forward

@parasharrajat
Copy link
Member Author

@carlosmiceli All yours. Can you please check whether there were some changes at backend so that we can't reproduce these bugs now?

@parasharrajat
Copy link
Member Author

@carlosmiceli Can you please review this?

@carlosmiceli
Copy link
Contributor

Sorry, was OOO the last few days, there seems to be some lint error and then I can review!

@parasharrajat
Copy link
Member Author

@carlosmiceli Should be good now.

@carlosmiceli carlosmiceli merged commit 5a2c4e2 into Expensify:main Dec 10, 2025
30 checks passed
@OSBotify
Copy link
Contributor

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.75-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.75-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

🚀 Deployed to staging by https://github.com/carlosmiceli in version: 9.2.77-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 cancelled 🔪
🍎 iOS 🍎 cancelled 🔪

@OSBotify
Copy link
Contributor

🚀 Deployed to production by https://github.com/yuwenmemon in version: 9.2.77-1 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants