Tax field on unreported expense#76636
Conversation
melvin-bot
bot
requested review from
heyjennahay and
parasharrajat
and removed request for
a team
|
@parasharrajat Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| const [reportPolicy] = useOnyx(`${ONYXKEYS.COLLECTION.POLICY}${report?.policyID}`, {canBeMissing: true}); | ||
| const policy = isUnreportedExpense || isCreatingTrackExpense ? policyForMovingExpenses : reportPolicy; | ||
|
|
||
| return {policy}; |
There was a problem hiding this comment.
❌ PERF-4 (docs)
This hook returns a new object literal on every render, which causes unnecessary re-renders in consuming components. React uses referential equality to determine if props changed, so a new object instance triggers re-renders even when the actual data hasn't changed.
Suggested fix: Wrap the return value in useMemo to maintain referential stability:
return useMemo(
() => ({policy}),
[policy]
);There was a problem hiding this comment.
@koko57 Let's optimize this. Can we just return policy directly?
|
Will test this once all backend issues are resolved. |
|
@parasharrajat PR ready for review |
| @@ -1727,7 +1728,7 @@ function getWorkspaceTaxesSettingsName(policy: OnyxEntry<Policy>, taxCode: strin | |||
| */ | |||
| function getTaxName(policy: OnyxEntry<Policy>, transaction: OnyxEntry<Transaction>) { | |||
| const defaultTaxCode = getDefaultTaxCode(policy, transaction); | |||
| return Object.values(transformedTaxRates(policy, transaction)).find((taxRate) => taxRate.code === (transaction?.taxCode ?? defaultTaxCode))?.modifiedName; | |||
| return Object.values(transformedTaxRates(policy, transaction)).find((taxRate) => taxRate.code === (transaction?.taxCode || defaultTaxCode))?.modifiedName; | |||
There was a problem hiding this comment.
Please add a detailed comment on why we need || here
There was a problem hiding this comment.
I don't know why this change isn't displayed as I added the comment
There was a problem hiding this comment.
still, I think it's pretty obvious why we would want || instead of ?? - the first value might be an empty string or zero that we want to ignore as it's falsy
|
|
BUG: Taxes page show empty list when user submit to someone while offline. Reason: the workspace taxes are not loaded yet which caused this issue. Steps:
10.12.2025_15.49.22_REC.mp4 |
|
BUG: the violations are shown in self DM expenses. I thought we disabled violatios on self DM Steps:
10.12.2025_15.54.32_REC.mp4 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@koko57 Can you please merge main as I see that issue on this PR only? |
This comment was marked as resolved.
This comment was marked as resolved.
so not a FE issue |
but it's out of the scope of this PR if it's error on different field |
It is as user is offline so it will not call the API to get the data then user will stuck in a loop that tax is not valid and won't be able to create the expense offline. |
|
@cristipaval should we get the default policy's data on the startup then? |
|
@parasharrajat I merged with main, can you check those issues you weren't sure about?
also can you share repro steps with all the details, I checked it yesterday first and it was working |
@parasharrajat have you checked on a newly created expense? There could be a problem with the old ones |
|
Let me check again. |
|
@koko57 I have hid all the issues that are resolved. |
|
So, except for this #76636 (comment) we are all good. |
|
@parasharrajat |
this is expected, as we can't load the taxes for the policy while offline 👍 |
Also, this problem can be reproduced in the current staging as follows:
Issue: The Tax Rate field is empty, and when you click on it, you get an empty list to pick from |
|
@koko57 Please resolve conflicts. |
Screenshots🔲 iOS / native29.11.2025_14.05.33_REC.mp4🔲 iOS / Safari29.11.2025_14.08.51_REC.mp4🔲 MacOS / Chrome29.11.2025_13.16.12_REC.mp4🔲 Android / Chrome29.11.2025_14.11.17_REC.mp4🔲 Android / native29.11.2025_13.51.32_REC.mp429.11.2025_13.53.30_REC.mp4 |
parasharrajat
left a comment
parasharrajat
left a comment
There was a problem hiding this comment.
Reviewer Checklist
- I have verified the author checklist is complete (all boxes are checked off).
- I verified the correct issue is linked in the
### Fixed Issuessection above - I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the
Testssection - I verified the steps for Staging and/or Production testing are in the
QA stepssection - I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
- I verified the steps for local testing are in the
- I checked that screenshots or videos are included for tests on all platforms
- I included screenshots or videos for tests on all platforms
- I verified tests pass on all platforms & I tested again on:
- Android: Native
- Android: mWeb Chrome
- iOS: Native
- iOS: mWeb Safari
- MacOS: Chrome / Safari
- MacOS: Desktop
- If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
- I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
toggleReportand notonIconClick). - I verified that the left part of a conditional rendering a React component is a boolean and NOT a string, e.g.
myBool && <MyComponent />. - I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to
src/languages/*files and using the translation method - I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is approved by marketing by adding the
Waiting for Copylabel for a copy review on the original GH to get the correct copy. - I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in
STYLE.md) were followed
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e.
- If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
- I verified that this PR follows the guidelines as stated in the Review Guidelines
- I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like
Avatar, I verified the components usingAvatarhave been tested & I retested again) - I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
- I verified any variables that can be defined as constants (ie. in CONST.js or at the top of the file that uses the constant) are defined as such
- If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a
/** comment above it */ - The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to
thisproperly so there are no scoping issues (i.e. foronClick={this.submit}the methodthis.submitshould be bound tothisin the constructor) - Any internal methods bound to
thisare necessary to be bound (i.e. avoidthis.submit = this.submit.bind(this);ifthis.submitis never passed to a component event handler likeonClick) - All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
- If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
- If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e.
StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
- If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
- If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like
Avataris modified, I verified thatAvataris working as expected in all cases) - If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
- If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
- If the PR modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added
Designlabel so the design team can review the changes.
- If a new page is added, I verified it's using the
ScrollViewcomponent to make it scrollable when more elements are added to the page. - If the
mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps. - I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.
🎀 👀 🎀 C+ reviewed
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/cristipaval in version: 9.2.78-0 🚀
|
|
@koko57 I think this introduced this deploy blocker? Can you check? |
|
🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀
|
5 participants
Reapplying changes from #74441 reverted in #76502
Explanation of Change
Fixed Issues
$ #72238
PROPOSAL:
Tests
Prerequisites: SelfDM, create several tracked expenses
Tracked Expenses
User with no workspace / User with several non-default workspaces
User with a default workspace / only one non-default workspace
Taxes not enabled
Taxes enabled
OR
Submitting the expense to the default workspace
Prerequisites: another workspace with taxes enabled
Submitting the expense to a different workspace with taxes enabled
Creating a tracked expense
User with no workspace / User with several non-default workspaces
User with a default workspace / only one non-default workspace
Taxes not enabled
Taxes enabled
Fixed frontend issue: #76495
Prerequisites: default tax rate for a foreign currency
Offline tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari
Screen.Recording.2025-11-06.at.16.12.58.mp4
Screen.Recording.2025-11-06.at.16.12.42.mp4