Skip to content

[CP Staging][Fix Deploy Blocker] Revert "Tax field on unreported expense"#77741

Merged
mountiny merged 1 commit intomainfrom
revert-76636-feat/72238-taxes-field-v2
Dec 16, 2025
Merged

[CP Staging][Fix Deploy Blocker] Revert "Tax field on unreported expense"#77741
mountiny merged 1 commit intomainfrom
revert-76636-feat/72238-taxes-field-v2

Conversation

@grgia
Copy link
Contributor

@grgia grgia commented Dec 16, 2025 •
edited
Loading

Reverts #76636

Fixes #77599

@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

🚧 @grgia has triggered a test Expensify/App build. You can view the workflow run here.

@grgia grgia mentioned this pull request Dec 16, 2025
Closed
7 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Dec 16, 2025

🧪🧪 Use the links below to test this adhoc build on Android, iOS, Desktop, and Web. Happy testing! 🧪🧪
Built from App PR #77741.

Android 🤖 iOS 🍎
⏩ SKIPPED ⏩ ⏩ SKIPPED ⏩
The build for Android was skipped The build for iOS was skipped
Desktop 💻 Web 🕸️
⏩ SKIPPED ⏩ https://77741.pr-testing.expensify.com
The build for Desktop was skipped Web

👀 View the workflow run that generated this build 👀

@codecov
Copy link

codecov bot commented Dec 16, 2025 •
edited by github-actions bot
Loading

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines Coverage Δ
.../components/MoneyRequestConfirmationListFooter.tsx 84.32% <100.00%> (+0.02%) ⬆️
src/libs/PolicyUtils.ts 55.20% <100.00%> (ø)
src/libs/TransactionUtils/index.ts 71.64% <100.00%> (ø)
src/libs/actions/IOU.ts 64.93% <100.00%> (+0.22%) ⬆️
...rc/pages/iou/request/step/IOURequestStepAmount.tsx 6.52% <ø> (+0.07%) ⬆️
...es/iou/request/step/IOURequestStepConfirmation.tsx 49.35% <100.00%> (ø)
src/components/MoneyRequestConfirmationList.tsx 58.55% <87.50%> (+0.08%) ⬆️
...c/components/ReportActionItem/MoneyRequestView.tsx 0.51% <0.00%> (ø)
...es/iou/request/step/IOURequestStepParticipants.tsx 0.00% <0.00%> (ø)
...ges/iou/request/step/IOURequestStepTaxRatePage.tsx 0.00% <0.00%> (ø)
... and 1 more
... and 6 files with indirect coverage changes

@grgia grgia marked this pull request as ready for review December 16, 2025 10:00
@grgia grgia requested review from a team as code owners December 16, 2025 10:00
@melvin-bot melvin-bot bot requested a review from heyjennahay December 16, 2025 10:00
@grgia grgia requested a review from mountiny December 16, 2025 10:00
@melvin-bot melvin-bot bot removed the request for review from a team December 16, 2025 10:00
@grgia grgia changed the title Revert "Tax field on unreported expense" [CP Staging][Fix Deploy Blocker] Revert "Tax field on unreported expense" Dec 16, 2025
@melvin-bot melvin-bot bot requested review from stitesExpensify and removed request for a team December 16, 2025 10:00
@melvin-bot
Copy link

melvin-bot bot commented Dec 16, 2025

@stitesExpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@grgia grgia removed the request for review from heyjennahay December 16, 2025 10:01
mountiny
mountiny approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@mountiny mountiny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Straight revert

@mountiny mountiny merged commit a06a1e9 into main Dec 16, 2025
33 of 38 checks passed
@mountiny mountiny deleted the revert-76636-feat/72238-taxes-field-v2 branch December 16, 2025 14:48
@melvin-bot
Copy link

melvin-bot bot commented Dec 16, 2025

@mountiny looks like this was merged without a test passing. Please add a note explaining why this was done and remove the Emergency label if this is not an emergency.

@melvin-bot melvin-bot bot added the Emergency label Dec 16, 2025
@mountiny
Copy link
Contributor

mountiny commented Dec 16, 2025 •
edited
Loading

Mentioned above this is fixing a deploy blocker and straight revert

OSBotify pushed a commit that referenced this pull request Dec 16, 2025
@mountiny @OSBotify
Merge pull request #77741 from Expensify/revert-76636-feat/72238-taxe…
5d9e780 
…s-field-v2

[CP Staging][Fix Deploy Blocker] Revert "Tax field on unreported expense"

(cherry picked from commit a06a1e9)

(cherry-picked to staging by mountiny)
@OSBotify OSBotify added the CP Staging marks PRs that have been CP'd to staging label Dec 16, 2025
@OSBotify OSBotify mentioned this pull request Dec 16, 2025
Closed
@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2025

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.78-7 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 16, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.79-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 17, 2025

🚀 Cherry-picked to staging by https://github.com/mountiny in version: 9.2.81-0 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 failure ❌
🍎 iOS 🍎 success ✅

@OSBotify
Copy link
Contributor

OSBotify commented Dec 18, 2025

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform result
🖥 desktop 🖥 success ✅
🕸 web 🕸 success ✅
🤖 android 🤖 success ✅
🍎 iOS 🍎 success ✅

@koko57 koko57 mentioned this pull request Dec 23, 2025
Merged
53 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mountiny mountiny mountiny approved these changes

@stitesExpensify stitesExpensify Awaiting requested review from stitesExpensify

Assignees

@grgia grgia

Labels

CP Staging marks PRs that have been CP'd to staging

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[RCA #76636] Expense - Amount input page shows USD and leads to 0.00 after refreshing the page

3 participants

@grgia @mountiny @OSBotify