fix(search): handle delete expenses from search in offline mode#77110
Conversation
|
@eVoloshchak Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button] |
Codecov Report❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.
|
|
@eVoloshchak, type failure is not related. |
|
@eVoloshchak, the pr is ready for another review, and the failed action is not related to my changes. |
|
Looking good! |
|
@eVoloshchak, I think we should wait for this pr to be merged. because i don't have enough context to update |
|
@marufsharifi the PR above is merged. There are conflicts, could you please address? |
|
@eVoloshchak, @luacmartins, thank you for your patience; the PR is ready for review. thanks |
|
@eVoloshchak, quick bump. thanks. |
|
The lint failure is not related to our changes. btw. |
|
@eVoloshchak, kindly bump. thanks. |
|
Quick bump. @eVoloshchak |
package.json
Outdated
| "react-native-nitro-modules": "0.29.4", | ||
| "react-native-nitro-sqlite": "9.2.0", | ||
| "react-native-onyx": "3.0.32", | ||
| "react-native-onyx": "^3.0.33", |
There was a problem hiding this comment.
| "react-native-onyx": "^3.0.33", | |
| "react-native-onyx": "3.0.33", |
|
This button has to be disabled too Screen.Recording.2026-02-09.at.13.18.14.mov |
@eVoloshchak, thanks, fixed, please take another look. |
|
Lint failure is not related to our changes, btw. |
|
@marufsharifi we have conflicts and some failing checks related to the changes in this PR. |
@luacmartins, conflicts resolved, and the lint failure is not related to our changes. Please take another when you get a chance, thanks. |
|
The failed ESLint checks are unrelated to this PR. I don't think we should add more scope here, so I'll merge it without addressing the failures. |
|
@luacmartins looks like this was merged without a test passing. Please add a note explaining why this was done and remove the |
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/luacmartins in version: 9.3.17-0 🚀
|
|
🚀 Deployed to production by https://github.com/lakchote in version: 9.3.17-9 🚀
|
|
@luacmartins, should I raise a follow-up pr to fix the issue discussed in this comment? thanks. |
|
yes, please |
|
@luacmartins, could you please take a look at this comment. thanks |
|
@marufsharifi we should work on the follow up clean up. Did you have a specific question? |
|
@luacmartins, thanks, I will raise the pr, asap. |
Explanation of Change
Fixed Issues
$ #69559
PROPOSAL: (comment #69559)
Tests
Offline tests
Same as Tests
QA Steps
// TODO: These must be filled out, or the issue title must include "[No QA]."
Same as Tests
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectioncanBeMissingparam foruseOnyxtoggleReportand notonIconClick)src/languages/*files and using the translation methodSTYLE.md) were followedAvatar, I verified the components usingAvatarare working as expected)StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.ScrollViewcomponent to make it scrollable when more elements are added to the page.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Screen.Recording.1404-07-11.at.7.31.02.PM.mov
Screen.Recording.1404-07-03.at.10.34.19.AM.mov
Android: mWeb Chrome
Screen.Recording.1404-07-03.at.10.49.09.AM.mov
Screen.Recording.1404-07-11.at.7.33.56.PM.mp4
iOS: Native
Screen.Recording.1404-07-11.at.6.51.14.PM.mp4
Screen.Recording.1404-07-03.at.10.55.59.AM.mov
iOS: mWeb Safari
Screen.Recording.1404-07-03.at.10.59.03.AM.mov
Screen.Recording.1404-07-11.at.7.22.45.PM.mov
MacOS: Chrome / Safari
Screen.Recording.1404-07-11.at.6.42.46.PM.mov
Screen.Recording.1404-07-03.at.10.22.45.AM.mov