Remove SearchTransaction > canDelete by DylanDylann · Pull Request #77207 · Expensify/App

DylanDylann · 2025-12-10T08:58:17Z

Explanation of Change

Simplify the logic by replacing canDelete with an existing function

Fixed Issues

$ #75453
PROPOSAL:

Tests

Verify that no errors appear in the JS console

Offline tests

QA Steps

Create some expenses
Go to Report > Expense
Select some transactions and check if the delete option display correctly

Verify that no errors appear in the JS console

PR Author Checklist

Screenshots/Videos

Android: Native

Screen.Recording.2025-12-03.at.18.31.03.mov

Android: mWeb Chrome

Screen.Recording.2025-12-03.at.18.30.19.mov

iOS: Native

Screen.Recording.2025-12-03.at.18.28.59.mov

iOS: mWeb Safari

Screen.Recording.2025-12-03.at.18.29.51.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-03.at.17.50.48.mov

melvin-bot · 2025-12-10T08:58:23Z

@Pujan92 Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

DylanDylann · 2025-12-10T08:58:35Z

cc @eh2077

src/pages/Search/SearchPage.tsx

codecov · 2025-12-10T09:06:25Z

Codecov Report

❌ Looks like you've decreased code coverage for some files. Please write tests to increase, or at least maintain, the existing level of code coverage. See our documentation here for how to interpret this table.

Files with missing lines	Coverage Δ
src/components/Search/index.tsx	`32.22% <ø> (ø)`
src/libs/SearchUIUtils.ts	`73.12% <ø> (ø)`
src/pages/Search/SearchPage.tsx	`23.86% <0.00%> (-0.64%)`	⬇️
... and 10 files with indirect coverage changes

trjExpensify · 2025-12-10T13:34:28Z

PR doesn’t need product input as a refactor PR. Unassigning and unsubscribing myself.

luacmartins · 2025-12-10T15:30:55Z

@eh2077 let's prioritize reviewing this one. The previous PR got reverted and we're going with a different approach this time

luacmartins · 2025-12-10T22:58:40Z

@DylanDylann conflicts

eh2077

I also like this new approach (narrower impact scope and safer), just share concerns about combining search result data.

src/pages/Search/SearchPage.tsx

DylanDylann · 2025-12-11T10:14:24Z

@eh2077 I updated, please check again

eh2077 · 2025-12-11T16:09:14Z

src/pages/Search/SearchPage.tsx

    const isMobileSelectionModeEnabled = useMobileSelectionMode();
    const allTransactions = useAllTransactions();
    const [allReports] = useOnyx(ONYXKEYS.COLLECTION.REPORT, {canBeMissing: false});
+    const [allReportActions] = useOnyx(ONYXKEYS.COLLECTION.REPORT_ACTIONS, {canBeMissing: false});


This isn't used after changing to search results

eh2077 · 2025-12-11T16:10:18Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-12.at.8.43.46.AM.mov

Android: mWeb Chrome

Screen.Recording.2025-12-12.at.8.42.09.AM.mov

iOS: HybridApp

Screen.Recording.2025-12-12.at.8.37.42.AM.mov

iOS: mWeb Safari

Screen.Recording.2025-12-12.at.8.39.29.AM.mov

MacOS: Chrome / Safari

Screen.Recording.2025-12-12.at.8.35.21.AM.mov

eh2077 · 2025-12-11T16:27:32Z

too tired today, I'll do tests and complete checklist early tmr.

luacmartins · 2025-12-11T16:38:43Z

@DylanDylann conflicts

DylanDylann · 2025-12-11T16:45:31Z

@luacmartins Done

eh2077

Looks good! Oh, conflicts again cc @DylanDylann 🙇

DylanDylann · 2025-12-12T07:26:20Z

Resolved conflict

OSBotify · 2025-12-12T17:56:43Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2025-12-12T22:29:23Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.78-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

jponikarchuk · 2025-12-16T12:23:57Z

This PR failing because of a regression issue
This issue is reproducible in: All platforms

This reverts commit 591394c, reversing changes made to 8735378.

…andelete [CP Staging] Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

…andelete [CP Staging] Revert "Merge pull request #77207 from DylanDylann/remove-candelete" (cherry picked from commit ce260af) (cherry-picked to staging by lakchote) (cherry-picked to staging by lakchote)

OSBotify · 2025-12-16T22:26:18Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.78-8 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-16T22:48:01Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.79-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-17T12:25:44Z

🚀 Deployed to staging by https://github.com/luacmartins in version: 9.2.81-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T18:47:12Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	failure ❌
🍎 iOS 🍎	success ✅

OSBotify · 2025-12-18T21:10:36Z

🚀 Deployed to production by https://github.com/AndrewGable in version: 9.2.81-5 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

remove canDelete

46106c1

DylanDylann requested review from a team as code owners December 10, 2025 08:58

melvin-bot bot assigned DylanDylann Dec 10, 2025

melvin-bot bot requested review from Pujan92 and trjExpensify and removed request for a team December 10, 2025 08:58

melvin-bot bot removed the request for review from a team December 10, 2025 08:58

github-actions bot reviewed Dec 10, 2025

View reviewed changes

src/pages/Search/SearchPage.tsx Show resolved Hide resolved

github-actions bot reviewed Dec 10, 2025

View reviewed changes

src/pages/Search/SearchPage.tsx Outdated Show resolved Hide resolved

fix UTs

8b34909

trjExpensify removed their request for review December 10, 2025 13:34

luacmartins requested review from eh2077 and removed request for Pujan92 December 10, 2025 15:29

luacmartins self-requested a review December 10, 2025 22:58

luacmartins mentioned this pull request Dec 11, 2025

[$250] Delete option is present for approved expense #77148

Closed

8 tasks

eh2077 reviewed Dec 11, 2025

View reviewed changes

src/pages/Search/SearchPage.tsx Outdated Show resolved Hide resolved

DylanDylann added 2 commits December 11, 2025 16:30

Merge branch 'main' into remove-candelete

75f67ae

Using snapshot data

e3066a6

eh2077 reviewed Dec 11, 2025

View reviewed changes

remove redundant

39670fa

luacmartins requested a review from eh2077 December 11, 2025 20:44

eh2077 reviewed Dec 12, 2025

View reviewed changes

DylanDylann added 3 commits December 12, 2025 14:00

Merge branch 'main' into remove-candelete

537476b

conflict

ab839b3

conflict

4259be4

eh2077 approved these changes Dec 12, 2025

View reviewed changes

luacmartins approved these changes Dec 12, 2025

View reviewed changes

luacmartins merged commit 591394c into Expensify:main Dec 12, 2025
31 checks passed

OSBotify mentioned this pull request Dec 12, 2025

Deploy Checklist: New Expensify 2025-12-12 #77578

Closed

nkdengineer mentioned this pull request Dec 15, 2025

fix: Delete option is present for approved expense #77486

Merged

53 tasks

jponikarchuk mentioned this pull request Dec 16, 2025

Reports - Delete option is missing for unreported expense in Reports > Expenses #77752

Closed

7 tasks

lakchote added a commit that referenced this pull request Dec 16, 2025

Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

c53987e

This reverts commit 591394c, reversing changes made to 8735378.

lakchote added a commit that referenced this pull request Dec 16, 2025

Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

5ff76a2

This reverts commit 591394c, reversing changes made to 8735378.

lakchote added a commit that referenced this pull request Dec 16, 2025

Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

03c915a

This reverts commit 591394c, reversing changes made to 8735378.

lakchote added a commit that referenced this pull request Dec 16, 2025

Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

3c0d17d

This reverts commit 591394c, reversing changes made to 8735378.

lakchote added a commit that referenced this pull request Dec 16, 2025

Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

35e9247

This reverts commit 591394c, reversing changes made to 8735378.

lakchote added a commit that referenced this pull request Dec 16, 2025

Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

de91d91

This reverts commit 591394c, reversing changes made to 8735378.

lakchote added a commit that referenced this pull request Dec 16, 2025

Merge pull request #77787 from Expensify/lucien/revert-77207-remove-c…

ce260af

…andelete [CP Staging] Revert "Merge pull request #77207 from DylanDylann/remove-candelete"

Conversation

DylanDylann commented Dec 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 10, 2025

Uh oh!

DylanDylann commented Dec 10, 2025

Uh oh!

Uh oh!

Uh oh!

codecov bot commented Dec 10, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

trjExpensify commented Dec 10, 2025

Uh oh!

luacmartins commented Dec 10, 2025

Uh oh!

luacmartins commented Dec 10, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

DylanDylann commented Dec 11, 2025

Uh oh!

eh2077 Dec 11, 2025

Choose a reason for hiding this comment

Uh oh!

eh2077 commented Dec 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviewer Checklist

Screenshots/Videos

Uh oh!

eh2077 commented Dec 11, 2025

Uh oh!

luacmartins commented Dec 11, 2025

Uh oh!

DylanDylann commented Dec 11, 2025

Uh oh!

eh2077 left a comment

Choose a reason for hiding this comment

Uh oh!

DylanDylann commented Dec 12, 2025

Uh oh!

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

OSBotify commented Dec 12, 2025

Uh oh!

jponikarchuk commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 16, 2025

Uh oh!

OSBotify commented Dec 17, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

OSBotify commented Dec 18, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

DylanDylann commented Dec 10, 2025 •

edited

Loading

codecov bot commented Dec 10, 2025 •

edited by github-actions bot

Loading

eh2077 commented Dec 11, 2025 •

edited

Loading