Report field - Multiline input for name field in report field does not scroll by mohammadjafarinejad · Pull Request #77324 · Expensify/App

mohammadjafarinejad · 2025-12-11T07:56:02Z

Explanation of Change

Report field - Multiline input for name field in report field does not scroll

Fixed Issues

$ #76785
PROPOSAL: #76785 (comment)

Tests

Sign in to staging.new.expensify.com
Navigate to Workspace > Workspace settings > Report fields
In the "Name" field, enter a long report format eg. ({report:total} | {report:total:usd} | {report:total:EUR})
Remove the last couple of letters
Verify that either:

A scroll is displayed to show all the input by scrolling down, OR
The user can view the far right by navigating right
Verify that no errors appear in the JS console

Offline tests

Same as tests.

QA Steps

Sign in to staging.new.expensify.com
Navigate to Workspace > Workspace settings > Report fields
In the "Name" field, enter a long report format eg. ({report:total} | {report:total:usd} | {report:total:EUR})
Remove the last couple of letters
Verify that either:

A scroll is displayed to show all the input by scrolling down, OR
The user can view the far right by navigating right

PR Author Checklist

Screenshots/Videos

Android: Native

ANDROID.mp4

Android: mWeb Chrome

ANDROID_WEB.mp4

iOS: Native

IOS.mp4

iOS: mWeb Safari

IOS_WEB.mp4

MacOS: Chrome / Safari

WEB.mp4

…t scroll

melvin-bot · 2025-12-11T07:56:09Z

Hey! I see that you made changes to our Form component. Make sure to update the docs in FORMS.md accordingly. Cheers!

codecov · 2025-12-11T08:04:30Z

Codecov Report

✅ Changes either increased or maintained existing code coverage, great job!

Files with missing lines	Coverage Δ
...omponents/TextInput/TextInputMeasurement/index.tsx	`45.45% <ø> (ø)`
src/styles/index.ts	`46.55% <ø> (ø)`
...s/TextInput/BaseTextInput/implementation/index.tsx	`0.00% <0.00%> (ø)`
... and 8 files with indirect coverage changes

…atching

melvin-bot · 2025-12-17T04:25:37Z

@huult Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

huult · 2025-12-17T05:51:54Z

@mohammadjafarinejad Which issue made you change the solution?

mohammadjafarinejad · 2025-12-17T06:15:10Z

@huult On Safari, the bug persists even when visible and hidden inputs have the same width.

Please check the comment in forceSafariTextReflow.

huult · 2025-12-17T06:20:33Z

It looks like a hack to me.

mohammadjafarinejad · 2025-12-17T06:24:22Z

I disabled forceSafariTextReflow in the video to demonstrate this behavior:

REC-20251217101812.mp4

It looks like a hack to me.

I'll try to find a better solution. I'd appreciate any ideas you might have.

huult · 2025-12-17T08:03:54Z

@mohammadjafarinejad I think we should identify the RCA first. If we can’t do that, we should reopen this for proposals.

mohammadjafarinejad · 2025-12-17T08:11:48Z

Okay, I'll update here once I found the root cause and a correct solution.

huult · 2025-12-19T04:14:03Z

@mohammadjafarinejad Do you have any updates?

huult · 2025-12-22T02:40:26Z

@mohammadjafarinejad bump

mohammadjafarinejad · 2025-12-22T08:38:22Z

@mohammadjafarinejad Do you have any updates?

@huult Sorry for the delay. Yes, I found a better solution. I’ll try to update today with the correct solution.

Julesssss · 2025-12-22T23:47:39Z

src/components/TextInput/BaseTextInput/implementation/index.tsx

+        (height: number) => {
+            setTextInputHeight(height);
+
+            // Safari-specific: Force text layout recalculation when height changes


We should avoid platform specific logic like this.

If this is still necessary, ideally it would be extracted to a web-component. Then that component could handle the browser specific logic

mohammadjafarinejad · 2025-12-23T07:38:46Z

Hey @Julesssss @huult

Root Cause Analysis

Our auto-grow implementation works like this:

TextInputMeasurement (hidden input) calculates the correct height
We apply that height to the TextInput wrapper here

The InputComponent itself uses fixed height + overflow: hidden
When users type and the text grows to multiple lines, Safari sometimes flashes the text area or shows a flickering scrollbar. To prevent this, we use a fixed height on the InputComponent.

App/src/components/TextInput/BaseTextInput/implementation/index.tsx

Lines 425 to 428 in fe1a2a3

    
           // Stop scrollbar flashing when breaking lines with autoGrowHeight enabled. 
        
           ...(autoGrowHeight && !isAutoGrowHeightMarkdown 
        
               ? [StyleUtils.getAutoGrowHeightInputStyle(textInputHeight, typeof maxAutoGrowHeight === 'number' ? maxAutoGrowHeight : 0), styles.verticalAlignTop] 
        
               : []),

App/src/styles/utils/index.ts

Lines 1398 to 1404 in e326ba5

    
           return { 
        
               ...styles.pr0, 
        
               ...styles.overflowHidden, 
        
               // maxHeight is not of the input only but the of the whole input container 
        
               // which also includes the top padding and bottom border 
        
               height: maxHeight - styles.textInputMultilineContainer.paddingTop - styles.textInputContainer.borderWidth * 2, 
        
           };

The Bug:

When you delete characters and the number of lines should decrease (e.g., 2 lines → 1 line):

✅ The wrapper height updates correctly
❌ Safari's Shadow DOM doesn't reflow the text

Why? Safari sees the TextInput still has the same fixed height property (even though the value changed) and skips recalculating how text should wrap inside the Shadow DOM. It's likely an optimization that backfires here.

Result: Text stays visually stuck on the old number of lines.

Safari shadow DOM showing stuck text layout

Potential Solutions

Solution 1: Use `text-wrap: balance` on Safari

This forces Safari to recalculate line wrapping, whenever TextInput value changes.

Without `text-wrap: balance`	With `text-wrap: balance`

Downside: Changes text wrapping behavior (distributes words differently across lines).

Solution 2: Force reflow via style manipulation

On Safari, whenever height changes, force line wrapping recalculation by toggling a CSS property, example:

// Force text reflow by temporarily changing wrapping behavior
if ((isSafari() || isMobileSafari()) && height !== textInputHeight && input.current) {
    const element = input.current;
    const originalWhiteSpace = element.style.whiteSpace;

    element.style.whiteSpace = 'nowrap';
    // Force synchronous layout calculation
    void element.offsetHeight; // or element.getBoundingClientRect();
    element.style.whiteSpace = originalWhiteSpace || '';
}

Solution 3: Accept scrollbar flash on Safari

Remove height + overflow: hidden on Safari only, use maxHeight + overflow: auto instead.

Downside: Brief scrollbar flash when adding new lines, but text always reflows correctly.

Question: Which solution/tradeoff should we go with?

Julesssss · 2025-12-23T19:21:23Z

Thanks for sharing details.

I think 2 is best solution here. To confirm though, we can do this with just a style prop change? If so lets go ahead.

mohammadjafarinejad · 2025-12-24T07:46:01Z

@huult Ready for re-review.

New Screenshots/Videos

iOS: mWeb Safari

2_ios_safari.mp4

MacOS: Chrome / Safari

2_safari.mp4

3_IOS.mp4

3_SAFARI.mp4

huult · 2025-12-26T04:11:57Z

src/components/TextInput/TextInputMeasurement/index.tsx

            {!!contentWidth && isPrefixCharacterPaddingCalculated && (
                <View
-                    style={[inputStyle as ViewStyle, styles.hiddenElementOutsideOfWindow, styles.visibilityHidden, styles.wAuto, inputPaddingLeft]}
+                    style={[inputStyle as ViewStyle, styles.hiddenElementOutsideOfWindow, styles.visibilityHidden, styles.wAuto, hiddenInputStyle as ViewStyle, inputPaddingLeft]}


Why do we need hiddenInputStyle here?

You're right, prefix inputs are single-line and don't need this fix.

huult · 2025-12-26T04:14:07Z

src/components/TextInput/TextInputMeasurement/index.tsx

    onSetTextInputWidth,
    onSetTextInputHeight,
    isPrefixCharacterPaddingCalculated,
+    hiddenInputStyle,


Is there any reason we need to introduce a new prop for the TextInputMeasurement component? I see that the native and web versions use the same style.

Thanks, updated.

huult · 2025-12-26T04:29:10Z

Screen.Recording.2025-12-26.at.11.26.22.mov

@mohammadjafarinejad This issue was caused by this PR. Could you please double-check the code? BaseTextInput is used in many places, so after updating it, please verify that the existing usages are still working correctly.

mohammadjafarinejad · 2025-12-29T22:19:10Z

Added new videos (#77324 (comment)). @huult Ready for re-review.

huult · 2025-12-30T03:09:27Z

src/components/TextInput/BaseTextInput/implementation/index.tsx

+        element.style.whiteSpace = 'nowrap';
+        // Force synchronous layout calculation
+        // eslint-disable-next-line no-void
+        void element.offsetHeight;


Suggested change

void element.offsetHeight;

requestAnimationFrame(() => {

element.style.whiteSpace = originalWhiteSpace || '';

});

@mohammadjafarinejad What do you think about using requestAnimationFrame here instead of reading offsetHeight? It can improve performance by avoiding synchronous reflow, especially if textInputHeight changes frequently during typing.

@huult Good idea, updated.

huult · 2025-12-30T03:37:33Z

Reviewer Checklist

I have verified the author checklist is complete (all boxes are checked off).
I verified the correct issue is linked in the ### Fixed Issues section above
I verified testing steps are clear and they cover the changes made in this PR
- I verified the steps for local testing are in the Tests section
- I verified the steps for Staging and/or Production testing are in the QA steps section
- I verified the steps cover any possible failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
- I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
I checked that screenshots or videos are included for tests on all platforms
I included screenshots or videos for tests on all platforms
I verified that the composer does not automatically focus or open the keyboard on mobile unless explicitly intended. This includes checking that returning the app from the background does not unexpectedly open the keyboard.
I verified tests pass on all platforms & I tested again on:
- Android: HybridApp
- Android: mWeb Chrome
- iOS: HybridApp
- iOS: mWeb Safari
- MacOS: Chrome / Safari
If there are any errors in the console that are unrelated to this PR, I either fixed them (preferred) or linked to where I reported them in Slack
I verified there are no new alerts related to the canBeMissing param for useOnyx
I verified proper code patterns were followed (see Reviewing the code)
- I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick).
- I verified that comments were added to code that is not self explanatory
- I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
- I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
- I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
- I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
- I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
- I verified the JSDocs style guidelines (in STYLE.md) were followed
If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
I verified that this PR follows the guidelines as stated in the Review Guidelines
I verified other components that can be impacted by these changes have been tested, and I retested again (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar have been tested & I retested again)
I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
If a new component is created I verified that:
- A similar component doesn't exist in the codebase
- All props are defined accurately and each prop has a /** comment above it */
- The file is named correctly
- The component has a clear name that is non-ambiguous and the purpose of the component can be inferred from the name alone
- The only data being stored in the state is data necessary for rendering and nothing else
- For Class Components, any internal methods passed to components event handlers are bound to this properly so there are no scoping issues (i.e. for onClick={this.submit} the method this.submit should be bound to this in the constructor)
- Any internal methods bound to this are necessary to be bound (i.e. avoid this.submit = this.submit.bind(this); if this.submit is never passed to a component event handler like onClick)
- All JSX used for rendering exists in the render method
- The component has the minimum amount of code necessary for its purpose, and it is broken down into smaller components in order to separate concerns and functions
If any new file was added I verified that:
- The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
If a new CSS style is added I verified that:
- A similar style doesn't already exist
- The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG)
If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
- I verified that all the inputs inside a form are aligned with each other.
- I added Design label and/or tagged @Expensify/design so the design team can review the changes.
If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
For any bug fix or new feature in this PR, I verified that sufficient unit tests are included to prevent regressions in this flow.
If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.
I have checked off every checkbox in the PR reviewer checklist, including those that don't apply to this PR.

Screenshots/Videos

Android: HybridApp

Screen.Recording.2025-12-30.at.10.17.36.mp4

Android: mWeb Chrome

Screen.Recording.2025-12-30.at.10.18.54.mp4

iOS: HybridApp

Screen.Recording.2025-12-30.at.10.21.56.mp4

iOS: mWeb Safari

Screen.Recording.2025-12-30.at.10.23.17.mp4

MacOS: Chrome / Safari

Screen.Recording.2025-12-30.at.10.11.25.mp4

huult

LGTM

OSBotify · 2026-01-05T18:01:16Z

✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release.

OSBotify · 2026-01-06T14:09:10Z

🚀 Deployed to staging by https://github.com/Julesssss in version: 9.2.94-0 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Report field - Multiline input for name field in report field does not scroll

OSBotify · 2026-01-07T13:40:02Z

🚀 Deployed to production by https://github.com/arosiclair in version: 9.2.94-4 🚀

platform	result
🖥 desktop 🖥	success ✅
🕸 web 🕸	success ✅
🤖 android 🤖	success ✅
🍎 iOS 🍎	success ✅

Report field - Multiline input for name field in report field does no…

1f621ac

…t scroll

melvin-bot bot assigned mohammadjafarinejad Dec 11, 2025

mohammadjafarinejad added 4 commits December 16, 2025 10:57

Add hidden input style to TextInputMeasurement for proper dimension m…

e82d57a

…atching

Merge branch 'Expensify:main' into fix/76785

ae4ec50

Add hidden input style to match visible input dimensions

3c9e48e

fix: force text reflow in safari

b9cfde4

mohammadjafarinejad marked this pull request as ready for review December 17, 2025 04:25

mohammadjafarinejad requested review from a team as code owners December 17, 2025 04:25

melvin-bot bot requested review from heyjennahay and huult and removed request for a team December 17, 2025 04:25

melvin-bot bot removed the request for review from a team December 17, 2025 04:25

mohammadjafarinejad mentioned this pull request Dec 17, 2025

[$250] Report field - Multiline input for name field in report field does not scroll #76785

Closed

16 tasks

Merge branch 'main' into fix/76785

7fd62d1

Julesssss reviewed Dec 22, 2025

View reviewed changes

Refactor Safari text reflow handling in BaseTextInput

5389896

huult reviewed Dec 26, 2025

View reviewed changes

mohammadjafarinejad added 6 commits December 30, 2025 00:59

refactor: move hiddenInputStyle to TextInputMeasurement

58cc519

Merge branch 'Expensify:main' into fix/76785

4104a1d

refactor: remove unnecessary style

68933a1

chore: prettier

93b091f

Merge branch 'Expensify:main' into fix/76785

545a23b

chore: prettier

b2b2029

huult reviewed Dec 30, 2025

View reviewed changes

mohammadjafarinejad added 2 commits December 30, 2025 18:19

Merge branch 'Expensify:main' into fix/76785

91fc13f

Improve layout calculation in BaseTextInput for better performance

2137bb1

huult approved these changes Dec 31, 2025

View reviewed changes

melvin-bot bot requested a review from Julesssss December 31, 2025 06:02

Julesssss approved these changes Jan 5, 2026

View reviewed changes

Julesssss merged commit 6d6576d into Expensify:main Jan 5, 2026
33 checks passed

OSBotify mentioned this pull request Jan 6, 2026

Deploy Checklist: New Expensify 2026-01-06 #78900

Closed

53 tasks

situchan mentioned this pull request Jan 6, 2026

Revert "Report field - Multiline input for name field in report field does not scroll" #78903

Merged

54 tasks

arosiclair mentioned this pull request Jan 6, 2026

[Due for payment 2026-01-15] Expense - Extra spacing between amount and distance unit #78901

Closed

7 tasks

abzokhattab pushed a commit to abzokhattab/App that referenced this pull request Jan 6, 2026

Merge pull request Expensify#77324 from mohammadjafarinejad/fix/76785

9c0ab40

Report field - Multiline input for name field in report field does not scroll

OSBotify mentioned this pull request Jan 13, 2026

[Due for payment 2026-01-27] Reports - Another title row display below save button when editing report title #79414

Closed

7 tasks

mohammadjafarinejad mentioned this pull request Jan 30, 2026

Multiline input for name field in report field does not scroll (V2) #81005

Merged

53 tasks

Conversation

mohammadjafarinejad commented Dec 11, 2025 • edited by Julesssss Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Explanation of Change

Fixed Issues

Tests

Offline tests

QA Steps

PR Author Checklist

Screenshots/Videos

Uh oh!

melvin-bot bot commented Dec 11, 2025

Uh oh!

codecov bot commented Dec 11, 2025 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

melvin-bot bot commented Dec 17, 2025

Uh oh!

huult commented Dec 17, 2025

Uh oh!

mohammadjafarinejad commented Dec 17, 2025

Uh oh!

huult commented Dec 17, 2025

Uh oh!

mohammadjafarinejad commented Dec 17, 2025

Uh oh!

huult commented Dec 17, 2025

Uh oh!

mohammadjafarinejad commented Dec 17, 2025

Uh oh!

huult commented Dec 19, 2025

Uh oh!

huult commented Dec 22, 2025

Uh oh!

mohammadjafarinejad commented Dec 22, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mohammadjafarinejad commented Dec 23, 2025

Root Cause Analysis

Potential Solutions

Solution 1: Use text-wrap: balance on Safari

Solution 2: Force reflow via style manipulation

Solution 3: Accept scrollbar flash on Safari

Uh oh!

Julesssss commented Dec 23, 2025

Uh oh!

mohammadjafarinejad commented Dec 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

New Screenshots/Videos

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult commented Dec 26, 2025

Uh oh!

mohammadjafarinejad commented Dec 29, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

huult commented Dec 30, 2025

Reviewer Checklist

Screenshots/Videos

Uh oh!

huult left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

OSBotify commented Jan 5, 2026

Uh oh!

mohammadjafarinejad commented Dec 11, 2025 •

edited by Julesssss

Loading

codecov bot commented Dec 11, 2025 •

edited by github-actions bot

Loading

Solution 1: Use `text-wrap: balance` on Safari

mohammadjafarinejad commented Dec 24, 2025 •

edited

Loading